Completed
Push — master ( db6b00...5246ee )
by
unknown
08:09 queued 11s
created
includes/Store/Sql/Terms/TermStoresDelegatingPrefetchingItemTermLookup.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -59,8 +59,8 @@
 block discarded – undo
59 59
 	 * Loads a set of terms into the buffer.
60 60
 	 * The source from which to fetch would typically be supplied to the buffer's constructor.
61 61
 	 * @param EntityId[] $entityIds
62
-	 * @param string[]|null $termTypes The desired term types; null means all.
63
-	 * @param string[]|null $languageCodes The desired languages; null means all.
62
+	 * @param string[] $termTypes The desired term types; null means all.
63
+	 * @param string[] $languageCodes The desired languages; null means all.
64 64
 	 */
65 65
 	public function prefetchTerms( array $entityIds, array $termTypes, array $languageCodes ) {
66 66
 		Assert::parameterElementType( ItemId::class, $entityIds, '$entityIds' );
Please login to merge, or discard this patch.
repo/tests/phpunit/includes/Content/EntityContentTestCase.php 1 patch
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -91,6 +91,10 @@
 block discarded – undo
91 91
 		$this->assertSame( $expected, $entityContent->getTextForSearchIndex() );
92 92
 	}
93 93
 
94
+	/**
95
+	 * @param string $languageCode
96
+	 * @param string $text
97
+	 */
94 98
 	private function setLabel( EntityDocument $entity, $languageCode, $text ) {
95 99
 		if ( !( $entity instanceof LabelsProvider ) ) {
96 100
 			throw new InvalidArgumentException( '$entity must be a LabelsProvider' );
Please login to merge, or discard this patch.
lib/tests/phpunit/Store/ItemTermStoreWriterAdapterTest.php 1 patch
Doc Comments   +6 added lines patch added patch discarded remove patch
@@ -57,6 +57,9 @@  discard block
 block discarded – undo
57 57
 		);
58 58
 	}
59 59
 
60
+	/**
61
+	 * @return EntityDocument
62
+	 */
60 63
 	private function newUnsupportedEntity() {
61 64
 		return $this->createMock( EntityDocument::class );
62 65
 	}
@@ -68,6 +71,9 @@  discard block
 block discarded – undo
68 71
 		$writer->deleteTermsOfEntity( $this->newUnsupportedId() );
69 72
 	}
70 73
 
74
+	/**
75
+	 * @return EntityId
76
+	 */
71 77
 	public function newUnsupportedId() {
72 78
 		return $this->createMock( EntityId::class );
73 79
 	}
Please login to merge, or discard this patch.
lib/tests/phpunit/Store/PropertyTermStoreWriterAdapterTest.php 1 patch
Doc Comments   +6 added lines patch added patch discarded remove patch
@@ -57,6 +57,9 @@  discard block
 block discarded – undo
57 57
 		);
58 58
 	}
59 59
 
60
+	/**
61
+	 * @return EntityDocument
62
+	 */
60 63
 	private function newUnsupportedEntity() {
61 64
 		return $this->createMock( EntityDocument::class );
62 65
 	}
@@ -68,6 +71,9 @@  discard block
 block discarded – undo
68 71
 		$writer->deleteTermsOfEntity( $this->newUnsupportedId() );
69 72
 	}
70 73
 
74
+	/**
75
+	 * @return EntityId
76
+	 */
71 77
 	public function newUnsupportedId() {
72 78
 		return $this->createMock( EntityId::class );
73 79
 	}
Please login to merge, or discard this patch.
tests/phpunit/Store/Sql/Terms/DatabaseTermStoreWriterTestGetTermsTrait.php 1 patch
Doc Comments   +5 added lines patch added patch discarded remove patch
@@ -25,6 +25,11 @@
 block discarded – undo
25 25
  */
26 26
 trait DatabaseTermStoreWriterTestGetTermsTrait {
27 27
 
28
+	/**
29
+	 * @param string $termsTable
30
+	 * @param string $termInLangField
31
+	 * @param string $idField
32
+	 */
28 33
 	private function getTerms( Int32EntityId $entityId, $termsTable, $termInLangField, $idField ): Fingerprint {
29 34
 		$loadBalancer = new FakeLoadBalancer( [
30 35
 			'dbr' => $this->db,
Please login to merge, or discard this patch.
repo/tests/phpunit/includes/Store/Sql/WikiPageEntityMetaDataLookupTest.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -85,6 +85,7 @@  discard block
 block discarded – undo
85 85
 	}
86 86
 
87 87
 	/**
88
+	 * @param EntityNamespaceLookup $namespaceLookup
88 89
 	 * @return WikiPageEntityMetaDataLookup
89 90
 	 */
90 91
 	private function getWikiPageEntityMetaDataLookup( $namespaceLookup = null ) {
@@ -163,6 +164,8 @@  discard block
 block discarded – undo
163 164
 
164 165
 	/**
165 166
 	 * Gets a "lagged" database connection: We always leave out the first row on select.
167
+	 * @param integer $selectCount
168
+	 * @param integer $selectRowCount
166 169
 	 */
167 170
 	private function getLaggedDatabase( IDatabase $realDB, $selectCount, $selectRowCount ) {
168 171
 		$db = $this->getMockBuilder( IDatabase::class )
Please login to merge, or discard this patch.
repo/tests/phpunit/includes/RepoHooksTest.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -514,6 +514,9 @@
 block discarded – undo
514 514
 		$this->assertTrue( $canBeMoved );
515 515
 	}
516 516
 
517
+	/**
518
+	 * @param integer $propertyNamespace
519
+	 */
517 520
 	private function newEntitySourceSettings( $itemNamespace, $propertyNamespace ) {
518 521
 		global $wgWBRepoSettings;
519 522
 
Please login to merge, or discard this patch.
repo/tests/phpunit/includes/Rdf/PropertyRdfBuilderTest.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -62,6 +62,9 @@
 block discarded – undo
62 62
 		);
63 63
 	}
64 64
 
65
+	/**
66
+	 * @param string $dataSetName
67
+	 */
65 68
 	private function assertOrCreateNTriples( $dataSetName, RdfWriter $writer ) {
66 69
 		$actual = $writer->drain();
67 70
 		$expected = $this->getTestData()->getNTriples( $dataSetName );
Please login to merge, or discard this patch.
lib/includes/SimpleCacheWithBagOStuff.php 1 patch
Doc Comments   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -58,7 +58,7 @@  discard block
 block discarded – undo
58 58
 	 * Fetches a value from the cache.
59 59
 	 *
60 60
 	 * @param string $key The unique key of this item in the cache.
61
-	 * @param mixed $default Default value to return if the key does not exist.
61
+	 * @param string $default Default value to return if the key does not exist.
62 62
 	 *
63 63
 	 * @return mixed The value of the item from the cache, or $default in case of cache miss.
64 64
 	 *
@@ -80,8 +80,8 @@  discard block
 block discarded – undo
80 80
 	 * Persists data in the cache, uniquely referenced by a key with an optional expiration TTL time.
81 81
 	 *
82 82
 	 * @param string $key The key of the item to store.
83
-	 * @param mixed $value The value of the item to store, must be serializable.
84
-	 * @param null|int|DateInterval $ttl Optional. The TTL value of this item. If no value is sent and
83
+	 * @param string $value The value of the item to store, must be serializable.
84
+	 * @param integer $ttl Optional. The TTL value of this item. If no value is sent and
85 85
 	 *                                      the driver supports TTL then the library may set a default value
86 86
 	 *                                      for it or let the driver take care of that.
87 87
 	 *
@@ -128,8 +128,8 @@  discard block
 block discarded – undo
128 128
 	/**
129 129
 	 * Obtains multiple cache items by their unique keys.
130 130
 	 *
131
-	 * @param iterable $keys A list of keys that can obtained in a single operation.
132
-	 * @param mixed $default Default value to return for keys that do not exist.
131
+	 * @param string[] $keys A list of keys that can obtained in a single operation.
132
+	 * @param string $default Default value to return for keys that do not exist.
133 133
 	 *
134 134
 	 * @return iterable A list of key => value pairs. Cache keys that do not exist or are stale will have $default as value.
135 135
 	 *
@@ -169,7 +169,7 @@  discard block
 block discarded – undo
169 169
 	 * Persists a set of key => value pairs in the cache, with an optional TTL.
170 170
 	 *
171 171
 	 * @param iterable $values A list of key => value pairs for a multiple-set operation.
172
-	 * @param null|int|DateInterval $ttl Optional. The TTL value of this item. If no value is sent and
172
+	 * @param integer $ttl Optional. The TTL value of this item. If no value is sent and
173 173
 	 *                                       the driver supports TTL then the library may set a default value
174 174
 	 *                                       for it or let the driver take care of that.
175 175
 	 *
Please login to merge, or discard this patch.