Completed
Push — master ( db6b00...5246ee )
by
unknown
08:09 queued 11s
created
repo/includes/ChangeOp/ChangeOpFingerprint.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -25,6 +25,9 @@
 block discarded – undo
25 25
 		$this->termValidatorFactory = $termValidatorFactory;
26 26
 	}
27 27
 
28
+	/**
29
+	 * @param NullChangeOp $changeOps
30
+	 */
28 31
 	public function add( $changeOps ) {
29 32
 		$this->innerChangeOps->add( $changeOps );
30 33
 	}
Please login to merge, or discard this patch.
repo/includes/Validators/ByIdFingerprintUniquenessValidator.php 1 patch
Doc Comments   +6 added lines patch added patch discarded remove patch
@@ -53,6 +53,9 @@  discard block
 block discarded – undo
53 53
 		}
54 54
 	}
55 55
 
56
+	/**
57
+	 * @param ChangeOpFingerprintResult $value
58
+	 */
56 59
 	private function validateProperty( $value ) {
57 60
 		if ( $this->propertyTermsMigrationStage > MIGRATION_WRITE_BOTH ) {
58 61
 			return $this->fingerprintUniquenessValidator->validate( $value );
@@ -61,6 +64,9 @@  discard block
 block discarded – undo
61 64
 		return Result::newSuccess();
62 65
 	}
63 66
 
67
+	/**
68
+	 * @param ChangeOpFingerprintResult $value
69
+	 */
64 70
 	private function validateItem( $value, ItemId $itemId ) {
65 71
 		$entityNumericId = $itemId->getNumericId();
66 72
 		foreach ( $this->itemTermsMigrationStages as $maxId => $migrationStage ) {
Please login to merge, or discard this patch.
repo/includes/Validators/FingerprintUniquenessValidator.php 1 patch
Doc Comments   +7 added lines patch added patch discarded remove patch
@@ -213,6 +213,9 @@  discard block
 block discarded – undo
213 213
 		}
214 214
 	}
215 215
 
216
+	/**
217
+	 * @param string|false $termType
218
+	 */
216 219
 	private function getEntityTerm( EntityId $entityId, $lang, $termType ): string {
217 220
 		if ( $termType === 'label' ) {
218 221
 			return $this->termLookup->getLabel( $entityId, $lang ) ?? '';
@@ -223,6 +226,10 @@  discard block
 block discarded – undo
223 226
 		throw new InvalidArgumentException( "\$termType can only be 'label' or 'property'. '{$termType}' was given" );
224 227
 	}
225 228
 
229
+	/**
230
+	 * @param string $code
231
+	 * @param EntityId $collidingEntityId
232
+	 */
226 233
 	private function collisionToError( $code, $collidingEntityId, $lang, $label ) {
227 234
 		return new UniquenessViolation(
228 235
 			$collidingEntityId,
Please login to merge, or discard this patch.
repo/tests/phpunit/includes/Specials/SpecialMergeItemsTest.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -212,6 +212,9 @@
 block discarded – undo
212 212
 		return $titleLookup;
213 213
 	}
214 214
 
215
+	/**
216
+	 * @return string
217
+	 */
215 218
 	private function executeSpecialMergeItems( $params, User $user = null ) {
216 219
 		if ( !$user ) {
217 220
 			// TODO Matching the token of a non-anonymous user is complicated.
Please login to merge, or discard this patch.
repo/tests/phpunit/includes/Specials/SpecialRedirectEntityTest.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -151,6 +151,9 @@
 block discarded – undo
151 151
 		);
152 152
 	}
153 153
 
154
+	/**
155
+	 * @return string
156
+	 */
154 157
 	private function executeSpecialEntityRedirect( array $params, User $user = null ) {
155 158
 		if ( !$user ) {
156 159
 			// TODO Matching the token of a non-anonymous user is complicated.
Please login to merge, or discard this patch.
repo/maintenance/rebuildTermsSearchKey.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -32,7 +32,7 @@
 block discarded – undo
32 32
 	/**
33 33
 	 * @see LoggedUpdateMaintenance::doDBUpdates
34 34
 	 *
35
-	 * @return bool
35
+	 * @return null|boolean
36 36
 	 */
37 37
 	public function doDBUpdates() {
38 38
 		if ( !WikibaseSettings::isRepoEnabled() ) {
Please login to merge, or discard this patch.
client/includes/Api/PageTerms.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -123,7 +123,7 @@
 block discarded – undo
123 123
 
124 124
 	/**
125 125
 	 * @param Title[] $titles
126
-	 * @param int|null $continue
126
+	 * @param integer $continue
127 127
 	 *
128 128
 	 * @return array
129 129
 	 */
Please login to merge, or discard this patch.
repo/includes/EditEntity/MediawikiEditEntityFactory.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -89,7 +89,7 @@
 block discarded – undo
89 89
 	/**
90 90
 	 * @param User $user the user performing the edit
91 91
 	 * @param EntityId|null $entityId the id of the entity to edit
92
-	 * @param bool|int|null $baseRevId the base revision ID for conflict checking.
92
+	 * @param integer $baseRevId the base revision ID for conflict checking.
93 93
 	 *        Use 0 to indicate that the current revision should be used as the base revision,
94 94
 	 *        effectively disabling conflict detections. true and false will be accepted for
95 95
 	 *        backwards compatibility, but both will be treated like 0. Note that the behavior
Please login to merge, or discard this patch.
data-access/tests/phpunit/FakePrefetchingTermLookup.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -17,9 +17,9 @@
 block discarded – undo
17 17
 	private $buffer;
18 18
 
19 19
 	/**
20
-	 * @param array $entityIds
21
-	 * @param array|null $termTypes if null, defaults to labels and descriptions only
22
-	 * @param array|null $languageCodes if null, defaults to de and en
20
+	 * @param \Wikibase\DataModel\Entity\ItemId[] $entityIds
21
+	 * @param string[] $termTypes if null, defaults to labels and descriptions only
22
+	 * @param string[] $languageCodes if null, defaults to de and en
23 23
 	 */
24 24
 	public function prefetchTerms( array $entityIds, array $termTypes, array $languageCodes ) {
25 25
 		if ( $termTypes === null ) {
Please login to merge, or discard this patch.