Completed
Push — master ( db6b00...5246ee )
by
unknown
08:09 queued 11s
created
lib/includes/Store/CachingPrefetchingTermLookup.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -269,7 +269,7 @@
 block discarded – undo
269 269
 	 * @param EntityId $entityId
270 270
 	 * @param string $termType
271 271
 	 * @param string $languageCode
272
-	 * @param string|string[] $freshTerm string for existing label or description, string[] for existing aliases
272
+	 * @param string $freshTerm string for existing label or description, string[] for existing aliases
273 273
 	 *                                   Should never be null or false @see bufferAndCacheMissingTerm
274 274
 	 */
275 275
 	private function bufferAndCacheExistingTerm( EntityId $entityId, string $termType, string $languageCode, $freshTerm ): void {
Please login to merge, or discard this patch.
repo/tests/phpunit/includes/Store/CachingPrefetchingTermLookupTest.php 1 patch
Doc Comments   +6 added lines patch added patch discarded remove patch
@@ -646,6 +646,9 @@  discard block
 block discarded – undo
646 646
 		return $revisionAndRedirectResolver;
647 647
 	}
648 648
 
649
+	/**
650
+	 * @return string
651
+	 */
649 652
 	private function buildTestCacheKey(
650 653
 		string $itemId,
651 654
 		string $termType,
@@ -663,6 +666,9 @@  discard block
 block discarded – undo
663 666
 		return $mockCache;
664 667
 	}
665 668
 
669
+	/**
670
+	 * @param boolean $fillValue
671
+	 */
666 672
 	private function newMockCacheExpectingKeys( array $expectedCacheKeys, $fillValue = null ): CacheInterface {
667 673
 		$cache = $this->createMock( CacheInterface::class );
668 674
 		$cache->expects( $this->once() )
Please login to merge, or discard this patch.
repo/includes/LinkedData/EntityDataFormatProvider.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -149,7 +149,7 @@
 block discarded – undo
149 149
 	 *
150 150
 	 * @param string $format A canonical format name, as returned by getFormatName() or getSupportedFormats().
151 151
 	 *
152
-	 * @return string|null
152
+	 * @return string
153 153
 	 */
154 154
 	public function getMimeType( $format ) {
155 155
 		$this->initFormats();
Please login to merge, or discard this patch.
repo/tests/phpunit/includes/FederatedProperties/Api/SetClaimTest.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -68,6 +68,9 @@
 block discarded – undo
68 68
 		] );
69 69
 	}
70 70
 
71
+	/**
72
+	 * @param Statement $statement
73
+	 */
71 74
 	private function getSerializedStatement( $statement ) {
72 75
 		$statementSerializer = ( new SerializerFactory( new DataValueSerializer() ) )->newStatementSerializer();
73 76
 		return $statementSerializer->serialize( $statement );
Please login to merge, or discard this patch.
tests/phpunit/includes/FederatedProperties/FederatedPropertiesTestTrait.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -23,6 +23,9 @@
 block discarded – undo
23 23
 		$this->setWbSetting( 'federatedPropertiesEnabled', true );
24 24
 	}
25 25
 
26
+	/**
27
+	 * @param string|boolean $value
28
+	 */
26 29
 	private function setWbSetting( string $name, $value ) {
27 30
 		$this->setWbSettingInGlobalIfMwIntegrationTest( $name, $value );
28 31
 		$this->setWbSettingInSettings( $name, $value );
Please login to merge, or discard this patch.
repo/includes/FederatedProperties/FederatedPropertiesError.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -21,6 +21,7 @@
 block discarded – undo
21 21
 	 * @param LabelsProvider $entity
22 22
 	 * @param string $msg Message key (string) for error text
23 23
 	 * @param array $params Array with parameters to wfMessage()
24
+	 * @param string|null $languageCode
24 25
 	 *
25 26
 	 * @suppress SecurityCheck-DoubleEscaped
26 27
 	 */
Please login to merge, or discard this patch.
repo/includes/FederatedProperties/SummaryParsingPrefetchHelper.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -34,7 +34,7 @@
 block discarded – undo
34 34
 
35 35
 	/**
36 36
 	 * @param IResultWrapper|array $rows
37
-	 * @param array $languageCodes
37
+	 * @param string[] $languageCodes
38 38
 	 * @param array $termTypes
39 39
 	 */
40 40
 	public function prefetchFederatedProperties( $rows, array $languageCodes, array $termTypes ) : void {
Please login to merge, or discard this patch.
FederatedProperties/Hooks/DifferenceEngineViewHeaderHookHandlerTest.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -182,6 +182,9 @@
 block discarded – undo
182 182
 		return $rows;
183 183
 	}
184 184
 
185
+	/**
186
+	 * @param string $titleText
187
+	 */
185 188
 	private function getMockedDiffEngine( $getOldRevision, $getNewRevision, $titleText ) {
186 189
 		$diffEngine = $this->createMock( DifferenceEngine::class );
187 190
 		$diffEngine->expects( $this->once() )
Please login to merge, or discard this patch.
repo/tests/phpunit/includes/Hooks/LabelPrefetchHookHandlerTestBase.php 1 patch
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -55,7 +55,6 @@  discard block
 block discarded – undo
55 55
 	 * @param string[] $termTypes
56 56
 	 * @param string[] $languageCodes
57 57
 	 * @param PrefetchingTermLookup|null $prefetchingTermLookup
58
-	 * @param EntityLookup|null $entityLookup
59 58
 	 * @param bool $federatedPropertiesEnabled
60 59
 	 * @return LabelPrefetchHookHandler
61 60
 	 */
@@ -103,6 +102,10 @@  discard block
 block discarded – undo
103 102
 		);
104 103
 	}
105 104
 
105
+	/**
106
+	 * @param string[] $expectedTermTypes
107
+	 * @param string[] $expectedLanguageCodes
108
+	 */
106 109
 	protected function getPrefetchTermsCallback( $expectedIds, $expectedTermTypes, $expectedLanguageCodes ) {
107 110
 		$prefetchTerms = function (
108 111
 			array $entityIds,
Please login to merge, or discard this patch.