wikimedia / mediawiki-extensions-Wikibase

client/includes/Hooks/SkinAfterBottomScriptsHandler.php

Unused Use Statements -1 removed lines

@@ -7,7 +7,6 @@
 use Html;
 use PageImages\PageImages;
 use Title;
-
 use Wikibase\Client\RepoLinker;
 use Wikibase\Client\WikibaseClient;
 use Wikibase\DataModel\Entity\EntityDocument;

client/tests/phpunit/integration/includes/Changes/InjectRCRecordsJobTest.php

Doc Comments +2 added lines, -2 removed lines

@@ -87,7 +87,7 @@ 
 	}
 
 	/**
-	 * @return RecentChangesFinder|MockObject
+	 * @return RecentChangesFinder
 	 */
 	private function getRCDupeDetectorMock() {
 		$rcDupeDetector = $this->getMockBuilder( RecentChangesFinder::class )
@@ -117,7 +117,7 @@ 
 	 * @param string $text
 	 * @param int $id
 	 *
-	 * @return Title|MockObject
+	 * @return \Wikibase\DataModel\Entity\EntityId
 	 */
 	private function getTitleMock( $text, $id = 23 ) {
 		$title = $this->getMockBuilder( Title::class )

lib/tests/phpunit/ServiceByTypeDispatcherTest.php

Doc Comments +3 added lines

@@ -26,6 +26,9 @@
 		yield 'default not matching type' => [ false, EntityUrlLookup::class, [], new stdClass() ];
 	}
 
+	/**
+	 * @param stdClass $fakeServiceToReturn
+	 */
 	private function getSomeServiceReturningCallback( $fakeServiceToReturn = null ) {
 		return function () use ( $fakeServiceToReturn ) {
 			return $fakeServiceToReturn ?? new stdClass();

repo/includes/Hooks/HtmlPageLinkRendererEndHookHandler.php

Doc Comments +1 added lines, -1 removed lines

@@ -335,7 +335,7 @@
 	 * @param Title|null $currentTitle
 	 * @param RequestContext $context
 	 *
-	 * @return bool
+	 * @return null|boolean
 	 */
 	private function shouldConvert( ?Title $currentTitle, RequestContext $context ) {
 		static $shouldConvert = null;

repo/includes/RepoHooks.php

Doc Comments +6 added lines, -1 removed lines

@@ -170,6 +170,7 @@ 
 	 *
 	 * @param int $ns Namespace ID
 	 * @param bool &$movable
+	 * @param boolean $movable
 	 */
 	public static function onNamespaceIsMovable( $ns, &$movable ) {
 		if ( self::isNamespaceUsedByLocalEntities( $ns ) ) {
@@ -177,6 +178,9 @@ 
 		}
 	}
 
+	/**
+	 * @param integer $namespace
+	 */
 	private static function isNamespaceUsedByLocalEntities( $namespace ) {
 		$wikibaseRepo = WikibaseRepo::getDefaultInstance();
 		$namespaceLookup = $wikibaseRepo->getEntityNamespaceLookup();
@@ -774,6 +778,7 @@ 
 	 * @param string $contentModel
 	 * @param LinkTarget $title Actually a Title object, but we only require getNamespace
 	 * @param bool &$ok
+	 * @param boolean $ok
 	 *
 	 * @return bool
 	 */
@@ -852,7 +857,7 @@ 
 	/**
 	 * Helper for onAPIQuerySiteInfoStatisticsInfo
 	 *
-	 * @param object $row
+	 * @param \stdClass|null $row
 	 * @return array
 	 */
 	private static function formatDispatchRow( $row ) {

repo/tests/phpunit/includes/ParserOutput/FullEntityParserOutputGeneratorIntegrationTest.php

Doc Comments +6 added lines

@@ -111,6 +111,9 @@ 
 			->getEntityParserOutputGenerator( Language::factory( 'en' ) );
 	}
 
+	/**
+	 * @param string $id
+	 */
 	private function saveItem( $id ) {
 		$this->entityStore->saveEntity(
 			new Item( new ItemId( $id ) ),
@@ -119,6 +122,9 @@ 
 		);
 	}
 
+	/**
+	 * @param string $id
+	 */
 	private function saveProperty( $id ) {
 		$this->entityStore->saveEntity(
 			new Property( new PropertyId( $id ), null, 'wikibase-item' ),

repo/tests/phpunit/includes/FederatedProperties/ApiEntitySearchHelperTest.php

Doc Comments +8 added lines, -4 removed lines

@@ -55,6 +55,9 @@ 
 		return new ApiEntitySearchHelper( $api, $dataTypes );
 	}
 
+	/**
+	 * @param string $responseDataFile
+	 */
 	private function setupTestApi( &$params, $langCode, $responseDataFile, $statusCode = 200 ) {
 		$params = array_merge( $params, [ 'language' => $langCode, 'uselang' => $langCode, 'format' => 'json' ] );
 		$api = $this->createMock( GenericActionApiClient::class );
@@ -151,8 +154,8 @@ 
 	/**
 	 * @dataProvider paramsAndExpectedResponseProvider
 	 * @param string $responseDataFile
-	 * @param int $expectedResultCount
-	 * @param array $expectedResultsEntityId
+	 * @param int $expectedResultsEntityIds
+	 * @param array $expectedResultsEntityIds
 	 * @throws ApiRequestException
 	 */
 	public function testGetRankedSearchResults( $langCode, $params, $responseDataFile, $expectedResultsEntityIds ) {
@@ -219,6 +222,9 @@ 
 		}
 	}
 
+	/**
+	 * @param integer $statusCode
+	 */
 	private function newMockResponse( $responseDataFile, $statusCode ) {
 		$mwResponse = $this->createMock( ResponseInterface::class );
 		$mwResponse->expects( $this->any() )
@@ -246,8 +252,6 @@ 
 	/**
 	 * @dataProvider invalidParamsAndUnexpectedResponseProvider
 	 * @param string $responseDataFile
-	 * @param int $expectedResultCount
-	 * @param array $expectedResultsEntityId
 	 */
 	public function testApiResponseStructureIsValid( $langCode, $params, $responseDataFile, $statusCode ) {
 		$api = $this->setupTestApi( $params, $langCode, $responseDataFile, $statusCode );

client/tests/phpunit/integration/includes/Hooks/DataUpdateHookHandlerTest.php

Doc Comments -1 removed lines

@@ -127,7 +127,6 @@
 	}
 
 	/**
-	 * @param Title $title
 	 * @param array|null $currentUsages
 	 *
 	 * @return UsageLookup

client/includes/Hooks/ChangesListSpecialPageHookHandler.php

Doc Comments +2 added lines

@@ -65,6 +65,8 @@
 	 * @param array &$query_options Array of options for the database request
 	 * @param array &$join_conds Join conditions for the tables
 	 * @param \FormOptions $opts FormOptions for this request
+	 * @param string[] $tables
+	 * @param string[] $fields
 	 */
 	public function onChangesListSpecialPageQuery( $name, &$tables, &$fields,
 			&$conds, &$query_options, &$join_conds, $opts ) {