wikimedia / mediawiki-extensions-Wikibase

repo/tests/phpunit/includes/Rdf/PropertyRdfBuilderTest.php

Doc Comments +3 added lines

@@ -62,6 +62,9 @@
 		);
 	}
 
+	/**
+	 * @param string $dataSetName
+	 */
 	private function assertOrCreateNTriples( $dataSetName, RdfWriter $writer ) {
 		$actual = $writer->drain();
 		$expected = $this->getTestData()->getNTriples( $dataSetName );

lib/includes/SimpleCacheWithBagOStuff.php

Doc Comments +6 added lines, -6 removed lines

@@ -58,7 +58,7 @@ 
 	 * Fetches a value from the cache.
 	 *
 	 * @param string $key The unique key of this item in the cache.
-	 * @param mixed $default Default value to return if the key does not exist.
+	 * @param string $default Default value to return if the key does not exist.
 	 *
 	 * @return mixed The value of the item from the cache, or $default in case of cache miss.
 	 *
@@ -80,8 +80,8 @@ 
 	 * Persists data in the cache, uniquely referenced by a key with an optional expiration TTL time.
 	 *
 	 * @param string $key The key of the item to store.
-	 * @param mixed $value The value of the item to store, must be serializable.
-	 * @param null|int|DateInterval $ttl Optional. The TTL value of this item. If no value is sent and
+	 * @param string $value The value of the item to store, must be serializable.
+	 * @param integer $ttl Optional. The TTL value of this item. If no value is sent and
 	 *                                      the driver supports TTL then the library may set a default value
 	 *                                      for it or let the driver take care of that.
 	 *
@@ -128,8 +128,8 @@ 
 	/**
 	 * Obtains multiple cache items by their unique keys.
 	 *
-	 * @param iterable $keys A list of keys that can obtained in a single operation.
-	 * @param mixed $default Default value to return for keys that do not exist.
+	 * @param string[] $keys A list of keys that can obtained in a single operation.
+	 * @param string $default Default value to return for keys that do not exist.
 	 *
 	 * @return iterable A list of key => value pairs. Cache keys that do not exist or are stale will have $default as value.
 	 *
@@ -169,7 +169,7 @@ 
 	 * Persists a set of key => value pairs in the cache, with an optional TTL.
 	 *
 	 * @param iterable $values A list of key => value pairs for a multiple-set operation.
-	 * @param null|int|DateInterval $ttl Optional. The TTL value of this item. If no value is sent and
+	 * @param integer $ttl Optional. The TTL value of this item. If no value is sent and
 	 *                                       the driver supports TTL then the library may set a default value
 	 *                                       for it or let the driver take care of that.
 	 *

client/includes/WikibaseClient.php

Doc Comments +4 added lines, -1 removed lines

@@ -524,7 +524,7 @@ 
 	}
 
 	/**
-	 * @return TermBuffer|AliasTermBuffer
+	 * @return null|TermBuffer
 	 */
 	public function getTermBuffer() {
 		if ( !$this->termBuffer ) {
@@ -1526,6 +1526,9 @@ 
 		return $this->referenceFormatterFactory;
 	}
 
+	/**
+	 * @param string $cacheKey
+	 */
 	private function getCachedDatabasePropertyLabelResolver(
 		$languageCode,
 		$cache,

client/tests/phpunit/integration/includes/Changes/AffectedPagesFinderTest.php

Doc Comments +6 added lines

@@ -535,6 +535,9 @@ 
 		$this->assertSame( [], $usages );
 	}
 
+	/**
+	 * @return UsageLookup
+	 */
 	private function getSiteLinkUsageLookup() {
 		$pageEntityUsages = [ new PageEntityUsages( 1, [] ) ];
 		$mock = $this->createMock( UsageLookup::class );
@@ -639,6 +642,9 @@ 
 		return $strings;
 	}
 
+	/**
+	 * @param PageEntityUsages[] $actual
+	 */
 	private function assertPageEntityUsages( $expected, $actual, $message = '' ) {
 		$this->assertEquals(
 			$this->getPageEntityUsageStrings( $expected ),

client/tests/phpunit/integration/includes/DataAccess/Scribunto/Scribunto_LuaWikibaseLibraryTest.php

Doc Comments +3 added lines

@@ -206,6 +206,9 @@
 		$this->assertFalse( $cacheSplit );
 	}
 
+	/**
+	 * @return RepoLinker
+	 */
 	private function getRepoLinker() {
 		$repoLinker = $this->getMockBuilder( RepoLinker::class )
 			->disableOriginalConstructor()

client/tests/phpunit/integration/includes/DataAccess/WikibaseDataAccessTestItemSetUpHelper.php

Doc Comments +1 added lines, -1 removed lines

@@ -140,7 +140,7 @@
 	/**
 	 * @param ItemId $id
 	 * @param string[] $labels
-	 * @param Statement[]|null $statements
+	 * @param Statement[] $statements
 	 * @param SiteLink[]|null $siteLinks
 	 *
 	 * @return Item

client/tests/phpunit/unit/includes/DataAccess/ParserFunctions/StatementGroupRendererFactoryTest.php

Doc Comments +10 added lines

@@ -295,6 +295,13 @@ 
 		return $parser;
 	}
 
+	/**
+	 * @param string $languageCode
+	 * @param string $userLanguageCode
+	 * @param boolean $interfaceMessage
+	 * @param boolean $disableContentConversion
+	 * @param boolean $disableTitleConversion
+	 */
 	private function getParserOptions( $languageCode, $userLanguageCode, $interfaceMessage,
 		$disableContentConversion, $disableTitleConversion
 	) {
@@ -310,6 +317,9 @@ 
 		return $parserOptions;
 	}
 
+	/**
+	 * @return LanguageFallbackLabelDescriptionLookupFactory
+	 */
 	private function getLanguageFallbackLabelDescriptionLookupFactory() {
 		$languageFallbackLabelDescriptionLookup = $this->getMockBuilder( LanguageFallbackLabelDescriptionLookup::class )
 			->disableOriginalConstructor()

client/tests/phpunit/unit/includes/DataAccess/Scribunto/EntityAccessorTest.php

Doc Comments +3 added lines

@@ -82,6 +82,9 @@
 		);
 	}
 
+	/**
+	 * @param EntityUsage[] $actualUsages
+	 */
 	private function hasUsage( $actualUsages, EntityId $entityId, $aspect, $modifier = null ) {
 		$usage = new EntityUsage( $entityId, $aspect, $modifier );
 		$key = $usage->getIdentityString();

client/tests/phpunit/unit/includes/Hooks/SkinAfterBottomScriptsHandlerTest.php

Doc Comments +1 added lines, -1 removed lines

@@ -106,8 +106,8 @@
 
 	/**
 	 * @param string $baseURL
-	 * @param string $text
 	 * @param string|null $earliestRevTimestamp
+	 * @param string $titleText
 	 * @return Title
 	 */
 	private function mockTitle( $baseURL, $titleText, $earliestRevTimestamp = null ) {

Unused Use Statements -1 removed lines

@@ -4,7 +4,6 @@
 
 use File;
 use Title;
-
 use Wikibase\Client\Hooks\SkinAfterBottomScriptsHandler;
 use Wikibase\Client\RepoLinker;
 use Wikibase\Client\WikibaseClient;