Completed
Pull Request — master (#3)
by
unknown
07:49
created
repo/includes/Api/EntitySavingHelper.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -353,7 +353,7 @@
 block discarded – undo
353 353
 	/**
354 354
 	 * @param array $params
355 355
 	 *
356
-	 * @return string|bool|null Token string, or false if not needed, or null if not set.
356
+	 * @return string|boolean Token string, or false if not needed, or null if not set.
357 357
 	 */
358 358
 	private function evaluateTokenParam( array $params ) {
359 359
 		if ( !$this->apiModule->needsToken() ) {
Please login to merge, or discard this patch.
repo/includes/Api/ModifyEntity.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -336,6 +336,9 @@
 block discarded – undo
336 336
 		return $this->isWriteMode() ? array( 'read', 'edit' ) : array( 'read' );
337 337
 	}
338 338
 
339
+	/**
340
+	 * @param integer $oldRevId
341
+	 */
339 342
 	private function addToOutput( EntityDocument $entity, Status $status, $oldRevId = null ) {
340 343
 		$this->getResultBuilder()->addBasicEntityInformation( $entity->getId(), 'entity' );
341 344
 		$this->getResultBuilder()->addRevisionIdFromStatusToResult( $status, 'entity', $oldRevId );
Please login to merge, or discard this patch.
DataAccess/Scribunto/WikibaseLanguageIndependentLuaBindingsTest.php 1 patch
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -40,7 +40,7 @@  discard block
 block discarded – undo
40 40
 	 * @param SiteLinkLookup $siteLinkLookup
41 41
 	 * @param UsageAccumulator|null $usageAccumulator
42 42
 	 *
43
-	 * @return WikibaseLuaBindings
43
+	 * @return WikibaseLanguageIndependentLuaBindings
44 44
 	 */
45 45
 	private function getWikibaseLanguageIndependentLuaBindings(
46 46
 		SiteLinkLookup $siteLinkLookup,
@@ -54,6 +54,9 @@  discard block
 block discarded – undo
54 54
 		);
55 55
 	}
56 56
 
57
+	/**
58
+	 * @param EntityUsage[] $actualUsages
59
+	 */
57 60
 	private function hasUsage( $actualUsages, EntityId $entityId, $aspect ) {
58 61
 		$usage = new EntityUsage( $entityId, $aspect );
59 62
 		$key = $usage->getIdentityString();
Please login to merge, or discard this patch.
repo/tests/phpunit/includes/Api/EntityLoadingHelperTest.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -54,7 +54,7 @@
 block discarded – undo
54 54
 	 * @param EntityRevision|null $entityRevision The EntityRevision getEntityRevision() should return.
55 55
 	 * @param Exception|null $exception The Exception getEntityRevision() should throw.
56 56
 	 *
57
-	 * @return EntityRevisionLookup|PHPUnit_Framework_MockObject_MockObject
57
+	 * @return EntityRevisionLookup
58 58
 	 */
59 59
 	protected function getMockEntityRevisionLookup(
60 60
 		EntityId $entityId = null,
Please login to merge, or discard this patch.
client/includes/Hooks/InfoActionHookHandler.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -147,7 +147,7 @@
 block discarded – undo
147 147
 
148 148
 	/**
149 149
 	 * @param IContextSource $context
150
-	 * @param array $usage
150
+	 * @param \Wikibase\Client\Usage\EntityUsage[] $usage
151 151
 	 *
152 152
 	 * @return string[]
153 153
 	 */
Please login to merge, or discard this patch.
lib/includes/Store/Sql/PrefetchingWikiPageEntityMetaDataAccessor.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -191,6 +191,9 @@
 block discarded – undo
191 191
 		return $this->lookup->loadRevisionInformationByRevisionId( $entityId, $revisionId, $mode );
192 192
 	}
193 193
 
194
+	/**
195
+	 * @param string $mode
196
+	 */
194 197
 	private function doFetch( $mode ) {
195 198
 		if ( empty( $this->toFetch ) ) {
196 199
 			return;
Please login to merge, or discard this patch.
repo/tests/phpunit/includes/Hooks/InfoActionHookHandlerTest.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -94,7 +94,6 @@
 block discarded – undo
94 94
 
95 95
 	/**
96 96
 	 * @param bool $enabled
97
-	 * @param ItemId $entityId
98 97
 	 *
99 98
 	 * @return InfoActionHookHandler
100 99
 	 */
Please login to merge, or discard this patch.
repo/includes/Store/Sql/EntityPerPageTable.php 1 patch
Doc Comments   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -35,7 +35,6 @@  discard block
 block discarded – undo
35 35
 	/**
36 36
 	 * @param LoadBalancer $loadBalancer
37 37
 	 * @param EntityIdParser $entityIdParser
38
-	 * @param EntityIdComposer $entityIdComposer
39 38
 	 */
40 39
 	public function __construct(
41 40
 		LoadBalancer $loadBalancer,
@@ -185,7 +184,7 @@  discard block
 block discarded – undo
185 184
 	 * @param EntityId $entityId
186 185
 	 * @param int $pageId
187 186
 	 *
188
-	 * @return boolean Success indicator
187
+	 * @return boolean|null Success indicator
189 188
 	 */
190 189
 	public function deleteEntityPage( EntityId $entityId, $pageId ) {
191 190
 		$this->deleteEntity( $entityId );
Please login to merge, or discard this patch.
repo/maintenance/dumpEntities.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -206,7 +206,7 @@
 block discarded – undo
206 206
 	/**
207 207
 	 * Returns EntityIdPager::NO_REDIRECTS.
208 208
 	 *
209
-	 * @return mixed a EntityIdPager::XXX_REDIRECTS constant
209
+	 * @return string a EntityIdPager::XXX_REDIRECTS constant
210 210
 	 */
211 211
 	protected function getRedirectMode() {
212 212
 		return EntityIdPager::NO_REDIRECTS;
Please login to merge, or discard this patch.