Completed
Pull Request — master (#3)
by
unknown
07:49
created
repo/tests/phpunit/includes/EntityModificationTestHelper.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -144,7 +144,7 @@
 block discarded – undo
144 144
 	 * @param array $data
145 145
 	 * @param EntityId|string|null $id
146 146
 	 *
147
-	 * @return object
147
+	 * @return EntityDocument
148 148
 	 */
149 149
 	public function unserializeEntity( array $data, $id = null ) {
150 150
 		if ( $id !== null ) {
Please login to merge, or discard this patch.
repo/includes/Interactors/ItemMergeInteractor.php 1 patch
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -270,7 +270,7 @@  discard block
 block discarded – undo
270 270
 	 * @param string|null $summary
271 271
 	 * @param bool $bot
272 272
 	 *
273
-	 * @return array A list of exactly two EntityRevision objects. The first one represents the
273
+	 * @return \Wikibase\EntityRevision[] A list of exactly two EntityRevision objects. The first one represents the
274 274
 	 *  modified source item, the second one represents the modified target item.
275 275
 	 */
276 276
 	private function attemptSaveMerge( Item $fromItem, Item $toItem, $summary, $bot ) {
@@ -283,6 +283,9 @@  discard block
 block discarded – undo
283 283
 		return array( $fromRev, $toRev );
284 284
 	}
285 285
 
286
+	/**
287
+	 * @param boolean $bot
288
+	 */
286 289
 	private function saveEntity( Entity $entity, Summary $summary, $bot ) {
287 290
 		// Given we already check all constraints in ChangeOpsMerge, it's
288 291
 		// fine to ignore them here. This is also needed to not run into
Please login to merge, or discard this patch.
repo/tests/phpunit/includes/ChangeOp/ChangeOpsMergeTest.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -144,6 +144,9 @@
 block discarded – undo
144 144
 		);
145 145
 	}
146 146
 
147
+	/**
148
+	 * @param string $idString
149
+	 */
147 150
 	private function newItemWithId( $idString ) {
148 151
 		return new Item( new ItemId( $idString ) );
149 152
 	}
Please login to merge, or discard this patch.
repo/includes/ChangeDispatcher.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -451,6 +451,9 @@
 block discarded – undo
451 451
 		}
452 452
 	}
453 453
 
454
+	/**
455
+	 * @param string $message
456
+	 */
454 457
 	private function log( $message ) {
455 458
 		$this->messageReporter->reportMessage( $message );
456 459
 	}
Please login to merge, or discard this patch.
repo/includes/ParserOutput/EntityParserOutputDataUpdater.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -56,6 +56,9 @@
 block discarded – undo
56 56
 		$this->dataUpdaters = $dataUpdaters;
57 57
 	}
58 58
 
59
+	/**
60
+	 * @param ParserOutputDataUpdater $updater
61
+	 */
59 62
 	private function registerDataUpdater( $updater ) {
60 63
 		if ( !( $updater instanceof StatementDataUpdater ) &&
61 64
 		     !( $updater instanceof SiteLinkDataUpdater )
Please login to merge, or discard this patch.
client/tests/phpunit/includes/Changes/WikiPageUpdaterTest.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -68,7 +68,7 @@
 block discarded – undo
68 68
 	/**
69 69
 	 * @param string $text
70 70
 	 *
71
-	 * @return Title
71
+	 * @return EntityChange
72 72
 	 */
73 73
 	private function getTitleMock( $text ) {
74 74
 		$title = $this->getMockBuilder( 'Title' )
Please login to merge, or discard this patch.
repo/includes/GenericEventDispatcher.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -43,7 +43,7 @@  discard block
 block discarded – undo
43 43
 	 * @param object $listener
44 44
 	 *
45 45
 	 * @throws InvalidArgumentException
46
-	 * @return mixed The listener key, for removing the listener later.
46
+	 * @return integer The listener key, for removing the listener later.
47 47
 	 */
48 48
 	public function registerWatcher( $listener ) {
49 49
 		if ( !is_subclass_of( $listener, $this->interface ) ) {
@@ -59,7 +59,7 @@  discard block
 block discarded – undo
59 59
 	 * Unregisters a watcher using its registration key. The watcher will no longer
60 60
 	 * be called by dispatch().
61 61
 	 *
62
-	 * @param mixed $key A watcher key as returned by registerWatcher().
62
+	 * @param integer $key A watcher key as returned by registerWatcher().
63 63
 	 *
64 64
 	 * @throws InvalidArgumentException
65 65
 	 */
Please login to merge, or discard this patch.
client/includes/Specials/SpecialUnconnectedPages.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -162,8 +162,8 @@
 block discarded – undo
162 162
 	/**
163 163
 	 * @see QueryPage::reallyDoQuery
164 164
 	 *
165
-	 * @param int|bool $limit
166
-	 * @param int|bool $offset
165
+	 * @param integer $limit
166
+	 * @param integer $offset
167 167
 	 *
168 168
 	 * @return ResultWrapper
169 169
 	 */
Please login to merge, or discard this patch.
repo/includes/Api/EditEntity.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -632,7 +632,7 @@
 block discarded – undo
632 632
 
633 633
 	/**
634 634
 	 * @param mixed $data
635
-	 * @param array $allowedProps
635
+	 * @param string[] $allowedProps
636 636
 	 */
637 637
 	private function checkValidJson( $data, array $allowedProps ) {
638 638
 		if ( is_null( $data ) ) {
Please login to merge, or discard this patch.