Completed
Pull Request — master (#12)
by
unknown
11:14 queued 04:45
created
repo/tests/phpunit/includes/Api/RemoveQualifiersTest.php 1 patch
Doc Comments   +6 added lines patch added patch discarded remove patch
@@ -139,6 +139,9 @@  discard block
 block discarded – undo
139 139
 		] );
140 140
 	}
141 141
 
142
+	/**
143
+	 * @param string|null $statementGuid
144
+	 */
142 145
 	protected function makeValidRequest( $statementGuid, array $hashes ) {
143 146
 		$params = [
144 147
 			'action' => 'wbremovequalifiers',
@@ -154,6 +157,9 @@  discard block
 block discarded – undo
154 157
 		$this->makeInvalidRequest( $statementGuid, $hashes, 'no-such-qualifier' );
155 158
 	}
156 159
 
160
+	/**
161
+	 * @param string $expectedError
162
+	 */
157 163
 	protected function makeInvalidRequest( $statementGuid, array $hashes, $expectedError = null ) {
158 164
 		$params = [
159 165
 			'action' => 'wbremovequalifiers',
Please login to merge, or discard this patch.
repo/tests/phpunit/includes/Api/RemoveReferencesTest.php 1 patch
Doc Comments   +6 added lines patch added patch discarded remove patch
@@ -138,6 +138,9 @@  discard block
 block discarded – undo
138 138
 		] );
139 139
 	}
140 140
 
141
+	/**
142
+	 * @param string|null $statementGuid
143
+	 */
141 144
 	protected function makeValidRequest( $statementGuid, array $hashes ) {
142 145
 		$params = [
143 146
 			'action' => 'wbremovereferences',
@@ -153,6 +156,9 @@  discard block
 block discarded – undo
153 156
 		$this->makeInvalidRequest( $statementGuid, $hashes, 'no-such-reference' );
154 157
 	}
155 158
 
159
+	/**
160
+	 * @param string $expectedError
161
+	 */
156 162
 	protected function makeInvalidRequest( $statementGuid, array $hashes, $expectedError = null ) {
157 163
 		$params = [
158 164
 			'action' => 'wbremovereferences',
Please login to merge, or discard this patch.
repo/tests/phpunit/includes/Api/SetReferenceTest.php 1 patch
Doc Comments   +6 added lines patch added patch discarded remove patch
@@ -244,6 +244,12 @@
 block discarded – undo
244 244
 		) );
245 245
 	}
246 246
 
247
+	/**
248
+	 * @param string|null $referenceHash
249
+	 * @param string $snaksJson
250
+	 * @param string $snaksOrderJson
251
+	 * @param string $expectedErrorCode
252
+	 */
247 253
 	protected function makeInvalidRequest(
248 254
 		$statementGuid,
249 255
 		$referenceHash,
Please login to merge, or discard this patch.
repo/tests/phpunit/includes/ChangeOp/ChangeOpStatementRankTest.php 1 patch
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -77,6 +77,10 @@
 block discarded – undo
77 77
 		$this->assertTrue( $changeOpResult->isEntityChanged() );
78 78
 	}
79 79
 
80
+	/**
81
+	 * @param string $itemIdString
82
+	 * @param PropertyValueSnak $mainSnak
83
+	 */
80 84
 	private function newItemWithClaim( $itemIdString, $mainSnak ) {
81 85
 		$item = new Item( new ItemId( $itemIdString ) );
82 86
 
Please login to merge, or discard this patch.
repo/tests/phpunit/includes/Dumpers/JsonDumpGeneratorTest.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -81,7 +81,7 @@
 block discarded – undo
81 81
 	 * @param EntityId $id
82 82
 	 *
83 83
 	 * @throws InvalidArgumentException
84
-	 * @return Item|Property
84
+	 * @return \Wikibase\DataModel\Entity\EntityDocument
85 85
 	 */
86 86
 	protected function makeEntity( EntityId $id ) {
87 87
 		if ( $id instanceof ItemId ) {
Please login to merge, or discard this patch.
repo/tests/phpunit/includes/Dumpers/RdfDumpGeneratorTest.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -153,7 +153,6 @@
 block discarded – undo
153 153
 
154 154
 	/**
155 155
 	 * @param string $flavor
156
-	 * @param EntityDocument[] $entities
157 156
 	 * @param EntityId[] $redirects
158 157
 	 *
159 158
 	 * @return RdfDumpGenerator
Please login to merge, or discard this patch.
repo/tests/phpunit/includes/Hooks/OutputPageBeforeHTMLHookHandlerTest.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -222,7 +222,7 @@  discard block
 block discarded – undo
222 222
 	}
223 223
 
224 224
 	/**
225
-	 * @param $itemId
225
+	 * @param ItemId $itemId
226 226
 	 * @return \PHPUnit\Framework\MockObject\MockObject
227 227
 	 */
228 228
 	private function getOutputPageEntityIdReaderReturningEntity( $itemId ) {
@@ -235,8 +235,8 @@  discard block
 block discarded – undo
235 235
 	}
236 236
 
237 237
 	/**
238
-	 * @param $itemId
239
-	 * @return MockObject
238
+	 * @param ItemId $itemId
239
+	 * @return EntityRevisionLookup
240 240
 	 */
241 241
 	private function getEntityRevisionLookupReturningEntity( $itemId ): EntityRevisionLookup {
242 242
 		$entityRevisionLookup = $this->createMock( EntityRevisionLookup::class );
Please login to merge, or discard this patch.
repo/tests/phpunit/includes/MediawikiEditEntityTest.php 1 patch
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -38,6 +38,9 @@  discard block
 block discarded – undo
38 38
  */
39 39
 class MediawikiEditEntityTest extends MediaWikiTestCase {
40 40
 
41
+	/**
42
+	 * @param string $name
43
+	 */
41 44
 	private function getUser( $name ) {
42 45
 		$user = User::newFromName( $name );
43 46
 
@@ -120,7 +123,7 @@  discard block
 block discarded – undo
120 123
 	 * @param EntityId $entityId
121 124
 	 * @param EntityTitleStoreLookup $titleLookup
122 125
 	 * @param User|null $user
123
-	 * @param bool $baseRevId
126
+	 * @param integer $baseRevId
124 127
 	 * @param bool[]|null $permissions map of actions to bool, indicating which actions are allowed.
125 128
 	 * @param EditFilterHookRunner|null $editFilterHookRunner
126 129
 	 *
Please login to merge, or discard this patch.
PlaceholderExpander/ExternallyRenderedEntityViewPlaceholderExpanderTest.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -224,6 +224,7 @@
 block discarded – undo
224 224
 	}
225 225
 
226 226
 	/**
227
+	 * @param ItemId $id
227 228
 	 * @return MockObject|OutputPageEntityIdReader
228 229
 	 */
229 230
 	protected function newEntityIdReaderReturningEntityId( $id ) {
Please login to merge, or discard this patch.