wikimedia / mediawiki-extensions-Wikibase

lib/includes/Store/Sql/Terms/Util/ReplicaMasterAwareRecordIdsAcquirer.php

Doc Comments +3 added lines

@@ -164,6 +164,9 @@
 		return $existingRecords;
 	}
 
+	/**
+	 * @param callable $recordsToInsertDecoratorCallback
+	 */
 	private function insertNonExistingRecords(
 		array $records,
 		$recordsToInsertDecoratorCallback = null

lib/includes/Store/Sql/TermSqlIndex.php

Doc Comments +3 added lines

@@ -1135,6 +1135,9 @@
 		return $conflicts;
 	}
 
+	/**
+	 * @param string $entityType
+	 */
 	private function assertEntityTypeKnown( $entityType ) {
 		if ( !in_array( $entityType, $this->entitySource->getEntityTypes() ) ) {
 			// TODO: is it really necessary to throw MWException here?

lib/tests/phpunit/Formatters/GlobeCoordinateKartographerFormatterTest.php

Doc Comments +10 added lines

@@ -73,6 +73,11 @@ 
 		$formatter->format( new StringValue( 'A string is not a coordinate?!' ) );
 	}
 
+	/**
+	 * @param integer $totalCalls
+	 *
+	 * @return CachingKartographerEmbeddingHandler
+	 */
 	private function newCachingKartographerEmbeddingHandler(
 		$totalCalls,
 		$isPreview = false,
@@ -96,6 +101,11 @@ 
 		return $handler;
 	}
 
+	/**
+	 * @param integer $expectedFormatCalls
+	 *
+	 * @return ValueFormatter
+	 */
 	private function newBaseValueFormatter( $expectedFormatCalls ) {
 		$formatter = $this->createMock( ValueFormatter::class );
 

lib/tests/phpunit/Formatters/ItemPropertyIdHtmlLinkFormatterTest.php

Doc Comments +25 added lines

@@ -412,16 +412,25 @@ 
 		);
 	}
 
+	/**
+	 * @param string $itemId
+	 */
 	private function itemPageUrl( $itemId ) {
 		return "/index.php/{$itemId}";
 	}
 
+	/**
+	 * @param string $languageCode
+	 */
 	private function givenUserLanguageIs( $languageCode ) {
 		$this->setUserLang( $languageCode );
 		$this->currentUserLanguage = $languageCode;
 
 		return new class( $this ) extends ItemPropertyIdHtmlLinkFormatterTest {
 
+			/**
+			 * @param ItemPropertyIdHtmlLinkFormatterTest $testCase
+			 */
 			public function __construct( $testCase ) {
 				$this->testCase = $testCase;
 			}
@@ -430,6 +439,9 @@ 
 				$this->testCase->fallbackChain = $languageCodes;
 			}
 
+			/**
+			 * @param string $anotherLanguage
+			 */
 			public function canBeTransliteratedFrom( $anotherLanguage ) {
 				$this->testCase->transliterationMap[ $anotherLanguage ] = $this->testCase->currentUserLanguage;
 			}
@@ -437,6 +449,11 @@ 
 		};
 	}
 
+	/**
+	 * @param string $itemId
+	 * @param string $labelLanguage
+	 * @param string $labelText
+	 */
 	private function givenItemHasLabel( $itemId, $labelLanguage, $labelText ) {
 		$this->givenItemExists( 'Q1' );
 
@@ -542,12 +559,20 @@ 
 		};
 	}
 
+	/**
+	 * @param string $propertyId
+	 * @param string $labelLanguage
+	 * @param string $labelText
+	 */
 	private function givenPropertyHasLabel( $propertyId, $labelLanguage, $labelText ) {
 		$this->givenPropertyExists( 'P1' );
 
 		$this->givenEntityHasLabel( new PropertyId( $propertyId ), $labelLanguage, $labelText );
 	}
 
+	/**
+	 * @param string $propertyId
+	 */
 	private function propertyPageUrl( $propertyId ) {
 		return "/index.php/Property:{$propertyId}";
 	}

lib/tests/phpunit/MockRepository.php

Doc Comments +5 added lines, -5 removed lines

@@ -224,7 +224,7 @@ 
 	 *
 	 * @param EntityDocument $entity
 	 * @param int $revisionId
-	 * @param int|string $timestamp
+	 * @param integer $timestamp
 	 * @param User|string|null $user
 	 *
 	 * @throws StorageException
@@ -287,7 +287,7 @@ 
 	 *
 	 * @param EntityRedirect $redirect
 	 * @param int $revisionId
-	 * @param string|int $timestamp
+	 * @param integer $timestamp
 	 *
 	 * @throws StorageException
 	 */
@@ -641,7 +641,7 @@ 
 	/**
 	 * @param string $idString
 	 *
-	 * @return ItemId|PropertyId
+	 * @return EntityId
 	 */
 	private function parseId( $idString ) {
 		$parser = new BasicEntityIdParser();
@@ -650,7 +650,7 @@ 
 
 	/**
 	 * @param int $revisionId
-	 * @param EntityId|string $entityId
+	 * @param EntityId $entityId
 	 * @param string $summary
 	 * @param User|string $user
 	 * @param string[] $tags
@@ -689,7 +689,7 @@ 
 	 * Returns the newest (according to the revision id) log entry
 	 * for the given entity.
 	 *
-	 * @param EntityId|string $entityId
+	 * @param ItemId $entityId
 	 *
 	 * @return array|null An associative array containing the fields
 	 * 'revision', 'entity', 'summary', 'user', and 'tags'.

lib/tests/phpunit/Store/DelegatingEntityTermStoreWriterTest.php

Doc Comments +6 added lines

@@ -57,6 +57,9 @@ 
 		);
 	}
 
+	/**
+	 * @return EntityDocument
+	 */
 	private function newUnsupportedEntity() {
 		return $this->createMock( EntityDocument::class );
 	}
@@ -68,6 +71,9 @@ 
 		$writer->deleteTermsOfEntity( $this->newUnsupportedId() );
 	}
 
+	/**
+	 * @return EntityId
+	 */
 	public function newUnsupportedId() {
 		return $this->createMock( EntityId::class );
 	}

lib/tests/phpunit/Store/DispatchingEntityRevisionLookupTest.php

Doc Comments +1 added lines, -1 removed lines

@@ -23,7 +23,7 @@
 class DispatchingEntityRevisionLookupTest extends \PHPUnit\Framework\TestCase {
 
 	/**
-	 * @return MockObject|EntityRevisionLookup
+	 * @return \Wikibase\DataModel\Entity\EntityDocument
 	 */
 	private function getDummyEntityRevisionLookup() {
 		return $this->createMock( EntityRevisionLookup::class );

lib/tests/phpunit/Store/Sql/Terms/CachedDatabasePropertyLabelResolverTest.php

Doc Comments -1 removed lines

@@ -19,7 +19,6 @@
 
 	/**
 	 * @param string $lang
-	 * @param TermIndexEntry[] $terms
 	 *
 	 * @return PropertyLabelResolver
 	 */

lib/tests/phpunit/Store/Sql/TermSqlIndexTest.php

Doc Comments +9 added lines

@@ -827,6 +827,12 @@ 
 		return $entities;
 	}
 
+	/**
+	 * @param string $id
+	 * @param string $languageCode
+	 * @param string $label
+	 * @param string $description
+	 */
 	private function makeTermConflictItem( $id, $languageCode, $label, $description ) {
 		$item = new Item( new ItemId( $id ) );
 		$item->setLabel( $languageCode, $label );
@@ -1993,6 +1999,9 @@ 
 		$fooTermIndex->getLabelWithDescriptionConflicts( 'property', [ 'en' => 'some irrelevant label' ],  [ 'en' => 'random description' ] );
 	}
 
+	/**
+	 * @param string $entityType
+	 */
 	private function getTermSqlIndexForSourceOf( $entityType ) {
 		$irrelevantNamespaceId = 100;