Completed
Pull Request — master (#12)
by
unknown
11:14 queued 04:45
created
repo/tests/phpunit/includes/Actions/ActionTestCase.php 1 patch
Doc Comments   +5 added lines, -1 removed lines patch added patch discarded remove patch
@@ -106,7 +106,7 @@  discard block
 block discarded – undo
106 106
 	/**
107 107
 	 * Creates an action and supplies it with a fake web request.
108 108
 	 *
109
-	 * @param string|Action $action The action to call, may be an action name or class name.
109
+	 * @param string $action The action to call, may be an action name or class name.
110 110
 	 * @param WikiPage  $page the wiki page to call the action on
111 111
 	 * @param array|null $params request parameters
112 112
 	 * @param bool $wasPosted
@@ -259,6 +259,10 @@  discard block
 block discarded – undo
259 259
 		return $result;
260 260
 	}
261 261
 
262
+	/**
263
+	 * @param string $comment
264
+	 * @param integer $flags
265
+	 */
262 266
 	private function createTestItem( EntityDocument $entity, $comment, $user, $flags ) {
263 267
 		$store = WikibaseRepo::getDefaultInstance()->getEntityStore();
264 268
 		$rev = $store->saveEntity( $entity, $comment, $user, $flags );
Please login to merge, or discard this patch.
repo/includes/Dumpers/RdfDumpGenerator.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -180,6 +180,9 @@
 block discarded – undo
180 180
 		$this->timestamp = (int)$timestamp;
181 181
 	}
182 182
 
183
+	/**
184
+	 * @param string $name
185
+	 */
183 186
 	private static function getRdfWriter( $name, BNodeLabeler $labeler = null ) {
184 187
 		$factory = new RdfWriterFactory();
185 188
 		$format = $factory->getFormatName( $name );
Please login to merge, or discard this patch.
repo/maintenance/DumpEntities.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -224,7 +224,7 @@  discard block
 block discarded – undo
224 224
 	 * @param string[] $entityTypes
225 225
 	 * @param ExceptionHandler|null $exceptionReporter
226 226
 	 *
227
-	 * @return EntityIdReader|SqlEntityIdPager a stream of EntityId objects
227
+	 * @return EntityIdPager a stream of EntityId objects
228 228
 	 */
229 229
 	private function makeIdStream( array $entityTypes, ExceptionHandler $exceptionReporter = null ) {
230 230
 		$listFile = $this->getOption( 'list-file' );
@@ -241,7 +241,7 @@  discard block
 block discarded – undo
241 241
 	/**
242 242
 	 * Returns EntityIdPager::NO_REDIRECTS.
243 243
 	 *
244
-	 * @return mixed a EntityIdPager::XXX_REDIRECTS constant
244
+	 * @return string a EntityIdPager::XXX_REDIRECTS constant
245 245
 	 */
246 246
 	protected function getRedirectMode() {
247 247
 		return EntityIdPager::NO_REDIRECTS;
Please login to merge, or discard this patch.
client/tests/phpunit/includes/Api/DescriptionTest.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -45,8 +45,8 @@
 block discarded – undo
45 45
 	 * @param bool $allowLocalShortDesc
46 46
 	 * @param array $params
47 47
 	 * @param array $requestedPageIds
48
-	 * @param array $localDescriptions
49
-	 * @param array $centralDescriptions
48
+	 * @param array $descriptions
49
+	 * @param array $descriptions
50 50
 	 * @param int $fitLimit
51 51
 	 * @param array $expectedResult
52 52
 	 * @param int $expectedContinue
Please login to merge, or discard this patch.
client/tests/phpunit/includes/Hooks/ParserOutputUpdateHookHandlersTest.php 1 patch
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -455,6 +455,10 @@
 block discarded – undo
455 455
 		);
456 456
 	}
457 457
 
458
+	/**
459
+	 * @param NamespaceChecker $namespaceChecker
460
+	 * @param MockRepository $mockRepo
461
+	 */
458 462
 	private function newLangLinkHandler( $namespaceChecker, $mockRepo ) {
459 463
 		$settings = $this->newSettings();
460 464
 
Please login to merge, or discard this patch.
client/tests/phpunit/includes/Hooks/SkinAfterBottomScriptsHandlerTest.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -106,8 +106,8 @@
 block discarded – undo
106 106
 
107 107
 	/**
108 108
 	 * @param string $baseURL
109
-	 * @param string $text
110 109
 	 * @param string|null $earliestRevTimestamp
110
+	 * @param string $titleText
111 111
 	 * @return Title
112 112
 	 */
113 113
 	private function mockTitle( $baseURL, $titleText, $earliestRevTimestamp = null ) {
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -4,7 +4,6 @@
 block discarded – undo
4 4
 
5 5
 use File;
6 6
 use Title;
7
-
8 7
 use Wikibase\Client\Hooks\SkinAfterBottomScriptsHandler;
9 8
 use Wikibase\Client\RepoLinker;
10 9
 use Wikibase\Client\WikibaseClient;
Please login to merge, or discard this patch.
lib/tests/phpunit/EntityRevisionLookupTestCase.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -58,6 +58,9 @@
 block discarded – undo
58 58
 		return $redirects;
59 59
 	}
60 60
 
61
+	/**
62
+	 * @param integer $revision
63
+	 */
61 64
 	protected function resolveLogicalRevision( $revision ) {
62 65
 		return $revision;
63 66
 	}
Please login to merge, or discard this patch.
lib/tests/phpunit/SimpleCacheWithBagOStuffTest.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -147,7 +147,7 @@
 block discarded – undo
147 147
 
148 148
 	/**
149 149
 	 * @param $inner
150
-	 * @param $key
150
+	 * @param string $key
151 151
 	 */
152 152
 	protected function spoilTheSignature( $inner, $key ) {
153 153
 		$value = $inner->get( $key );
Please login to merge, or discard this patch.
lib/tests/phpunit/Store/CacheRetrievingEntityRevisionLookupTest.php 1 patch
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -33,7 +33,7 @@  discard block
 block discarded – undo
33 33
 	 * @param EntityRevision[] $entityRevisions
34 34
 	 * @param EntityRedirect[] $entityRedirects
35 35
 	 *
36
-	 * @return EntityLookup
36
+	 * @return CacheRetrievingEntityRevisionLookup
37 37
 	 */
38 38
 	protected function newEntityRevisionLookup( array $entityRevisions, array $entityRedirects ) {
39 39
 		$mock = new MockRepository();
@@ -160,6 +160,9 @@  discard block
 block discarded – undo
160 160
 			->map();
161 161
 	}
162 162
 
163
+	/**
164
+	 * @param string $message
165
+	 */
163 166
 	private function assertNonexistent( LatestRevisionIdResult $result, $message ) {
164 167
 		$shouldNotBeCalled = function () use ( $message ) {
165 168
 			$this->fail( $message );
Please login to merge, or discard this patch.