wikimedia / mediawiki-extensions-Wikibase

repo/includes/EditEntity/MediawikiEditEntityFactory.php

Doc Comments +1 added lines, -1 removed lines

@@ -89,7 +89,7 @@
 	/**
 	 * @param User $user the user performing the edit
 	 * @param EntityId|null $entityId the id of the entity to edit
-	 * @param bool|int|null $baseRevId the base revision ID for conflict checking.
+	 * @param integer $baseRevId the base revision ID for conflict checking.
 	 *        Use 0 to indicate that the current revision should be used as the base revision,
 	 *        effectively disabling conflict detections. true and false will be accepted for
 	 *        backwards compatibility, but both will be treated like 0. Note that the behavior

lib/includes/Store/DispatchingTermBuffer.php

Doc Comments +2 added lines, -2 removed lines

@@ -124,7 +124,7 @@ 
 	 * @param string $termType
 	 * @param string $languageCode
 	 *
-	 * @return string|false|null
+	 * @return string|null
 	 */
 	public function getPrefetchedTerm( EntityId $entityId, $termType, $languageCode ) {
 		$termBuffer = $this->getTermBufferForRepository( $entityId->getRepositoryName() );
@@ -152,7 +152,7 @@ 
 	/**
 	 * @param string $repository
 	 *
-	 * @return TermBuffer|AliasTermBuffer
+	 * @return TermBuffer|null
 	 */
 	private function getTermBufferForRepository( $repository ) {
 		return $this->termBuffers[$repository] ?? null;

data-access/tests/phpunit/FakePrefetchingTermLookup.php

Doc Comments +3 added lines, -3 removed lines

@@ -17,9 +17,9 @@
 	private $buffer;
 
 	/**
-	 * @param array $entityIds
-	 * @param array|null $termTypes if null, defaults to labels and descriptions only
-	 * @param array|null $languageCodes if null, defaults to de and en
+	 * @param \Wikibase\DataModel\Entity\ItemId[] $entityIds
+	 * @param string[] $termTypes if null, defaults to labels and descriptions only
+	 * @param string[] $languageCodes if null, defaults to de and en
 	 */
 	public function prefetchTerms( array $entityIds, array $termTypes, array $languageCodes ) {
 		if ( $termTypes === null ) {

lib/includes/Store/BufferingTermIndexTermLookup.php

Doc Comments +2 added lines, -2 removed lines

@@ -100,8 +100,8 @@
 	 * Loads a set of terms into the buffer.
 	 * The source from which to fetch would typically be supplied to the buffer's constructor.
 	 * @param EntityId[] $entityIds
-	 * @param string[]|null $termTypes
-	 * @param string[]|null $languageCodes
+	 * @param string[] $termTypes
+	 * @param string[] $languageCodes
 	 *
 	 * @throws StorageException
 	 */

lib/includes/Store/Elastic/ElasticTermLookup.php

Doc Comments +2 added lines, -2 removed lines

@@ -68,8 +68,8 @@
 	 * The source from which to fetch would typically be supplied to the buffer's constructor.
 	 *
 	 * @param EntityId[] $entityIds
-	 * @param string[]|null $termTypes The desired term types; null means all.
-	 * @param string[]|null $languageCodes The desired languages; null means all.
+	 * @param string[] $termTypes The desired term types; null means all.
+	 * @param string[] $languageCodes The desired languages; null means all.
 	 */
 	public function prefetchTerms( array $entityIds, array $termTypes, array $languageCodes ) {
 		if ( count( $entityIds ) > TermLookupSearcher::MAX_TITLES_PER_QUERY ) {

lib/includes/Store/Sql/Terms/TermStoresDelegatingPrefetchingItemTermLookup.php

Doc Comments +2 added lines, -2 removed lines

@@ -59,8 +59,8 @@
 	 * Loads a set of terms into the buffer.
 	 * The source from which to fetch would typically be supplied to the buffer's constructor.
 	 * @param EntityId[] $entityIds
-	 * @param string[]|null $termTypes The desired term types; null means all.
-	 * @param string[]|null $languageCodes The desired languages; null means all.
+	 * @param string[] $termTypes The desired term types; null means all.
+	 * @param string[] $languageCodes The desired languages; null means all.
 	 */
 	public function prefetchTerms( array $entityIds, array $termTypes, array $languageCodes ) {
 		Assert::parameterElementType( ItemId::class, $entityIds, '$entityIds' );

lib/includes/Store/CachingFallbackLabelDescriptionLookup.php

Doc Comments +5 added lines, -2 removed lines

@@ -84,7 +84,7 @@ 
 	 * @param EntityId $entityId
 	 *
 	 * @throws LabelDescriptionLookupException
-	 * @return TermFallback|null
+	 * @return null|\Wikibase\DataModel\Term\Term
 	 */
 	public function getDescription( EntityId $entityId ) {
 		$languageCodes = $this->languageFallbackChain->getFetchLanguageCodes();
@@ -99,7 +99,7 @@ 
 	 * @param EntityId $entityId
 	 *
 	 * @throws LabelDescriptionLookupException
-	 * @return TermFallback|null
+	 * @return null|\Wikibase\DataModel\Term\Term
 	 */
 	public function getLabel( EntityId $entityId ) {
 		$languageCodes = $this->languageFallbackChain->getFetchLanguageCodes();
@@ -109,6 +109,9 @@ 
 		return $label;
 	}
 
+	/**
+	 * @param string $languageCode
+	 */
 	private function getTerm( EntityId $entityId, $languageCode, $termName = self::LABEL ) {
 		$resolutionResult = $this->redirectResolvingRevisionLookup->lookupLatestRevisionResolvingRedirect( $entityId );
 		if ( $resolutionResult === null ) {

lib/tests/phpunit/Store/CachingFallbackLabelDescriptionLookupTest.php

Doc Comments +6 added lines

@@ -325,6 +325,9 @@ 
 		$this->assertEquals( $expectedLabel, $gotLabel );
 	}
 
+	/**
+	 * @return RedirectResolvingLatestRevisionLookup
+	 */
 	private function newRedirectResolvingLatestRevisionLookup( int $revision, EntityId $entityId ) {
 		$revLookup = $this->prophesize( RedirectResolvingLatestRevisionLookup::class );
 		$revLookup->lookupLatestRevisionResolvingRedirect( Argument::any() )
@@ -333,6 +336,9 @@ 
 		return $revLookup->reveal();
 	}
 
+	/**
+	 * @return LanguageFallbackChain
+	 */
 	private function newFallbackChain() {
 		$fallbackChain = $this->prophesize( LanguageFallbackChain::class );
 		$fallbackChain->getFetchLanguageCodes()->willReturn( [ 'en' ] );

repo/tests/phpunit/includes/Store/CachingPrefetchingTermLookupTest.php

Doc Comments +3 added lines

@@ -171,6 +171,9 @@
 		return $revisionAndRedirectResolver;
 	}
 
+	/**
+	 * @return string
+	 */
 	private function buildTestCacheKey(
 		string $itemId,
 		string $termType,