wikimedia / mediawiki-extensions-Wikibase

repo/tests/phpunit/includes/Store/Sql/WikiPageEntityMetaDataLookupTest.php

Doc Comments +9 added lines

@@ -87,6 +87,7 @@ 
 	}
 
 	/**
+	 * @param EntityNamespaceLookup $nsLookup
 	 * @return WikiPageEntityMetaDataLookup
 	 */
 	private function getWikiPageEntityMetaDataLookup( $nsLookup = null ) {
@@ -106,6 +107,9 @@ 
 		);
 	}
 
+	/**
+	 * @param EntityNamespaceLookup $namespaceLookup
+	 */
 	private function newMetaDataLookupForSourceBasedFederation( $namespaceLookup = null ) {
 		if ( $namespaceLookup === null ) {
 			$namespaceLookup = $this->getEntityNamespaceLookup();
@@ -182,6 +186,11 @@ 
 		return $lookup;
 	}
 
+	/**
+	 * @param integer $selectCount
+	 * @param integer $selectRowCount
+	 * @param integer $getConnectionCount
+	 */
 	private function newLookupWithLaggedConnectionForSourceBasedFederation( $selectCount, $selectRowCount, $getConnectionCount ) {
 		$nsLookup = $this->getEntityNamespaceLookup();
 		$lookup = $this->getMockBuilder( WikiPageEntityMetaDataLookup::class )

repo/tests/phpunit/includes/Store/WikiPageEntityRevisionLookupTest.php

Doc Comments +3 added lines

@@ -433,6 +433,9 @@
 			)->map();
 	}
 
+	/**
+	 * @param string $idString
+	 */
 	private function getMockEntityId( $idString ) {
 		$entityId = $this->createMock( EntityId::class );
 		$entityId->method( '__toString' )->willReturn( $idString );

repo/tests/phpunit/includes/ChangeOp/Deserialization/AliasChangeOpDeserializationTester.php

Doc Comments +1 added lines, -1 removed lines

@@ -86,7 +86,7 @@
 	}
 
 	/**
-	 * @return AliasesProvider|EntityDocument
+	 * @return EntityDocument
 	 */
 	abstract protected function getEntity();
 

repo/tests/phpunit/includes/ChangeOp/Deserialization/DescriptionsChangeOpDeserializationTester.php

Doc Comments +1 added lines, -1 removed lines

@@ -67,7 +67,7 @@
 	}
 
 	/**
-	 * @return DescriptionsProvider|EntityDocument
+	 * @return EntityDocument
 	 */
 	abstract protected function getEntity();
 

repo/tests/phpunit/includes/ChangeOp/Deserialization/LabelsChangeOpDeserializationTester.php

Doc Comments +1 added lines, -1 removed lines

@@ -65,7 +65,7 @@
 	}
 
 	/**
-	 * @return LabelsProvider|EntityDocument
+	 * @return EntityDocument
 	 */
 	abstract protected function getEntity();
 

lib/includes/SimpleCacheWithBagOStuff.php

Doc Comments +6 added lines, -6 removed lines

@@ -55,7 +55,7 @@ 
 	 * Fetches a value from the cache.
 	 *
 	 * @param string $key The unique key of this item in the cache.
-	 * @param mixed $default Default value to return if the key does not exist.
+	 * @param string $default Default value to return if the key does not exist.
 	 *
 	 * @return mixed The value of the item from the cache, or $default in case of cache miss.
 	 *
@@ -77,8 +77,8 @@ 
 	 * Persists data in the cache, uniquely referenced by a key with an optional expiration TTL time.
 	 *
 	 * @param string $key The key of the item to store.
-	 * @param mixed $value The value of the item to store, must be serializable.
-	 * @param null|int|\DateInterval $ttl Optional. The TTL value of this item. If no value is sent and
+	 * @param string $value The value of the item to store, must be serializable.
+	 * @param integer $ttl Optional. The TTL value of this item. If no value is sent and
 	 *                                      the driver supports TTL then the library may set a default value
 	 *                                      for it or let the driver take care of that.
 	 *
@@ -125,8 +125,8 @@ 
 	/**
 	 * Obtains multiple cache items by their unique keys.
 	 *
-	 * @param iterable $keys A list of keys that can obtained in a single operation.
-	 * @param mixed $default Default value to return for keys that do not exist.
+	 * @param string[] $keys A list of keys that can obtained in a single operation.
+	 * @param string $default Default value to return for keys that do not exist.
 	 *
 	 * @return iterable A list of key => value pairs. Cache keys that do not exist or are stale will have $default as value.
 	 *
@@ -166,7 +166,7 @@ 
 	 * Persists a set of key => value pairs in the cache, with an optional TTL.
 	 *
 	 * @param iterable $values A list of key => value pairs for a multiple-set operation.
-	 * @param null|int|\DateInterval $ttl Optional. The TTL value of this item. If no value is sent and
+	 * @param integer $ttl Optional. The TTL value of this item. If no value is sent and
 	 *                                       the driver supports TTL then the library may set a default value
 	 *                                       for it or let the driver take care of that.
 	 *

repo/includes/Hooks/HtmlPageLinkRendererBeginHookHandler.php

Doc Comments +1 added lines, -1 removed lines

@@ -335,7 +335,7 @@
 	 * @param Title|null $currentTitle
 	 * @param RequestContext $context
 	 *
-	 * @return bool
+	 * @return null|boolean
 	 */
 	private function shouldConvert( ?Title $currentTitle, RequestContext $context ) {
 		static $shouldConvert = null;

repo/tests/phpunit/includes/Store/WikiPageEntityDataLoaderTest.php

Doc Comments +4 added lines

@@ -190,6 +190,10 @@
 		$this->fail( 'Should throw specific exception' );
 	}
 
+	/**
+	 * @param integer $revisionId
+	 * @param string $slotRole
+	 */
 	private function newRevisionRecord( $revisionId, $slotRole ) {
 		$revision = $this->createMock( RevisionRecord::class );
 		$revision

lib/tests/phpunit/Store/Sql/SqlEntityInfoBuilderTest.php

Doc Comments +12 added lines, -1 removed lines

@@ -122,6 +122,9 @@ 
 			$redirectRows );
 	}
 
+	/**
+	 * @param string $termType
+	 */
 	private function getTermRows( EntityId $id, $termType, $terms ) {
 		$rows = [];
 
@@ -169,6 +172,9 @@ 
 		return $page;
 	}
 
+	/**
+	 * @param string $table
+	 */
 	private function insertRows( $table, array $fields, array $rows ) {
 		$dbw = wfGetDB( DB_MASTER );
 
@@ -219,7 +225,7 @@ 
 	}
 
 	/**
-	 * @return \PHPUnit\Framework\MockObject\MockObject|CacheInterface
+	 * @return CacheInterface
 	 */
 	private function getCache() {
 		$mock = $this->createMock( CacheInterface::class );
@@ -307,6 +313,11 @@ 
 		$this->assertFalse( $entityInfo->hasEntityInfo( $propertyId ) );
 	}
 
+	/**
+	 * @param string $termType
+	 * @param string $termLanguage
+	 * @param string $termText
+	 */
 	private function saveFakeForeignItemTermUsingFullItemId( ItemId $itemId, $termType, $termLanguage, $termText ) {
 		// Insert any existing data for the item ID (might collide because of insert done in setUp
 		$db = wfGetDB( DB_MASTER );