Completed
Pull Request — master (#5)
by
unknown
09:36
created
lib/includes/Interactors/TermIndexSearchInteractor.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -341,7 +341,7 @@  discard block
 block discarded – undo
341 341
 	/**
342 342
 	 * @param EntityId $entityId
343 343
 	 *
344
-	 * @return null|Term
344
+	 * @return \Wikibase\DataModel\Term\TermFallback|null
345 345
 	 */
346 346
 	private function getLabelDisplayTerm( EntityId $entityId ) {
347 347
 		return $this->labelDescriptionLookup->getLabel( $entityId );
@@ -350,7 +350,7 @@  discard block
 block discarded – undo
350 350
 	/**
351 351
 	 * @param EntityId $entityId
352 352
 	 *
353
-	 * @return null|Term
353
+	 * @return \Wikibase\DataModel\Term\TermFallback|null
354 354
 	 */
355 355
 	private function getDescriptionDisplayTerm( EntityId $entityId ) {
356 356
 		return $this->labelDescriptionLookup->getDescription( $entityId );
Please login to merge, or discard this patch.
lib/tests/phpunit/Store/DispatchingEntityRevisionLookupTest.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -22,7 +22,7 @@
 block discarded – undo
22 22
 class DispatchingEntityRevisionLookupTest extends \PHPUnit_Framework_TestCase {
23 23
 
24 24
 	/**
25
-	 * @return \PHPUnit_Framework_MockObject_MockObject|EntityRevisionLookup
25
+	 * @return \Wikibase\DataModel\Entity\EntityDocument
26 26
 	 */
27 27
 	private function getDummyEntityRevisionLookup() {
28 28
 		return $this->getMock( EntityRevisionLookup::class );
Please login to merge, or discard this patch.
lib/includes/Store/DispatchingTermBuffer.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -66,8 +66,8 @@  discard block
 block discarded – undo
66 66
 	 * @see TermBuffer::prefetchTerms
67 67
 	 *
68 68
 	 * @param array $entityIds
69
-	 * @param array|null $termTypes
70
-	 * @param array|null $languageCodes
69
+	 * @param string[] $termTypes
70
+	 * @param string[] $languageCodes
71 71
 	 */
72 72
 	public function prefetchTerms( array $entityIds, array $termTypes = null, array $languageCodes = null ) {
73 73
 		$groupedIds = $this->groupEntityIdsByRepo( $entityIds );
@@ -95,7 +95,7 @@  discard block
 block discarded – undo
95 95
 	 * @param string $termType
96 96
 	 * @param string $languageCode
97 97
 	 *
98
-	 * @return string|false|null
98
+	 * @return string|null
99 99
 	 */
100 100
 	public function getPrefetchedTerm( EntityId $entityId, $termType, $languageCode ) {
101 101
 		$termBuffer = $this->getTermBufferForRepository( $entityId->getRepositoryName() );
Please login to merge, or discard this patch.
repo/tests/phpunit/includes/Store/Sql/SqlEntityIdPagerTest.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -80,6 +80,9 @@
 block discarded – undo
80 80
 		);
81 81
 	}
82 82
 
83
+	/**
84
+	 * @param boolean $isRedirect
85
+	 */
83 86
 	private function getPageRow( EntityId $entityId, $isRedirect ) {
84 87
 		$entityNamespaceLookup = WikibaseRepo::getDefaultInstance()->getEntityNamespaceLookup();
85 88
 
Please login to merge, or discard this patch.
repo/tests/phpunit/includes/Actions/ActionTestCase.php 1 patch
Doc Comments   +5 added lines, -1 removed lines patch added patch discarded remove patch
@@ -131,7 +131,7 @@  discard block
 block discarded – undo
131 131
 	/**
132 132
 	 * Creates an action and supplies it with a fake web request.
133 133
 	 *
134
-	 * @param string|Action $action The action to call, may be an action name or class name.
134
+	 * @param string $action The action to call, may be an action name or class name.
135 135
 	 * @param WikiPage  $page the wiki page to call the action on
136 136
 	 * @param array|null $params request parameters
137 137
 	 * @param bool       $post posted?
@@ -307,6 +307,10 @@  discard block
 block discarded – undo
307 307
 		return $result;
308 308
 	}
309 309
 
310
+	/**
311
+	 * @param string $comment
312
+	 * @param integer $flags
313
+	 */
310 314
 	private function createTestItem( EntityDocument $entity, $comment, $user, $flags ) {
311 315
 		$store = WikibaseRepo::getDefaultInstance()->getEntityStore();
312 316
 		$rev = $store->saveEntity( $entity, $comment, $user, $flags );
Please login to merge, or discard this patch.
lib/includes/Store/BufferingTermLookup.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -106,8 +106,8 @@
 block discarded – undo
106 106
 	 * The source from which to fetch would typically be supplied to the buffer's constructor.
107 107
 	 *
108 108
 	 * @param EntityId[] $entityIds
109
-	 * @param string[]|null $termTypes
110
-	 * @param string[]|null $languageCodes
109
+	 * @param string[] $termTypes
110
+	 * @param string[] $languageCodes
111 111
 	 *
112 112
 	 * @throws StorageException
113 113
 	 */
Please login to merge, or discard this patch.
repo/tests/phpunit/includes/Content/ItemContentTest.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -47,7 +47,7 @@
 block discarded – undo
47 47
 	}
48 48
 
49 49
 	/**
50
-	 * @param ItemId|null $itemId
50
+	 * @param null|EntityId $itemId
51 51
 	 *
52 52
 	 * @throws InvalidArgumentException
53 53
 	 * @return ItemContent
Please login to merge, or discard this patch.
repo/tests/phpunit/includes/Content/PropertyContentTest.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -31,7 +31,7 @@
 block discarded – undo
31 31
 	}
32 32
 
33 33
 	/**
34
-	 * @param PropertyId|null $propertyId
34
+	 * @param null|EntityId $propertyId
35 35
 	 *
36 36
 	 * @throws InvalidArgumentException
37 37
 	 * @return PropertyContent
Please login to merge, or discard this patch.
repo/maintenance/dumpEntities.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -189,7 +189,7 @@  discard block
 block discarded – undo
189 189
 	 * @param null|string $entityType
190 190
 	 * @param ExceptionHandler|null $exceptionReporter
191 191
 	 *
192
-	 * @return EntityIdReader|SqlEntityIdPager a stream of EntityId objects
192
+	 * @return EntityIdPager a stream of EntityId objects
193 193
 	 */
194 194
 	private function makeIdStream( $entityType = null, ExceptionHandler $exceptionReporter = null ) {
195 195
 		$listFile = $this->getOption( 'list-file' );
@@ -206,7 +206,7 @@  discard block
 block discarded – undo
206 206
 	/**
207 207
 	 * Returns EntityIdPager::NO_REDIRECTS.
208 208
 	 *
209
-	 * @return mixed a EntityIdPager::XXX_REDIRECTS constant
209
+	 * @return string a EntityIdPager::XXX_REDIRECTS constant
210 210
 	 */
211 211
 	protected function getRedirectMode() {
212 212
 		return EntityIdPager::NO_REDIRECTS;
Please login to merge, or discard this patch.