Completed
Pull Request — master (#5)
by
unknown
09:36
created
lib/tests/phpunit/Store/CachingEntityRevisionLookupTest.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -28,7 +28,7 @@
 block discarded – undo
28 28
 	 * @param EntityRevision[] $entityRevisions
29 29
 	 * @param EntityRedirect[] $entityRedirects
30 30
 	 *
31
-	 * @return EntityLookup
31
+	 * @return CachingEntityRevisionLookup
32 32
 	 */
33 33
 	protected function newEntityRevisionLookup( array $entityRevisions, array $entityRedirects ) {
34 34
 		$mock = new MockRepository();
Please login to merge, or discard this patch.
repo/tests/phpunit/includes/ChangeOp/ChangeOpTestMockProvider.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -84,7 +84,7 @@
 block discarded – undo
84 84
 	/**
85 85
 	 * Convenience method for creating Statements.
86 86
 	 *
87
-	 * @param string|PropertyId $propertyId
87
+	 * @param string $propertyId
88 88
 	 *
89 89
 	 * @param string|int|float|DataValue|null $value The value of the new
90 90
 	 *        claim's main snak. Null will result in a PropertyNoValueSnak.
Please login to merge, or discard this patch.
repo/tests/phpunit/includes/Store/Sql/WikiPageEntityStoreTest.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -543,6 +543,9 @@
 block discarded – undo
543 543
 		$this->assertEntityPerPage( false, $entityId );
544 544
 	}
545 545
 
546
+	/**
547
+	 * @param boolean $expected
548
+	 */
546 549
 	private function assertEntityPerPage( $expected, EntityId $entityId ) {
547 550
 		$pageId = $this->getPageId( $entityId );
548 551
 
Please login to merge, or discard this patch.
client/includes/Hooks/EchoNotificationsHandlers.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -235,7 +235,7 @@
 block discarded – undo
235 235
 	 *
236 236
 	 * @param DiffOp $siteLinkDiffOp
237 237
 	 *
238
-	 * @return Title|false
238
+	 * @return \Wikibase\DataModel\Entity\EntityId
239 239
 	 */
240 240
 	private function getTitleForNotification( DiffOp $siteLinkDiffOp ) {
241 241
 		if ( $siteLinkDiffOp instanceof DiffOpAdd ) {
Please login to merge, or discard this patch.
lib/tests/phpunit/Store/TermIndexTest.php 1 patch
Doc Comments   +6 added lines patch added patch discarded remove patch
@@ -519,6 +519,12 @@
 block discarded – undo
519 519
 		return $entities;
520 520
 	}
521 521
 
522
+	/**
523
+	 * @param string $id
524
+	 * @param string $languageCode
525
+	 * @param string $label
526
+	 * @param string $description
527
+	 */
522 528
 	private function makeTermConflictItem( $id, $languageCode, $label, $description ) {
523 529
 		$item = new Item( new ItemId( $id ) );
524 530
 		$item->setLabel( $languageCode, $label );
Please login to merge, or discard this patch.
repo/includes/Api/EntitySavingHelper.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -353,7 +353,7 @@
 block discarded – undo
353 353
 	/**
354 354
 	 * @param array $params
355 355
 	 *
356
-	 * @return string|bool|null Token string, or false if not needed, or null if not set.
356
+	 * @return string|boolean Token string, or false if not needed, or null if not set.
357 357
 	 */
358 358
 	private function evaluateTokenParam( array $params ) {
359 359
 		if ( !$this->apiModule->needsToken() ) {
Please login to merge, or discard this patch.
repo/includes/Api/ModifyEntity.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -336,6 +336,9 @@
 block discarded – undo
336 336
 		return $this->isWriteMode() ? array( 'read', 'edit' ) : array( 'read' );
337 337
 	}
338 338
 
339
+	/**
340
+	 * @param integer $oldRevId
341
+	 */
339 342
 	private function addToOutput( EntityDocument $entity, Status $status, $oldRevId = null ) {
340 343
 		$this->getResultBuilder()->addBasicEntityInformation( $entity->getId(), 'entity' );
341 344
 		$this->getResultBuilder()->addRevisionIdFromStatusToResult( $status, 'entity', $oldRevId );
Please login to merge, or discard this patch.
repo/tests/phpunit/includes/Api/EntityLoadingHelperTest.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -54,7 +54,7 @@
 block discarded – undo
54 54
 	 * @param EntityRevision|null $entityRevision The EntityRevision getEntityRevision() should return.
55 55
 	 * @param Exception|null $exception The Exception getEntityRevision() should throw.
56 56
 	 *
57
-	 * @return EntityRevisionLookup|PHPUnit_Framework_MockObject_MockObject
57
+	 * @return EntityRevisionLookup
58 58
 	 */
59 59
 	protected function getMockEntityRevisionLookup(
60 60
 		EntityId $entityId = null,
Please login to merge, or discard this patch.
client/includes/Hooks/InfoActionHookHandler.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -147,7 +147,7 @@
 block discarded – undo
147 147
 
148 148
 	/**
149 149
 	 * @param IContextSource $context
150
-	 * @param array $usage
150
+	 * @param \Wikibase\Client\Usage\EntityUsage[] $usage
151 151
 	 *
152 152
 	 * @return string[]
153 153
 	 */
Please login to merge, or discard this patch.