Completed
Pull Request — master (#5)
by
unknown
09:36
created
repo/tests/phpunit/includes/Api/ApiJsonFormatTest.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -18,6 +18,9 @@
 block discarded – undo
18 18
  */
19 19
 class ApiJsonFormatTest extends ApiFormatTestCase {
20 20
 
21
+	/**
22
+	 * @param string $moduleIdentifier
23
+	 */
21 24
 	private function getExpectedJson( $moduleIdentifier ) {
22 25
 		$json = file_get_contents( __DIR__ . '/../../data/api/' . $moduleIdentifier . '.json' );
23 26
 		$json = json_decode( $json, true );
Please login to merge, or discard this patch.
repo/tests/phpunit/includes/Api/ModifyTermTestCase.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -58,6 +58,9 @@
 block discarded – undo
58 58
 		);
59 59
 	}
60 60
 
61
+	/**
62
+	 * @param string $attribute
63
+	 */
61 64
 	public function doTestSetTerm( $attribute, $params, $expected ) {
62 65
 		// -- set any defaults ------------------------------------
63 66
 		$params['action'] = self::$testAction;
Please login to merge, or discard this patch.
repo/tests/phpunit/includes/Api/RemoveReferencesTest.php 1 patch
Doc Comments   +6 added lines patch added patch discarded remove patch
@@ -110,6 +110,9 @@  discard block
 block discarded – undo
110 110
 		}
111 111
 	}
112 112
 
113
+	/**
114
+	 * @param string|null $statementGuid
115
+	 */
113 116
 	protected function makeValidRequest( $statementGuid, array $hashes ) {
114 117
 		$params = array(
115 118
 			'action' => 'wbremovereferences',
@@ -125,6 +128,9 @@  discard block
 block discarded – undo
125 128
 		$this->makeInvalidRequest( $statementGuid, $hashes, 'no-such-reference' );
126 129
 	}
127 130
 
131
+	/**
132
+	 * @param string $expectedError
133
+	 */
128 134
 	protected function makeInvalidRequest( $statementGuid, array $hashes, $expectedError = null ) {
129 135
 		$params = array(
130 136
 			'action' => 'wbremovereferences',
Please login to merge, or discard this patch.
repo/tests/phpunit/includes/Api/SetQualifierTest.php 1 patch
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -161,6 +161,10 @@
 block discarded – undo
161 161
 		$this->makeSetQualifierRequest( $guid, $hash, $newQualifier, $item->getId() );
162 162
 	}
163 163
 
164
+	/**
165
+	 * @param string|null $statementGuid
166
+	 * @param null|string $snakhash
167
+	 */
164 168
 	protected function makeSetQualifierRequest( $statementGuid, $snakhash, Snak $qualifier, EntityId $entityId ) {
165 169
 		$params = array(
166 170
 			'action' => 'wbsetqualifier',
Please login to merge, or discard this patch.
repo/tests/phpunit/includes/Api/SetReferenceTest.php 1 patch
Doc Comments   +6 added lines patch added patch discarded remove patch
@@ -230,6 +230,12 @@
 block discarded – undo
230 230
 		return $serializedReference;
231 231
 	}
232 232
 
233
+	/**
234
+	 * @param string|null $referenceHash
235
+	 * @param string $snaksJson
236
+	 * @param string $snaksOrderJson
237
+	 * @param string $expectedErrorCode
238
+	 */
233 239
 	protected function makeInvalidRequest(
234 240
 		$statementGuid,
235 241
 		$referenceHash,
Please login to merge, or discard this patch.
repo/includes/Hooks/LinkBeginHookHandler.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -203,7 +203,7 @@  discard block
 block discarded – undo
203 203
 	}
204 204
 
205 205
 	/**
206
-	 * @param array $termsByLanguage
206
+	 * @param string[] $termsByLanguage
207 207
 	 *
208 208
 	 * @return string[]|null
209 209
 	 */
@@ -224,7 +224,7 @@  discard block
 block discarded – undo
224 224
 	 *
225 225
 	 * @param Title|null $currentTitle
226 226
 	 * @param RequestContext $context
227
-	 * @return bool
227
+	 * @return null|boolean
228 228
 	 */
229 229
 	private function shouldConvert( Title $currentTitle = null, RequestContext $context ) {
230 230
 		static $shouldConvert = null;
Please login to merge, or discard this patch.
DataAccess/PropertyParserFunction/StatementGroupRendererFactoryTest.php 1 patch
Doc Comments   +7 added lines patch added patch discarded remove patch
@@ -302,6 +302,13 @@
 block discarded – undo
302 302
 		return $parser;
303 303
 	}
304 304
 
305
+	/**
306
+	 * @param string $languageCode
307
+	 * @param string $userLanguageCode
308
+	 * @param boolean $interfaceMessage
309
+	 * @param boolean $disableContentConversion
310
+	 * @param boolean $disableTitleConversion
311
+	 */
305 312
 	private function getParserOptions( $languageCode, $userLanguageCode, $interfaceMessage,
306 313
 		$disableContentConversion, $disableTitleConversion
307 314
 	) {
Please login to merge, or discard this patch.
repo/includes/Hooks/OutputPageBeforeHTMLHookHandler.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -116,7 +116,7 @@  discard block
 block discarded – undo
116 116
 	 * @param OutputPage $out
117 117
 	 * @param string &$html the HTML to mangle
118 118
 	 *
119
-	 * @return bool
119
+	 * @return boolean|null
120 120
 	 */
121 121
 	public static function onOutputPageBeforeHTML( OutputPage $out, &$html ) {
122 122
 		$self = self::newFromGlobalState();
@@ -128,7 +128,7 @@  discard block
 block discarded – undo
128 128
 	 * @param OutputPage $out
129 129
 	 * @param string &$html
130 130
 	 *
131
-	 * @return bool
131
+	 * @return boolean|null
132 132
 	 */
133 133
 	public function doOutputPageBeforeHTML( OutputPage $out, &$html ) {
134 134
 		$placeholders = $out->getProperty( 'wikibase-view-chunks' );
Please login to merge, or discard this patch.
lib/includes/Store/ChunkCache.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -211,7 +211,7 @@
 block discarded – undo
211 211
 	 * @param int $before insert into the internal entry list before this position.
212 212
 	 *
213 213
 	 * @throws MWException
214
-	 * @return array|bool the cache entry created by inserting the new chunk, or false if
214
+	 * @return integer|null the cache entry created by inserting the new chunk, or false if
215 215
 	 *         there is no more data to load from the source at the given position.
216 216
 	 *         The cache entry is an associative array containing the following keys:
217 217
 	 *         - start: the key the chunk starts at
Please login to merge, or discard this patch.