Completed
Pull Request — master (#5)
by
unknown
09:36
created
client/tests/phpunit/includes/DataAccess/Scribunto/EntityAccessorTest.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -75,6 +75,9 @@
 block discarded – undo
75 75
 		);
76 76
 	}
77 77
 
78
+	/**
79
+	 * @param EntityUsage[] $actualUsages
80
+	 */
78 81
 	private function hasUsage( $actualUsages, EntityId $entityId, $aspect ) {
79 82
 		$usage = new EntityUsage( $entityId, $aspect );
80 83
 		$key = $usage->getIdentityString();
Please login to merge, or discard this patch.
tests/phpunit/includes/DataAccess/WikibaseDataAccessTestItemSetUpHelper.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -140,7 +140,7 @@
 block discarded – undo
140 140
 	/**
141 141
 	 * @param ItemId $id
142 142
 	 * @param string[] $labels
143
-	 * @param Statement[]|null $statements
143
+	 * @param Statement[] $statements
144 144
 	 * @param SiteLink[]|null $siteLinks
145 145
 	 *
146 146
 	 * @return Item
Please login to merge, or discard this patch.
client/WikibaseClient.hooks.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -187,7 +187,7 @@  discard block
 block discarded – undo
187 187
 	 * @param bool $local shall links be generated locally or globally
188 188
 	 * @param string|null $wikiId The ID of the wiki the comment applies to, if not the local wiki.
189 189
 	 *
190
-	 * @return bool
190
+	 * @return boolean|null
191 191
 	 */
192 192
 	public static function onFormat( &$comment, $pre, $auto, $post, $title, $local, $wikiId = null ) {
193 193
 		global $wgContLang;
@@ -576,7 +576,7 @@  discard block
 block discarded – undo
576 576
 	 * @param string $name
577 577
 	 * @param string &$html
578 578
 	 *
579
-	 * @return boolean
579
+	 * @return boolean|null
580 580
 	 */
581 581
 	public static function onBaseTemplateAfterPortlet( BaseTemplate $skinTemplate, $name, &$html ) {
582 582
 		$handler = new BaseTemplateAfterPortletHandler();
Please login to merge, or discard this patch.
repo/includes/ChangeOp/ChangeOpsMerge.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -279,7 +279,7 @@
 block discarded – undo
279 279
 	 *
280 280
 	 * @param Statement $fromStatement
281 281
 	 *
282
-	 * @return Statement|false Statement to merge reference into or false
282
+	 * @return Statement Statement to merge reference into or false
283 283
 	 */
284 284
 	private function findEquivalentStatement( $fromStatement ) {
285 285
 		$fromHash = $this->getStatementHash( $fromStatement );
Please login to merge, or discard this patch.
repo/includes/Dumpers/JsonDumpGenerator.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -162,7 +162,7 @@
 block discarded – undo
162 162
 	 *
163 163
 	 * @TODO FIXME duplicated / similar code in Repo ResultBuilder
164 164
 	 *
165
-	 * @return array
165
+	 * @return string
166 166
 	 */
167 167
 	private function injectEntitySerializationWithDataTypes( array $serialization ) {
168 168
 		$serialization = $this->modifier->modifyUsingCallback(
Please login to merge, or discard this patch.
repo/includes/Parsers/MwTimeIsoParser.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -178,7 +178,7 @@
 block discarded – undo
178 178
 	/**
179 179
 	 * @param string $msgKey
180 180
 	 *
181
-	 * @return boolean
181
+	 * @return string
182 182
 	 */
183 183
 	private function isBceMsg( $msgKey ) {
184 184
 		return strstr( $msgKey, '-BCE-' );
Please login to merge, or discard this patch.
repo/includes/UpdateRepo/UpdateRepoJob.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -103,7 +103,7 @@
 block discarded – undo
103 103
 	abstract protected function applyChanges( Item $item );
104 104
 
105 105
 	/**
106
-	 * @return Item|null
106
+	 * @return null|\Wikibase\DataModel\Entity\EntityDocument
107 107
 	 */
108 108
 	private function getItem() {
109 109
 		$params = $this->getParams();
Please login to merge, or discard this patch.
repo/includes/UpdateRepo/UpdateRepoOnMoveJob.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -170,7 +170,7 @@
 block discarded – undo
170 170
 	 *
171 171
 	 * @param Item $item
172 172
 	 *
173
-	 * @return bool
173
+	 * @return boolean|null
174 174
 	 */
175 175
 	protected function applyChanges( Item $item ) {
176 176
 		$params = $this->getParams();
Please login to merge, or discard this patch.
repo/tests/phpunit/includes/ChangeOp/ChangeOpMainSnakTest.php 1 patch
Doc Comments   +6 added lines patch added patch discarded remove patch
@@ -176,6 +176,9 @@  discard block
 block discarded – undo
176 176
 		$changeOp->apply( $item );
177 177
 	}
178 178
 
179
+	/**
180
+	 * @param string $itemIdString
181
+	 */
179 182
 	private function makeNewItemWithClaim( $itemIdString, $snak ) {
180 183
 		$item = new Item( new ItemId( $itemIdString ) );
181 184
 
@@ -189,6 +192,9 @@  discard block
 block discarded – undo
189 192
 		return $item;
190 193
 	}
191 194
 
195
+	/**
196
+	 * @param string $propertyId
197
+	 */
192 198
 	private function makeSnak( $propertyId, $value ) {
193 199
 		if ( is_string( $propertyId ) ) {
194 200
 			$propertyId = new PropertyId( $propertyId );
Please login to merge, or discard this patch.