ChangeOpsResult::__construct() - Code Metrics - wikimedia/mediawiki-extensions-Wikibase - Measure and Improve Code Quality continuously with Scrutinizer

ChangeOpsResult::__construct() A
last analyzed 2020-11-13 17:34 UTC

↳ Parent: ChangeOpsResult

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	4
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	2

<?php

namespace Wikibase\Repo\ChangeOp;

use ValueValidators\Result;
use Wikibase\DataModel\Entity\EntityId;

/**
 * Class for collection of ChangeOp results
 */
class ChangeOpsResult implements ChangeOpResult {

	private $changeOpResults;
	private $entityId;

	/**
	 * @param EntityId|null $entityId
	 * @param ChangeOpResult[] $changeOpResults
	 */
	public function __construct( EntityId $entityId = null, array $changeOpResults = [] ) {
		$this->entityId = $entityId;
		$this->changeOpResults = $changeOpResults;
	}

	public function getChangeOpsResults() {
		return $this->changeOpResults;
	}

	public function getEntityId() {
		return $this->entityId;
	}

	public function isEntityChanged() {
		foreach ( $this->changeOpResults as $result ) {
			if ( $result->isEntityChanged() ) {
				return true;
			}
		}

		return false;
	}

	public function validate(): Result {
		$finalResult = Result::newSuccess();

		foreach ( $this->changeOpResults as $result ) {
			$finalResult = Result::merge( $finalResult, $result->validate() );
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
		}

		return $finalResult;
	}

}


1			<?php
2
3			namespace Wikibase\Repo\ChangeOp;
4
5			use ValueValidators\Result;
6			use Wikibase\DataModel\Entity\EntityId;
7
8			/**
9			* Class for collection of ChangeOp results
10			*/
11			class ChangeOpsResult implements ChangeOpResult {
12
13			private $changeOpResults;
14			private $entityId;
15
16			/**
17			* @param EntityId\|null $entityId
18			* @param ChangeOpResult[] $changeOpResults
19			*/
20			public function __construct( EntityId $entityId = null, array $changeOpResults = [] ) {
21			$this->entityId = $entityId;
22			$this->changeOpResults = $changeOpResults;
23			}
24
25			public function getChangeOpsResults() {
26			return $this->changeOpResults;
27			}
28
29			public function getEntityId() {
30			return $this->entityId;
31			}
32
33			public function isEntityChanged() {
34			foreach ( $this->changeOpResults as $result ) {
35			if ( $result->isEntityChanged() ) {
36			return true;
37			}
38			}
39
40			return false;
41			}
42
43			public function validate(): Result {
44			$finalResult = Result::newSuccess();
45
46			foreach ( $this->changeOpResults as $result ) {
47			$finalResult = Result::merge( $finalResult, $result->validate() );
			0 ignored issues – show Documentation introduced 2019-12-16 11:38 UTC by Report Bug Copy Issue Report `$finalResult` is of type `object<ValueValidators\Result>`, but the function expects a `object<self>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history... Documentation introduced 2019-12-16 11:38 UTC by Report Bug Copy Issue Report `$result->validate()` is of type `object<ValueValidators\Result>`, but the function expects a `object<self>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
48			}
49
50			return $finalResult;
51			}
52
53			}
54

wikimedia / mediawiki-extensions-Wikibase

ChangeOpsResult::__construct() A last analyzed 2020-11-13 17:34 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

ChangeOpsResult::__construct() A
last analyzed 2020-11-13 17:34 UTC