wikimedia / mediawiki-extensions-Lingo

src/Tree.php

Spacing +4 added lines, -4 removed lines

@@ -52,8 +52,8 @@ 
 
 	const TREE_VERSION = 2;
 
-	private $mTree = [];
-	private $mList = [];
+	private $mTree = [ ];
+	private $mList = [ ];
 	private $mMinLength = 1000;
 
 	/**
@@ -71,7 +71,7 @@ 
 			$this->mList[ $term ]->addDefinition( $definition );
 		} else {
 
-			$matches = [];
+			$matches = [ ];
 			preg_match_all( LingoParser::getInstance()->regex, $term, $matches );
 
 			$element = $this->addElement( $matches[ 0 ], $term, $definition );
@@ -97,7 +97,7 @@ 
 		while ( ( $step = array_shift( $path ) ) !== null ) {
 
 			if ( !isset( $tree[ $step ] ) ) {
-				$tree[ $step ] = [];
+				$tree[ $step ] = [ ];
 			}
 
 			$tree = &$tree[ $step ];

src/MessageLog.php

Spacing +5 added lines, -5 removed lines

@@ -41,7 +41,7 @@ 
  */
 class MessageLog {
 
-	private $mMessages = [];
+	private $mMessages = [ ];
 	private $mParser = null;
 
 	const MESSAGE_ERROR = 1;
@@ -53,7 +53,7 @@ 
 	 * @param int $severity
 	 */
 	public function addMessage( $message, $severity = self::MESSAGE_NOTICE ) {
-		$this->mMessages[] = [ $message, $severity ];
+		$this->mMessages[ ] = [ $message, $severity ];
 
 		// log errors and warnings in debug log
 		if ( $severity == self::MESSAGE_WARNING ||
@@ -67,7 +67,7 @@ 
 	 * @param $message
 	 */
 	public function addError( $message ) {
-		$this->mMessages[] = [ $message, self::MESSAGE_ERROR ];
+		$this->mMessages[ ] = [ $message, self::MESSAGE_ERROR ];
 		wfDebug( "Error: $message\n" );
 	}
 
@@ -75,7 +75,7 @@ 
 	 * @param $message
 	 */
 	public function addWarning( $message ) {
-		$this->mMessages[] = [ $message, self::MESSAGE_WARNING ];
+		$this->mMessages[ ] = [ $message, self::MESSAGE_WARNING ];
 		wfDebug( "Warning: $message\n" );
 	}
 
@@ -83,7 +83,7 @@ 
 	 * @param $message
 	 */
 	public function addNotice( $message ) {
-		$this->mMessages[] = [ $message, self::MESSAGE_NOTICE ];
+		$this->mMessages[ ] = [ $message, self::MESSAGE_NOTICE ];
 	}
 
 	/**

src/Lingo.i18n.magic.php

Spacing +1 added lines, -1 removed lines

@@ -6,7 +6,7 @@
  * @ingroup Extensions
  */
 
-$magicWords = [];
+$magicWords = [ ];
 
 /** English (English) */
 $magicWords[ 'en' ] = [

src/LingoParser.php

Spacing +4 added lines, -4 removed lines

@@ -155,7 +155,7 @@ 
 				} else {
 
 					wfDebug( "Cache miss: Lingo tree not found in cache.\n" );
-					$this->mLingoTree =& $this->buildLingo();
+					$this->mLingoTree = & $this->buildLingo();
 					wfDebug( "Cached lingo tree.\n" );
 				}
 
@@ -166,7 +166,7 @@ 
 
 			} else {
 				wfDebug( "Caching of lingo tree disabled.\n" );
-				$this->mLingoTree =& $this->buildLingo();
+				$this->mLingoTree = & $this->buildLingo();
 			}
 
 		}
@@ -231,7 +231,7 @@ 
 		// Iterate all HTML text matches
 		$numberOfTextElements = $textElements->length;
 
-		$definitions = [];
+		$definitions = [ ];
 
 		for ( $textElementIndex = 0; $textElementIndex < $numberOfTextElements; $textElementIndex++ ) {
 			$textElement = $textElements->item( $textElementIndex );
@@ -240,7 +240,7 @@ 
 				continue;
 			}
 
-			$matches = [];
+			$matches = [ ];
 			preg_match_all(
 				$this->regex,
 				$textElement->nodeValue,

tests/phpunit/Unit/LingoI18NTest.php

Spacing +2 added lines, -2 removed lines

@@ -54,12 +54,12 @@
 		$data = json_decode( json_encode( $defined_vars[ 'magicWords' ] ) );
 
 		$validator = new \JsonSchema\Validator();
-		$validator->check( $data, (object)[ '$ref' =>
+		$validator->check( $data, (object) [ '$ref' =>
 			'file://' . realpath( __DIR__ . '/../Fixture/magicWordsSchema.json' ) ] );
 
 		// format error message
 		$errors = implode( '', array_map(
-			function ( $error ) {
+			function( $error ) {
 				return "* [{$error[ 'property' ]}] {$error[ 'message' ]}\n";
 			},
 			$validator->getErrors()

tests/phpunit/Unit/ElementTest.php

Spacing +6 added lines, -6 removed lines

@@ -53,7 +53,7 @@ 
 	 */
 	public function testCanConstruct() {
 		$term = 'someTerm';
-		$definition = [];
+		$definition = [ ];
 		$element = new Element( $term, $definition );
 
 		$this->assertInstanceOf( '\Lingo\Element', $element );
@@ -100,7 +100,7 @@ 
 	public function testGetFormattedTerm_2() {
 		// Setup
 		$term = 'someTerm';
-		$definition = [];
+		$definition = [ ];
 		$element = new Element( $term, $definition );
 
 		$GLOBALS[ 'wgexLingoDisplayOnce' ] = true;
@@ -142,7 +142,7 @@ 
 
 		$element = new Element( $term, $definition );
 
-		$expectedAttributes = [ 'class' => [ 'mw-lingo-term', 'new' ],  'title' => wfMessage( 'red-link-title', $title )->text() ];
+		$expectedAttributes = [ 'class' => [ 'mw-lingo-term', 'new' ], 'title' => wfMessage( 'red-link-title', $title )->text() ];
 
 		$GLOBALS[ 'wgexLingoDisplayOnce' ] = false;
 
@@ -178,7 +178,7 @@ 
 
 		$element = new Element( $term, $definition );
 
-		$expectedAttributes = [ 'class' => [ 'mw-lingo-term' ],  'title' => $title ];
+		$expectedAttributes = [ 'class' => [ 'mw-lingo-term' ], 'title' => $title ];
 
 		$GLOBALS[ 'wgexLingoDisplayOnce' ] = false;
 
@@ -476,7 +476,7 @@ 
 	 * @param string[] $expectedAttributes
 	 * @param array $unexpectedAttributes
 	 */
-	protected function checkTermIsDomElement( $node, $tagName, $text, $expectedAttributes = [], $unexpectedAttributes = [] ) {
+	protected function checkTermIsDomElement( $node, $tagName, $text, $expectedAttributes = [ ], $unexpectedAttributes = [ ] ) {
 		$nodeText = $this->doc->saveHTML( $node );
 
 		$this->assertInstanceOf( 'DOMElement', $node );
@@ -487,7 +487,7 @@ 
 
 			$classes = array_flip( array_filter( explode( ' ', $node->getAttribute( 'class' ) ) ) );
 
-			foreach ( (array)$expectedAttributes[ 'class' ] as $expectedClass ) {
+			foreach ( (array) $expectedAttributes[ 'class' ] as $expectedClass ) {
 				$this->assertTrue( array_key_exists( $expectedClass, $classes ) );
 			}
 

tests/phpunit/Integration/ArticleAnnotationTest.php

Spacing +4 added lines, -4 removed lines

@@ -88,7 +88,7 @@ 
 	}
 
 	public function provideData() {
-		$data = [];
+		$data = [ ];
 
 		$xmlFileProvider = new XmlFileProvider( __DIR__ . '/../Fixture/articleAnnotation' );
 		$files = $xmlFileProvider->getFiles();
@@ -105,7 +105,7 @@ 
 			$testCase = [
 				0 => substr( $file, strlen( __DIR__ . '/../Fixture/articleAnnotation' ) ),
 				1 => trim( $decoded[ 'text' ] ),
-				2 => [],
+				2 => [ ],
 				3 => trim( $decoded[ 'expected' ] ) . "\n",
 			];
 
@@ -114,12 +114,12 @@ 
 			}
 
 			foreach ( $decoded[ 'glossary-entry' ] as $entry ) {
-				$testCase[ 2 ][] = [ $entry[ 'term' ], $entry[ 'definition' ], $entry[ 'link' ], $entry[ 'style' ] ];
+				$testCase[ 2 ][ ] = [ $entry[ 'term' ], $entry[ 'definition' ], $entry[ 'link' ], $entry[ 'style' ] ];
 			}
 
 			\MediaWiki\restoreWarnings();
 
-			$data[] = $testCase;
+			$data[ ] = $testCase;
 		}
 
 		return $data;

tests/mw-phpunit-runner.php

Spacing +2 added lines, -2 removed lines

@@ -70,6 +70,6 @@
 $config = isReadablePath( "$extDirectory/phpunit.xml.dist" );
 $mw = isReadablePath( dirname( dirname( $extDirectory ) ) . "/tests/phpunit/phpunit.php" );
 
-echo "php {$mw} -c {$config} " . implode( ' ', addArguments( $GLOBALS['argv'] ) ) . "\n\n";
+echo "php {$mw} -c {$config} " . implode( ' ', addArguments( $GLOBALS[ 'argv' ] ) ) . "\n\n";
 
-passthru( "php {$mw} -c {$config} " . implode( ' ', addArguments( $GLOBALS['argv'] ) ) );
+passthru( "php {$mw} -c {$config} " . implode( ' ', addArguments( $GLOBALS[ 'argv' ] ) ) );

src/BasicBackend.php

Spacing +6 added lines, -6 removed lines

@@ -72,8 +72,8 @@ 
 	 */
 	public function next() {
 		static $term = null;
-		static $definitions = [];
-		static $ret = [];
+		static $definitions = [ ];
+		static $ret = [ ];
 
 		$this->collectDictionaryLines();
 
@@ -109,11 +109,11 @@ 
 
 			// wipe the data if it's a totally new term definition
 			if ( !empty( $term ) && count( $definitions ) > 0 ) {
-				$definitions = [];
+				$definitions = [ ];
 				$term = null;
 			}
 
-			$definitions[] = trim( $chunks[ 1 ] );
+			$definitions[ ] = trim( $chunks[ 1 ] );
 		}
 
 		// found a new term?
@@ -130,10 +130,10 @@ 
 	 * @return array
 	 */
 	protected function queueDefinitions( $definitions, $term ) {
-		$ret = [];
+		$ret = [ ];
 
 		foreach ( $definitions as $definition ) {
-			$ret[] = [
+			$ret[ ] = [
 				Element::ELEMENT_TERM       => $term,
 				Element::ELEMENT_DEFINITION => $definition,
 				Element::ELEMENT_LINK       => null,