Issues in Lingo.php - All Issues - Inspection of "Fix integration tests" - wikimedia/mediawiki-extensions-Lingo - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 841b7d...3ed1d3 )

unknown

created 2018-03-24 00:44 UTC

src/Lingo.php (2 issues)

Labels

Severity

Minor 2

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * File containing the Lingo class
 *
 * This file is part of the MediaWiki extension Lingo.
 *
 * @copyright 2011 - 2018, Stephan Gambke
 * @license   GNU General Public License, version 2 (or any later version)
 *
 * The Lingo extension is free software: you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by the Free
 * Software Foundation; either version 2 of the License, or (at your option) any
 * later version.
 *
 * The Lingo extension is distributed in the hope that it will be useful, but
 * WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more
 * details.
 *
 * You should have received a copy of the GNU General Public License along
 * with this program. If not, see <http://www.gnu.org/licenses/>.
 *
 * @file
 * @ingroup Lingo
 */

namespace Lingo;

/**
 * Class Lingo
 *
 * @package Lingo
 * @ingroup Lingo
 */
class Lingo {

	/**
	 * Deferred settings
	 * - registration of _NOGLOSSARY_ magic word
	 * - extension description shown on Special:Version
	 *
	 * @since 2.0.2
	 */
	public static function initExtension() {
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}

		$GLOBALS[ 'wgExtensionFunctions' ][] = function () {

			$parser = LingoParser::getInstance();

			$backend = new $GLOBALS[ 'wgexLingoBackend' ]();

			$parser->setBackend( $backend );

			\Hooks::register( 'ContentAlterParserOutput', [ $parser, 'parse' ] );

			\Hooks::register('GetDoubleUnderscoreIDs', function ( array &$doubleUnderscoreIDs ) {
				$doubleUnderscoreIDs[] = 'noglossary';
				return true;
			} );

			\Hooks::register( 'ParserFirstCallInit', function ( \Parser $parser ) {

				$parser->setHook( 'noglossary', function ( $input, array $args, \Parser $parser, \PPFrame $frame ) {
					$output = $parser->recursiveTagParse( $input, $frame );
					return '<span class="noglossary">' . $output . '</span>';
				} );

				return true;
			} );

			\Hooks::register( 'SpecialPageBeforeExecute', function ( \SpecialPage $specialPage, $subPage ) {


				if ( $specialPage instanceof \SpecialVersion ) {
					foreach ( $GLOBALS[ 'wgExtensionCredits' ][ 'parserhook' ] as $index => $description ) {
						if ( $GLOBALS[ 'wgExtensionCredits' ][ 'parserhook' ][ $index ][ 'name' ] === 'Lingo' ) {
							$GLOBALS[ 'wgExtensionCredits' ][ 'parserhook' ][ $index ][ 'description' ] = wfMessage( 'lingo-desc', $GLOBALS[ 'wgexLingoPage' ] ?: wfMessage( 'lingo-terminologypagename' )->inContentLanguage()->text() )->text();
						}
					}
				}

				return true;
			} );
		};
	}

}


1			<?php
2			/**
3			* File containing the Lingo class
4			*
5			* This file is part of the MediaWiki extension Lingo.
6			*
7			* @copyright 2011 - 2018, Stephan Gambke
8			* @license GNU General Public License, version 2 (or any later version)
9			*
10			* The Lingo extension is free software: you can redistribute it and/or modify
11			* it under the terms of the GNU General Public License as published by the Free
12			* Software Foundation; either version 2 of the License, or (at your option) any
13			* later version.
14			*
15			* The Lingo extension is distributed in the hope that it will be useful, but
16			* WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
17			* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more
18			* details.
19			*
20			* You should have received a copy of the GNU General Public License along
21			* with this program. If not, see <http://www.gnu.org/licenses/>.
22			*
23			* @file
24			* @ingroup Lingo
25			*/
26
27			namespace Lingo;
28
29			/**
30			* Class Lingo
31			*
32			* @package Lingo
33			* @ingroup Lingo
34			*/
35			class Lingo {
36
37			/**
38			* Deferred settings
39			* - registration of _NOGLOSSARY_ magic word
40			* - extension description shown on Special:Version
41			*
42			* @since 2.0.2
43			*/
44			public static function initExtension() {
			0 ignored issues – show Coding Style introduced 2016-02-29 08:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this `initExtension` uses the super-global variable `$GLOBALS` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
45
46			$GLOBALS[ 'wgExtensionFunctions' ][] = function () {
47
48			$parser = LingoParser::getInstance();
49
50			$backend = new $GLOBALS[ 'wgexLingoBackend' ]();
51
52			$parser->setBackend( $backend );
53
54			\Hooks::register( 'ContentAlterParserOutput', [ $parser, 'parse' ] );
55
56			\Hooks::register('GetDoubleUnderscoreIDs', function ( array &$doubleUnderscoreIDs ) {
57			$doubleUnderscoreIDs[] = 'noglossary';
58			return true;
59			} );
60
61			\Hooks::register( 'ParserFirstCallInit', function ( \Parser $parser ) {
62
63			$parser->setHook( 'noglossary', function ( $input, array $args, \Parser $parser, \PPFrame $frame ) {
64			$output = $parser->recursiveTagParse( $input, $frame );
65			return '<span class="noglossary">' . $output . '</span>';
66			} );
67
68			return true;
69			} );
70
71			\Hooks::register( 'SpecialPageBeforeExecute', function ( \SpecialPage $specialPage, $subPage ) {
			0 ignored issues – show Unused Code introduced 2017-05-23 22:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this The parameter `$subPage` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
72
73			if ( $specialPage instanceof \SpecialVersion ) {
74			foreach ( $GLOBALS[ 'wgExtensionCredits' ][ 'parserhook' ] as $index => $description ) {
75			if ( $GLOBALS[ 'wgExtensionCredits' ][ 'parserhook' ][ $index ][ 'name' ] === 'Lingo' ) {
76			$GLOBALS[ 'wgExtensionCredits' ][ 'parserhook' ][ $index ][ 'description' ] = wfMessage( 'lingo-desc', $GLOBALS[ 'wgexLingoPage' ] ?: wfMessage( 'lingo-terminologypagename' )->inContentLanguage()->text() )->text();
77			}
78			}
79			}
80
81			return true;
82			} );
83			};
84			}
85
86			}
87

GitHub Access Token became invalid

Push — master ( 841b7d...3ed1d3 )

src/Lingo.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

wikimedia / mediawiki-extensions-Lingo

GitHub Access Token became invalid

Push — master ( 841b7d...3ed1d3 )

src/Lingo.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like