Complex classes like ExtraPackage often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use ExtraPackage, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
33 | class ExtraPackage |
||
34 | { |
||
35 | |||
36 | /** |
||
37 | * @var Composer $composer |
||
38 | */ |
||
39 | protected $composer; |
||
40 | |||
41 | /** |
||
42 | * @var Logger $logger |
||
43 | */ |
||
44 | protected $logger; |
||
45 | |||
46 | /** |
||
47 | * @var string $path |
||
48 | */ |
||
49 | protected $path; |
||
50 | |||
51 | /** |
||
52 | * @var array $json |
||
53 | */ |
||
54 | protected $json; |
||
55 | |||
56 | /** |
||
57 | * @var CompletePackage $package |
||
58 | */ |
||
59 | protected $package; |
||
60 | |||
61 | /** |
||
62 | * @var VersionParser $versionParser |
||
63 | */ |
||
64 | protected $versionParser; |
||
65 | |||
66 | /** |
||
67 | * @param string $path Path to composer.json file |
||
68 | * @param Composer $composer |
||
69 | * @param Logger $logger |
||
70 | */ |
||
71 | 160 | public function __construct($path, Composer $composer, Logger $logger) |
|
80 | |||
81 | /** |
||
82 | * Get list of additional packages to include if precessing recursively. |
||
83 | * |
||
84 | * @return array |
||
85 | */ |
||
86 | 155 | public function getIncludes() |
|
91 | |||
92 | /** |
||
93 | * Get list of additional packages to require if precessing recursively. |
||
94 | * |
||
95 | * @return array |
||
96 | */ |
||
97 | 155 | public function getRequires() |
|
102 | |||
103 | /** |
||
104 | * Read the contents of a composer.json style file into an array. |
||
105 | * |
||
106 | * The package contents are fixed up to be usable to create a Package |
||
107 | * object by providing dummy "name" and "version" values if they have not |
||
108 | * been provided in the file. This is consistent with the default root |
||
109 | * package loading behavior of Composer. |
||
110 | * |
||
111 | * @param string $path |
||
112 | * @return array |
||
113 | */ |
||
114 | 160 | protected function readPackageJson($path) |
|
127 | |||
128 | /** |
||
129 | * @param array $json |
||
130 | * @return CompletePackage |
||
131 | */ |
||
132 | 160 | protected function loadPackage(array $json) |
|
146 | |||
147 | /** |
||
148 | * Merge this package into a RootPackageInterface |
||
149 | * |
||
150 | * @param RootPackageInterface $root |
||
151 | * @param PluginState $state |
||
152 | */ |
||
153 | 160 | public function mergeInto(RootPackageInterface $root, PluginState $state) |
|
177 | |||
178 | /** |
||
179 | * Merge just the dev portion into a RootPackageInterface |
||
180 | * |
||
181 | * @param RootPackageInterface $root |
||
182 | * @param PluginState $state |
||
183 | */ |
||
184 | 155 | public function mergeDevInto(RootPackageInterface $root, PluginState $state) |
|
190 | |||
191 | /** |
||
192 | * Add a collection of repositories described by the given configuration |
||
193 | * to the given package and the global repository manager. |
||
194 | * |
||
195 | * @param RootPackageInterface $root |
||
196 | */ |
||
197 | 160 | protected function prependRepositories(RootPackageInterface $root) |
|
224 | |||
225 | /** |
||
226 | * Merge require or require-dev into a RootPackageInterface |
||
227 | * |
||
228 | * @param string $type 'require' or 'require-dev' |
||
229 | * @param RootPackageInterface $root |
||
230 | * @param PluginState $state |
||
231 | */ |
||
232 | 160 | protected function mergeRequires( |
|
261 | |||
262 | /** |
||
263 | * Merge two collections of package links and collect duplicates for |
||
264 | * subsequent processing. |
||
265 | * |
||
266 | * @param string $type 'require' or 'require-dev' |
||
267 | * @param array $origin Primary collection |
||
268 | * @param array $merge Additional collection |
||
269 | * @param PluginState $state |
||
270 | * @return array Merged collection |
||
271 | */ |
||
272 | 85 | protected function mergeOrDefer( |
|
294 | |||
295 | /** |
||
296 | * Merge autoload or autoload-dev into a RootPackageInterface |
||
297 | * |
||
298 | * @param string $type 'autoload' or 'devAutoload' |
||
299 | * @param RootPackageInterface $root |
||
300 | */ |
||
301 | 160 | protected function mergeAutoload($type, RootPackageInterface $root) |
|
317 | |||
318 | /** |
||
319 | * Fix a collection of paths that are relative to this package to be |
||
320 | * relative to the base package. |
||
321 | * |
||
322 | * @param array $paths |
||
323 | * @return array |
||
324 | */ |
||
325 | 15 | protected function fixRelativePaths(array $paths) |
|
338 | |||
339 | /** |
||
340 | * Extract and merge stability flags from the given collection of |
||
341 | * requires and merge them into a RootPackageInterface |
||
342 | * |
||
343 | * @param RootPackageInterface $root |
||
344 | * @param array $requires |
||
345 | */ |
||
346 | 85 | protected function mergeStabilityFlags( |
|
359 | |||
360 | /** |
||
361 | * Merge package links of the given type into a RootPackageInterface |
||
362 | * |
||
363 | * @param string $type 'conflict', 'replace' or 'provide' |
||
364 | * @param RootPackageInterface $root |
||
365 | */ |
||
366 | 160 | protected function mergePackageLinks($type, RootPackageInterface $root) |
|
389 | |||
390 | /** |
||
391 | * Merge suggested packages into a RootPackageInterface |
||
392 | * |
||
393 | * @param RootPackageInterface $root |
||
394 | */ |
||
395 | 160 | protected function mergeSuggests(RootPackageInterface $root) |
|
406 | |||
407 | /** |
||
408 | * Merge extra config into a RootPackageInterface |
||
409 | * |
||
410 | * @param RootPackageInterface $root |
||
411 | * @param PluginState $state |
||
412 | */ |
||
413 | 160 | public function mergeExtra(RootPackageInterface $root, PluginState $state) |
|
445 | |||
446 | /** |
||
447 | * Merge scripts config into a RootPackageInterface |
||
448 | * |
||
449 | * @param RootPackageInterface $root |
||
450 | * @param PluginState $state |
||
451 | */ |
||
452 | 160 | public function mergeScripts(RootPackageInterface $root, PluginState $state) |
|
472 | |||
473 | /** |
||
474 | * Merges two arrays either via arrayMergeDeep or via array_merge. |
||
475 | * |
||
476 | * @param bool $mergeDeep |
||
477 | * @param array $array1 |
||
478 | * @param array $array2 |
||
479 | * @return array |
||
480 | */ |
||
481 | 30 | public static function mergeExtraArray($mergeDeep, $array1, $array2) |
|
489 | |||
490 | /** |
||
491 | * Update Links with a 'self.version' constraint with the root package's |
||
492 | * version. |
||
493 | * |
||
494 | * @param string $type Link type |
||
495 | * @param array $links |
||
496 | * @param RootPackageInterface $root |
||
497 | * @return array |
||
498 | */ |
||
499 | 100 | protected function replaceSelfVersionDependencies( |
|
540 | |||
541 | /** |
||
542 | * Get a full featured Package from a RootPackageInterface. |
||
543 | * |
||
544 | * In Composer versions before 599ad77 the RootPackageInterface only |
||
545 | * defines a sub-set of operations needed by composer-merge-plugin and |
||
546 | * RootAliasPackage only implemented those methods defined by the |
||
547 | * interface. Most of the unimplemented methods in RootAliasPackage can be |
||
548 | * worked around because the getter methods that are implemented proxy to |
||
549 | * the aliased package which we can modify by unwrapping. The exception |
||
550 | * being modifying the 'conflicts', 'provides' and 'replaces' collections. |
||
551 | * We have no way to actually modify those collections unfortunately in |
||
552 | * older versions of Composer. |
||
553 | * |
||
554 | * @param RootPackageInterface $root |
||
555 | * @param string $method Method needed |
||
556 | * @return RootPackageInterface|RootPackage |
||
557 | */ |
||
558 | 160 | public static function unwrapIfNeeded( |
|
572 | |||
573 | /** |
||
574 | * Update the root packages reference information. |
||
575 | * |
||
576 | * @param RootPackageInterface $root |
||
577 | */ |
||
578 | 160 | protected function mergeReferences(RootPackageInterface $root) |
|
595 | |||
596 | /** |
||
597 | * Extract vcs revision from version constraint (dev-master#abc123. |
||
598 | * |
||
599 | * @param array $requires |
||
600 | * @param array $references |
||
601 | * @return array |
||
602 | * @see RootPackageLoader::extractReferences() |
||
603 | */ |
||
604 | 160 | protected function extractReferences(array $requires, array $references) |
|
620 | } |
||
621 | // vim:sw=4:ts=4:sts=4:et: |
||
622 |