Complex classes like ExtraPackage often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use ExtraPackage, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 33 | class ExtraPackage |
||
| 34 | { |
||
| 35 | |||
| 36 | /** |
||
| 37 | * @var Composer $composer |
||
| 38 | */ |
||
| 39 | protected $composer; |
||
| 40 | |||
| 41 | /** |
||
| 42 | * @var Logger $logger |
||
| 43 | */ |
||
| 44 | protected $logger; |
||
| 45 | |||
| 46 | /** |
||
| 47 | * @var string $path |
||
| 48 | */ |
||
| 49 | protected $path; |
||
| 50 | |||
| 51 | /** |
||
| 52 | * @var array $json |
||
| 53 | */ |
||
| 54 | protected $json; |
||
| 55 | |||
| 56 | /** |
||
| 57 | * @var CompletePackage $package |
||
| 58 | */ |
||
| 59 | protected $package; |
||
| 60 | |||
| 61 | /** |
||
| 62 | * @var VersionParser $versionParser |
||
| 63 | */ |
||
| 64 | protected $versionParser; |
||
| 65 | |||
| 66 | 80 | /** |
|
| 67 | * @param string $path Path to composer.json file |
||
| 68 | 80 | * @param Composer $composer |
|
| 69 | 80 | * @param Logger $logger |
|
| 70 | 80 | */ |
|
| 71 | 80 | public function __construct($path, Composer $composer, Logger $logger) |
|
| 80 | 75 | ||
| 81 | /** |
||
| 82 | 75 | * Get list of additional packages to include if precessing recursively. |
|
| 83 | 75 | * |
|
| 84 | * @return array |
||
| 85 | */ |
||
| 86 | public function getIncludes() |
||
| 91 | 75 | ||
| 92 | /** |
||
| 93 | 75 | * Get list of additional packages to require if precessing recursively. |
|
| 94 | 75 | * |
|
| 95 | * @return array |
||
| 96 | */ |
||
| 97 | public function getRequires() |
||
| 102 | |||
| 103 | /** |
||
| 104 | * Read the contents of a composer.json style file into an array. |
||
| 105 | * |
||
| 106 | * The package contents are fixed up to be usable to create a Package |
||
| 107 | * object by providing dummy "name" and "version" values if they have not |
||
| 108 | 80 | * been provided in the file. This is consistent with the default root |
|
| 109 | * package loading behavior of Composer. |
||
| 110 | 80 | * |
|
| 111 | 80 | * @param string $path |
|
| 112 | 80 | * @return array |
|
| 113 | 80 | */ |
|
| 114 | 80 | protected function readPackageJson($path) |
|
| 127 | |||
| 128 | 80 | /** |
|
| 129 | 80 | * @param string $json |
|
| 130 | * @return CompletePackage |
||
| 131 | */ |
||
| 132 | protected function loadPackage($json) |
||
| 146 | |||
| 147 | 80 | /** |
|
| 148 | * Merge this package into a RootPackageInterface |
||
| 149 | 80 | * |
|
| 150 | * @param RootPackageInterface $root |
||
| 151 | 80 | * @param PluginState $state |
|
| 152 | 80 | */ |
|
| 153 | 75 | public function mergeInto(RootPackageInterface $root, PluginState $state) |
|
| 176 | 80 | ||
| 177 | /** |
||
| 178 | 80 | * Add a collection of repositories described by the given configuration |
|
| 179 | 75 | * to the given package and the global repository manager. |
|
| 180 | * |
||
| 181 | 5 | * @param RootPackageInterface $root |
|
| 182 | 5 | */ |
|
| 183 | protected function addRepositories(RootPackageInterface $root) |
||
| 210 | |||
| 211 | 80 | /** |
|
| 212 | * Merge require or require-dev into a RootPackageInterface |
||
| 213 | * |
||
| 214 | * @param string $type 'require' or 'require-dev' |
||
| 215 | * @param RootPackageInterface $root |
||
| 216 | 80 | * @param PluginState $state |
|
| 217 | 80 | */ |
|
| 218 | 80 | protected function mergeRequires( |
|
| 247 | |||
| 248 | /** |
||
| 249 | * Merge two collections of package links and collect duplicates for |
||
| 250 | * subsequent processing. |
||
| 251 | 55 | * |
|
| 252 | * @param string $type 'require' or 'require-dev' |
||
| 253 | * @param array $origin Primary collection |
||
| 254 | * @param array $merge Additional collection |
||
| 255 | * @param PluginState $state |
||
| 256 | * @return array Merged collection |
||
| 257 | 55 | */ |
|
| 258 | 55 | protected function mergeOrDefer( |
|
| 280 | 80 | ||
| 281 | /** |
||
| 282 | 80 | * Merge autoload or autoload-dev into a RootPackageInterface |
|
| 283 | 80 | * |
|
| 284 | * @param string $type 'autoload' or 'devAutoload' |
||
| 285 | 80 | * @param RootPackageInterface $root |
|
| 286 | 80 | */ |
|
| 287 | 80 | protected function mergeAutoload($type, RootPackageInterface $root) |
|
| 303 | |||
| 304 | 5 | /** |
|
| 305 | * Fix a collection of paths that are relative to this package to be |
||
| 306 | 5 | * relative to the base package. |
|
| 307 | 5 | * |
|
| 308 | * @param array $paths |
||
| 309 | 5 | * @return array |
|
| 310 | 5 | */ |
|
| 311 | protected function fixRelativePaths(array $paths) |
||
| 324 | |||
| 325 | 55 | /** |
|
| 326 | * Extract and merge stability flags from the given collection of |
||
| 327 | * requires and merge them into a RootPackageInterface |
||
| 328 | * |
||
| 329 | 55 | * @param RootPackageInterface $root |
|
| 330 | 55 | * @param array $requires |
|
| 331 | */ |
||
| 332 | 55 | protected function mergeStabilityFlags( |
|
| 345 | 80 | ||
| 346 | /** |
||
| 347 | 80 | * Merge package links of the given type into a RootPackageInterface |
|
| 348 | 80 | * |
|
| 349 | 80 | * @param string $type 'conflict', 'replace' or 'provide' |
|
| 350 | * @param RootPackageInterface $root |
||
| 351 | 80 | */ |
|
| 352 | 80 | protected function mergePackageLinks($type, RootPackageInterface $root) |
|
| 373 | |||
| 374 | 80 | /** |
|
| 375 | 80 | * Merge suggested packages into a RootPackageInterface |
|
| 376 | 5 | * |
|
| 377 | 5 | * @param RootPackageInterface $root |
|
| 378 | 5 | */ |
|
| 379 | protected function mergeSuggests(RootPackageInterface $root) |
||
| 390 | 80 | ||
| 391 | /** |
||
| 392 | 80 | * Merge extra config into a RootPackageInterface |
|
| 393 | 80 | * |
|
| 394 | 80 | * @param RootPackageInterface $root |
|
| 395 | 65 | * @param PluginState $state |
|
| 396 | */ |
||
| 397 | public function mergeExtra(RootPackageInterface $root, PluginState $state) |
||
| 428 | |||
| 429 | /** |
||
| 430 | * Update Links with a 'self.version' constraint with the root package's |
||
| 431 | 60 | * version. |
|
| 432 | * |
||
| 433 | * @param string $type Link type |
||
| 434 | * @param array $links |
||
| 435 | * @param RootPackageInterface $root |
||
| 436 | 60 | * @return array |
|
| 437 | 60 | */ |
|
| 438 | 60 | protected function replaceSelfVersionDependencies( |
|
| 463 | |||
| 464 | /** |
||
| 465 | * Get a full featured Package from a RootPackageInterface. |
||
| 466 | * |
||
| 467 | * In Composer versions before 599ad77 the RootPackageInterface only |
||
| 468 | * defines a sub-set of operations needed by composer-merge-plugin and |
||
| 469 | * RootAliasPackage only implemented those methods defined by the |
||
| 470 | * interface. Most of the unimplemented methods in RootAliasPackage can be |
||
| 471 | * worked around because the getter methods that are implemented proxy to |
||
| 472 | * the aliased package which we can modify by unwrapping. The exception |
||
| 473 | * being modifying the 'conflicts', 'provides' and 'replaces' collections. |
||
| 474 | * We have no way to actually modify those collections unfortunately in |
||
| 475 | 80 | * older versions of Composer. |
|
| 476 | * |
||
| 477 | * @param RootPackageInterface $root |
||
| 478 | * @param string $method Method needed |
||
| 479 | 80 | * @return RootPackageInterface|RootPackage |
|
| 480 | */ |
||
| 481 | 80 | public static function unwrapIfNeeded( |
|
| 493 | |||
| 494 | /** |
||
| 495 | * Update the root packages reference information. |
||
| 496 | * |
||
| 497 | * @param \Composer\Package\RootPackage $root |
||
| 498 | */ |
||
| 499 | protected function mergeReferences(RootPackage $root) { |
||
| 515 | |||
| 516 | /** |
||
| 517 | * Extract vcs revision from version constraint (dev-master#abc123. |
||
| 518 | * |
||
| 519 | * @param array $requires |
||
| 520 | * @param array $references |
||
| 521 | * @return array |
||
| 522 | * @see RootPackageLoader::extractReferences() |
||
| 523 | */ |
||
| 524 | protected function extractReferences(array $requires, array $references) |
||
| 540 | } |
||
| 541 | // vim:sw=4:ts=4:sts=4:et: |
||
| 542 |
It seems like the type of the argument is not accepted by the function/method which you are calling.
In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug.
We suggest to add an explicit type cast like in the following example: