Pagerfanta\Adapter\ElasticsearchAdapter

Complexity

Total Complexity

6

Size/Duplication

Total Lines	72
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Test Coverage

Coverage

0%

Importance

Changes	1
Bugs	0	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	getNbResults()	0	7	2
A	getSlice()	0	8	1
A	runQuery()	0	7	2

<?php

namespace Pagerfanta\Adapter;

use Elasticsearch\Client;

/**
 * ElasticsearchAdapter.
 *
 * Used with the official Elasticsearch PHP library.
 * 
 * @author Danny Sipos <danny@webomelette.com>
 */
class ElasticsearchAdapter implements AdapterInterface
{

  /**
   * The Elasticsearch query parameters.
   *
   * @var array
   */
  private $params;

  /**
   * The Elasticsearch results
   *
   * @var array
   */
  private $results;

  /**
   * The Elasticsearch client.
   *
   * @var Client
   */
  private $client;

  /**
   * Constructor.
   *
   * @param array $params The array of parameters to use for performing the search.
   * @param Client $client The Elasticsearch client.
   */
  public function __construct(array $params, $client)
  {
    $this->params = $params;
    $this->client = $client;
  }

  /**
   * {@inheritdoc}
   */
  public function getNbResults()
  {
    if (!$this->results) {

The expression $this->results of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using empty($expr) instead to make it clear that you intend to check for an array without elements.

      $this->runQuery();
    }
    return $this->results['hits']['total'];
  }

  /**
   * {@inheritdoc}
   */
  public function getSlice($offset, $length)
  {
    $params = $this->params;
    $params['from'] = $offset;
    $params['size'] = $length;
    $this->runQuery($params);
    return $this->results;
  }

  /**
   * Runs the query and stores the results.
   *
   * @param array $params
   */
  private function runQuery($params = array())
  {
    if (!$params) {

The expression $params of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using empty($expr) instead to make it clear that you intend to check for an array without elements.

      $params = $this->params;
    }
    $this->results = $this->client->search($params);
  }
}