AbstractTransformer::loadCollection() - Code Metrics - Inspection of "create event "create order"" - whera/sift-science - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( fb0370...84a128 )

by Ronaldo

created 2017-08-10 22:03 UTC

AbstractTransformer::loadCollection() A

↳ Parent: AbstractTransformer

Complexity

Conditions	2
Paths	2

Size

Total Lines	9
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes

Metric	Value
dl	0
loc	9
ccs	0
cts	6
cp	0
rs	9.6666
c	0
b	0
f	0
cc	2
eloc	6
nc	2
nop	2
crap	6

<?php

namespace WSW\SiftScience\Transformers;

use League\Fractal\Serializer\ArraySerializer;
use League\Fractal\TransformerAbstract;

/**
 * Class AbstractTransformer
 *
 * @package WSW\SiftScience\Transformers
 * @author Ronaldo Matos Rodrigues <[email protected]>
 */
abstract class AbstractTransformer extends TransformerAbstract
{
    /**
     * @param mixed $data
     * @param AbstractTransformer $transformer
     *
     * @return array
     */
    protected function loadItem($data = null, AbstractTransformer $transformer = null)
    {
        return $this->getCurrentScope()
                    ->getManager()
                    ->createData($this->item($data, $transformer))
function notNullable(stdClass $x) { }

// Unsafe
function withoutCheck(stdClass $x = null) {
    notNullable($x);
}

// Safe - Alternative 1: Adding Additional Type-Check
function withCheck(stdClass $x = null) {
    if ($x instanceof stdClass) {
        notNullable($x);
    }
}

// Safe - Alternative 2: Changing Parameter
function withNonNullableParam(stdClass $x) {
    notNullable($x);
}
                    ->toArray();
    }

    /**
     * @param mixed $data
     * @param AbstractTransformer $transformer
     *
     * @return array
     */
    protected function loadCollection($data = null, AbstractTransformer $transformer = null)
    {
        $result = $this->getCurrentScope()
                    ->getManager()
                    ->setSerializer(new ArraySerializer)
                    ->createData($this->collection($data, $transformer))->toArray();
function notNullable(stdClass $x) { }

// Unsafe
function withoutCheck(stdClass $x = null) {
    notNullable($x);
}

// Safe - Alternative 1: Adding Additional Type-Check
function withCheck(stdClass $x = null) {
    if ($x instanceof stdClass) {
        notNullable($x);
    }
}

// Safe - Alternative 2: Changing Parameter
function withNonNullableParam(stdClass $x) {
    notNullable($x);
}

        return (isset($result['data'])) ? $result['data'] : $result;
    }
}


1			<?php
2
3			namespace WSW\SiftScience\Transformers;
4
5			use League\Fractal\Serializer\ArraySerializer;
6			use League\Fractal\TransformerAbstract;
7
8			/**
9			* Class AbstractTransformer
10			*
11			* @package WSW\SiftScience\Transformers
12			* @author Ronaldo Matos Rodrigues <[email protected]>
13			*/
14			abstract class AbstractTransformer extends TransformerAbstract
15			{
16			/**
17			* @param mixed $data
18			* @param AbstractTransformer $transformer
19			*
20			* @return array
21			*/
22			protected function loadItem($data = null, AbstractTransformer $transformer = null)
23			{
24			return $this->getCurrentScope()
25			->getManager()
26			->createData($this->item($data, $transformer))
			0 ignored issues – show Bug introduced 2017-08-10 22:06 UTC by Report Bug Copy Issue Report It seems like `$transformer` defined by parameter `$transformer` on line `22` can be `null`; however, `League\Fractal\TransformerAbstract::item()` does not accept `null`, maybe add an additional type check? It seems like you allow that null is being passed for a parameter, however the function which is called does not seem to accept null. We recommend to add an additional type check (or disallow null for the parameter): function notNullable(stdClass $x) { } // Unsafe function withoutCheck(stdClass $x = null) { notNullable($x); } // Safe - Alternative 1: Adding Additional Type-Check function withCheck(stdClass $x = null) { if ($x instanceof stdClass) { notNullable($x); } } // Safe - Alternative 2: Changing Parameter function withNonNullableParam(stdClass $x) { notNullable($x); } Loading history...
27			->toArray();
28			}
29
30			/**
31			* @param mixed $data
32			* @param AbstractTransformer $transformer
33			*
34			* @return array
35			*/
36			protected function loadCollection($data = null, AbstractTransformer $transformer = null)
37			{
38			$result = $this->getCurrentScope()
39			->getManager()
40			->setSerializer(new ArraySerializer)
41			->createData($this->collection($data, $transformer))->toArray();
			0 ignored issues – show Bug introduced 2017-08-10 22:06 UTC by Report Bug Copy Issue Report It seems like `$transformer` defined by parameter `$transformer` on line `36` can be `null`; however, `League\Fractal\TransformerAbstract::collection()` does not accept `null`, maybe add an additional type check? It seems like you allow that null is being passed for a parameter, however the function which is called does not seem to accept null. We recommend to add an additional type check (or disallow null for the parameter): function notNullable(stdClass $x) { } // Unsafe function withoutCheck(stdClass $x = null) { notNullable($x); } // Safe - Alternative 1: Adding Additional Type-Check function withCheck(stdClass $x = null) { if ($x instanceof stdClass) { notNullable($x); } } // Safe - Alternative 2: Changing Parameter function withNonNullableParam(stdClass $x) { notNullable($x); } Loading history...
42
43			return (isset($result['data'])) ? $result['data'] : $result;
44			}
45			}
46

whera / sift-science

Push — master ( fb0370...84a128 )

AbstractTransformer::loadCollection() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like