whahn1983 / pycashflow

app/auth.py

from flask import Blueprint, render_template, redirect, url_for, request, flash, session
from flask_login import login_user, login_required, logout_user, current_user
from werkzeug.security import generate_password_hash, check_password_hash
from .models import User
from app import db
from .getemail import send_new_user_notification
import pandas as pd
import os
from functools import wraps
from werkzeug.exceptions import Unauthorized
from corbado_python_sdk import Config, CorbadoSDK, UserEntity


auth = Blueprint('auth', __name__)


short_session_cookie_name = "cbo_short_session"

# Read environment variables safely (returns None if missing)
API_SECRET = os.getenv("API_SECRET")
PROJECT_ID = os.getenv("PROJECT_ID")
FRONTEND_URI = os.getenv("FRONTEND_URI")

corbado_config = None
corbado_enabled = all([API_SECRET, PROJECT_ID, FRONTEND_URI])

# Config has a default values for 'short_session_cookie_name' and 'BACKEND_API'
if corbado_enabled:
    config: Config = Config(
        api_secret=os.environ['API_SECRET'],
        project_id=os.environ['PROJECT_ID'],
        frontend_api=os.environ['FRONTEND_URI'],
        backend_api="https://backendapi.cloud.corbado.io",
    )
    config.frontend_api = os.environ['FRONTEND_URI']

    # Initialize SDK
    sdk: CorbadoSDK = CorbadoSDK(config=config)


@auth.route('/login')
def login():
    return render_template('login.html')


@auth.route('/login', methods=['POST'])
def login_post():
    # login code goes here
    email = request.form.get('email')
    password = request.form.get('password')
    remember = True if request.form.get('remember') else False

    user = User.query.filter_by(email=email).first()

    # check if the user actually exists
    # take the user-supplied password, hash it, and compare it to the hashed password in the database
    if not user or not check_password_hash(user.password, password):
        flash('Please check your login details and try again.')
        return redirect(url_for('auth.login')) # if the user doesn't exist or password is wrong, reload the page

    # fix for no admin user to make current user an admin
    user_test = User.query.filter_by(admin=True).first()
    if not user_test:
        user.admin = 1
        db.session.commit()

    # ensure there's at least one global admin in the system
    global_admin_test = User.query.filter_by(is_global_admin=True).first()
    if not global_admin_test:
        # Set the first admin user to be a global admin
        first_admin = User.query.filter_by(admin=True).order_by(User.id).first()
        if first_admin:
            first_admin.is_global_admin = True
            db.session.commit()

    # IMPORTANT: Global admins are always active - auto-activate if needed
    if user.is_global_admin and not user.is_active:
        user.is_active = True
        db.session.commit()

    # check if the user account is active (after global admin auto-activation)
    if not user.is_active:
        flash('Your account is pending approval. Please contact an administrator.')
        return redirect(url_for('auth.login'))

    # if the above check passes, then we know the user has the right credentials
    login_user(user, remember=remember)
    session['name'] = user.name
    session['email'] = user.email

    return redirect(url_for('main.index'))


@auth.route('/signup')
def signup():
    try:
        engine = db.create_engine(os.environ.get('DATABASE_URL')).connect()
    except:
        engine = db.create_engine('sqlite:///db.sqlite').connect()

    try:
        df = pd.read_sql('SELECT * FROM settings;', engine)

        if df['value'][0] == 1:
            return render_template('login.html')
    except:
        pass

    return render_template('signup.html')


@auth.route('/signup', methods=['POST'])
def signup_post():
    # code to validate and add user to database goes here
    email = request.form.get('email')
    name = request.form.get('name')
    password = request.form.get('password')

    user = User.query.filter_by(email=email).first() # if this returns a user, then the email already exists in database

    if user: # if a user is found, we want to redirect back to signup page so user can try again
        flash('Email address already exists')
        return redirect(url_for('auth.signup'))

    # if no admin user, make new user an admin AND global admin AND active
    user_test = User.query.filter_by(admin=True).first()
    if not user_test:
        admin = True
        is_global_admin = True
        is_active = True
    else:
        # New signups are admins but inactive until approved by global admin
        admin = True
        is_global_admin = False
        is_active = False

    # create a new user with the form data. Hash the password so the plaintext version isn't saved.
    new_user = User(
        email=email,
        name=name,
        password=generate_password_hash(password, method='scrypt'),
        admin=admin,
        is_global_admin=is_global_admin,
        is_active=is_active
    )

    # add the new user to the database
    db.session.add(new_user)
    db.session.commit()

    # Send notification to global admin if this is not the first user
    # (first user becomes global admin, so no need to notify themselves)
    if not is_global_admin:
        try:
            send_new_user_notification(name, email)
        except Exception as e:
            # Don't fail registration if email notification fails
            print(f"Failed to send new user notification: {e}")

    return redirect(url_for('auth.login'))


@auth.route('/logout')
@login_required
def logout():
    logout_user()
    return redirect(url_for('main.index'))


def admin_required(f):
    @wraps(f)
    def decorated_function(*args, **kwargs):
        if current_user.admin:
            return f(*args, **kwargs)
        else:
            return redirect(url_for('main.index'))
    return decorated_function


def global_admin_required(f):
    """
    Decorator for routes that require global admin access.
    Only users with is_global_admin=True can access.
    """
    @wraps(f)
    def decorated_function(*args, **kwargs):
        if not current_user.is_authenticated:
            return redirect(url_for('auth.login'))
        if current_user.is_global_admin:
            return f(*args, **kwargs)
        else:
            flash('Global admin access required')
            return redirect(url_for('main.index'))
    return decorated_function


def account_owner_required(f):
    """
    Decorator for routes that require account owner access.
    Guest users (those with account_owner_id set) cannot access.
    """
    @wraps(f)
    def decorated_function(*args, **kwargs):
        if not current_user.is_authenticated:
            return redirect(url_for('auth.login'))
        if current_user.account_owner_id is not None:
            flash('Account owner access required')
            return redirect(url_for('main.index'))
        return f(*args, **kwargs)
    return decorated_function


@auth.route('/passkey_login')
def login_passkey():

    if corbado_enabled:
        project_id = os.environ['PROJECT_ID']
        frontend_uri = os.environ['FRONTEND_URI']

        return render_template('passkey_login.html', project_id=project_id, frontend_uri=frontend_uri)
    else:
        flash('Passkey authentication is not enabled.')
        return redirect(url_for('auth.login'))


@auth.route('/passkey_login_post')
def login_passkey_post():

    auth_user = get_authenticated_user_from_cookie()
    if auth_user:
        email_identifiers = sdk.identifiers.list_all_emails_by_user_id(user_id=auth_user.user_id)

The variable sdk does not seem to be defined in case corbado_enabled on line 28 is False. Are you sure this can never be the case?

        email = email_identifiers[0].value
    else:
        # use more sophisticated error handling in production
        raise Unauthorized()

    user = User.query.filter_by(email=email).first()

    # check if the user actually exists
    # take the user-supplied password, hash it, and compare it to the hashed password in the database
    if not user:
        flash('Please check your login details and try again.')
        return redirect(url_for('auth.login'))  # if the user doesn't exist or password is wrong, reload the page

    # fix for no admin user to make current user an admin
    user_test = User.query.filter_by(admin=True).first()
    if not user_test:
        user.admin = 1
        db.session.commit()

    # ensure there's at least one global admin in the system
    global_admin_test = User.query.filter_by(is_global_admin=True).first()
    if not global_admin_test:
        # Set the first admin user to be a global admin
        first_admin = User.query.filter_by(admin=True).order_by(User.id).first()
        if first_admin:
            first_admin.is_global_admin = True
            db.session.commit()

    # if the above check passes, then we know the user has the right credentials
    login_user(user, remember=True)
    session['name'] = user.name
    session['email'] = user.email

    return redirect(url_for('main.index'))


def get_authenticated_user_from_cookie() -> UserEntity | None:
    session_token = request.cookies.get('cbo_session_token')
    if not session_token:
        return None
    try:
        return sdk.sessions.validate_token(session_token)

The variable sdk does not seem to be defined in case corbado_enabled on line 28 is False. Are you sure this can never be the case?

    except:
        raise Unauthorized()