SepiaImages

Complexity

Total Complexity

3

Size/Duplication

Total Lines	35
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes	2
Bugs	0	Features	1

2 Methods

Rating	Name	Duplication	Size	Complexity
A	Sepia()	0	4	1
A	generateSepia()	0	19	2

<?php

/**
 * Class SepiaImages
 * for generating sepia toned images. Use $Image.Sepia in your template.
 */
class SepiaImages  extends DataExtension

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

Expected 1 space after class name; 2 found

Expected 1 space before extends keyword; 2 found

{

    private static $brightness = -30;

The property $brightness is not used and could be removed.

    private static $colorize_red = 90;

The property $colorize_red is not used and could be removed.

    private static $colorize_green = 55;

The property $colorize_green is not used and could be removed.

    private static $colorize_blue = 30;

The property $colorize_blue is not used and could be removed.

    public function Sepia()

The return type could not be reliably inferred; please add a @return annotation.

    {
        return $this->owner->getFormattedImage('Sepia');
    }

    public function generateSepia($gd)
    {
        $imageResource= $gd->getImageResource();
        if (!$imageResource) {
            return;
        }

        $conf = Config::inst()->forClass('SepiaImages');

        imagefilter($imageResource, IMG_FILTER_GRAYSCALE);
        imagefilter($imageResource, IMG_FILTER_BRIGHTNESS, $conf->get('brightness'));
        imagefilter($imageResource, IMG_FILTER_COLORIZE,
            $conf->get('colorize_red'), $conf->get('colorize_green'), $conf->get('colorize_blue'));

        $output = clone $gd;
        $output->setImageResource($imageResource);

        return $output;
    }
}