HomePage_Controller

Complexity

Total Complexity

2

Size/Duplication

Total Lines	13
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	1

Importance

Changes	2
Bugs	0	Features	0

1 Method

Rating	Name	Duplication	Size	Complexity
A	getActiveHomePageBlocks()	0	10	2

<?php

/**
 * StartGeneratedWithDataObjectAnnotator
 * @method DataList|HomePageBlock[] HomePageBlocks
 * EndGeneratedWithDataObjectAnnotator
 */
class HomePage extends Page

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{

    private static $has_many = [

The property $has_many is not used and could be removed.

        'HomePageBlocks' => 'HomePageBlock'
    ];

    public function getCMSFields()

The return type could not be reliably inferred; please add a @return annotation.

    {
        $self =& $this;
        $this->beforeUpdateCMSFields(function (FieldList $fields) use ($self) {

            /**
             * @var GridFieldConfig_RecordEditor $conf
             */
            $conf = GridFieldConfig_RecordEditor::create();

            $conf->addComponent(new GridFieldSortableRows('SortOrder'));

            $fields->addFieldToTab(
                "Root." . _t('HomePage.BlockTabName', 'Blocks'),
                Gridfield::create(
                    'HomePageBlocks',
                    _t('HomePage.Block', 'Blocks'),
                    $this->HomePageBlocks(),
                    $conf
                )
            );
        });

        $fields = parent::getCMSFields();

        return $fields;
    }
}

class HomePage_Controller extends Page_Controller

PSR1 recommends that each class should be in its own file to aid autoloaders.

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    public function getActiveHomePageBlocks()

The return type could not be reliably inferred; please add a @return annotation.

    {
        $blocks = $this->data()->HomePageBlocks();

        if (Versioned::current_stage() === 'Live') {
            $blocks = $blocks->filter('IsActive', 1);
        }

        return $blocks;
    }
}