ExplanationPage_Controller

Complexity

Total Complexity

4

Size/Duplication

Total Lines	28
Duplicated Lines	28.57 %

Coupling/Cohesion

Components	1
Dependencies	5

Importance

Changes	2
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	viewItem()	8	8	2
A	getItem()	0	4	1
A	getItems()	0	4	1

<?php

class ExplanationPage extends Page

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{

    public static $has_many = array(
        'Explanations' => 'Explanation'
    );


    public function getCMSFields()

The return type could not be reliably inferred; please add a @return annotation.

This method seems to be duplicated in your project.

    {
        $fields = parent::getCMSFields();

        $conf = GridFieldConfig_RecordEditor::create();
        $grid = GridField::create('Explanations', $this->fieldLabel('Explanations'), $this->Explanations(), $conf);
        $tabTitle = $this->fieldLabel('Explanations');
        $fields->addFieldsToTab('Root.' . $tabTitle, $grid);

        return $fields;
    }
}

class ExplanationPage_Controller extends AbbreviationPage_Controller

PSR1 recommends that each class should be in its own file to aid autoloaders.

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    private static $url_handlers = array(

Consider using a different property name as you override a private property of the parent class.

The property $url_handlers is not used and could be removed.

        '$Item!' => 'viewItem'
    );
    private static $allowed_actions = array(

Consider using a different property name as you override a private property of the parent class.

The property $allowed_actions is not used and could be removed.

        'viewItem'
    );

    public function viewItem()

This method seems to be duplicated in your project.

    {
        $item = $this->getItem($this->request->param('Item'));
        if (!$item) {
            $this->httpError(404);
        }
        return $this->customise(array('Item' => $item))->renderWith(array('ExplanationPage_view', 'Page'));
    }

    public function getItem($slug)
    {
        return Explanation::get()->filter(array('URLSlug' => $slug))->first();
    }

    public function getItems()
    {
        return Explanation::get()->sort('Title');
    }
}