AbbreviationPage_Controller

Complexity

Total Complexity

10

Size/Duplication

Total Lines	63
Duplicated Lines	12.7 %

Coupling/Cohesion

Components	1
Dependencies	8

Importance

Changes	3
Bugs	0	Features	0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	index()	0	4	1
A	viewItem()	8	8	2
A	getItem()	0	4	1
A	getItems()	0	4	1
A	getGroupedItems()	0	4	1
B	getFirstLetterNavigation()	0	23	4

<?php

class AbbreviationPage extends Page

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{

    public static $has_many = array(
        'Abbreviations' => 'Abbreviation'
    );

    public function getCMSFields()

The return type could not be reliably inferred; please add a @return annotation.

This method seems to be duplicated in your project.

    {
        $fields = parent::getCMSFields();

        $conf = GridFieldConfig_RecordEditor::create();
        $grid = GridField::create('Abbreviations', $this->fieldLabel('Abbreviations'), $this->Abbreviations(), $conf);
        $tabTitle = $this->fieldLabel('Abbreviations');
        $fields->addFieldsToTab('Root.' . $tabTitle, $grid);

        return $fields;
    }

    /**
     * If you add <% loop $AdditionalBreadcrumbsAfter %> to your BreadcrumbsTemplate you can
     * @return ArrayList
     */
    public function getAdditionalBreadcrumbsAfter()
    {
        $pages = ArrayList::create();
        $currentController = Controller::curr();
        $slug = $currentController->request->param('Item');
        $item = ($slug && $currentController->hasMethod('getItem')) ? $currentController->getItem($slug) : false;
        if ($slug && $item) {
            $pages->push($item);
        }
        return $pages;
    }
}

class AbbreviationPage_Controller extends ContentController

PSR1 recommends that each class should be in its own file to aid autoloaders.

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{

    private static $url_handlers = array(

Consider using a different property name as you override a private property of the parent class.

The property $url_handlers is not used and could be removed.

        '$Item!' => 'viewItem'
    );
    private static $allowed_actions = array(

Consider using a different property name as you override a private property of the parent class.

The property $allowed_actions is not used and could be removed.

        'viewItem'
    );

    public function index()
    {
        return $this->renderWith(array('AbbreviationPage', 'Page'));
    }

    public function viewItem()

This method seems to be duplicated in your project.

    {
        $item = $this->getItem($this->request->param('Item'));
        if (!$item) {
            $this->httpError(404);
        }
        return $this->customise(array('Item' => $item))->renderWith(array('AbbreviationPage_view', 'Page'));
    }

    public function getItem($slug)

The return type could not be reliably inferred; please add a @return annotation.

    {
        return Abbreviation::get()->filter(array('URLSlug' => $slug))->first();
    }

    public function getItems()
    {
        return Abbreviation::get()->sort('Title');
    }

    public function getGroupedItems()
    {
        return GroupedList::create($this->getItems());
    }

    public function getFirstLetterNavigation()
    {
        $menu = array();
        foreach (range('A', 'Z') as $char) {
            $menu[$char] = ArrayData::create(array('Title' => $char));
        }

        foreach ($this->getGroupedItems()->GroupedBy('TitleFirstLetter') as $item) {
            $firstLetter = $item->TitleFirstLetter;

            if (array_key_exists($firstLetter, $menu)) {
                $menu[$firstLetter]->setField('hasItems', true);
            } else {
                $menu[$firstLetter] = ArrayData::create(
                    array('Title' => $firstLetter, 'hasItems' => true)
                );
            }
        }

        ksort($menu);

        return ArrayList::create($menu);
    }
}