CDNRewriteRequestFilter

Complexity

Total Complexity

14

Size/Duplication

Total Lines	127
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes	7
Bugs	2	Features	1

5 Methods

Rating	Name	Duplication	Size	Complexity
A	preRequest()	0	4	1
A	postRequest()	0	11	2
B	isEnabled()	0	8	5
A	isBackend()	0	5	3
A	replaceCDN()	0	23	3

<?php

class CDNRewriteRequestFilter implements RequestFilter

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{

    /**
     * Enable rewriting of asset urls
     * @var bool
     */
    private static $cdn_rewrite = false;

The property $cdn_rewrite is not used and could be removed.

    /**
     * The cdn domain incl. protocol
     * @var string
     */
    private static $cdn_domain = 'http://cdn.mysite.com';

The property $cdn_domain is not used and could be removed.

    /**
     * Enable rewrite in admin area
     * @var bool
     */
    private static $enable_in_backend = false;

The property $enable_in_backend is not used and could be removed.

    /**
     * Enable rewrite in dev mode
     * @var bool
     */
    private static $enable_in_dev = false;

The property $enable_in_dev is not used and could be removed.

    /**
     * should assets be rewritten?
     * @var bool
     */
    private static $rewrite_assets = true;

The property $rewrite_assets is not used and could be removed.

    /**
     * should themes also be rewritten?
     * @var bool
     */
    private static $rewrite_themes = false;

The property $rewrite_themes is not used and could be removed.

    /**
     * Filter executed before a request processes
     *
     * @param SS_HTTPRequest $request Request container object
     * @param Session $session Request session
     * @param DataModel $model Current DataModel
     * @return boolean Whether to continue processing other filters. Null or true will continue processing (optional)
     */
    public function preRequest(SS_HTTPRequest $request, Session $session, DataModel $model)
    {
        return true;
    }

    /**
     * Filter executed AFTER a request
     *
     * @param SS_HTTPRequest $request Request container object
     * @param SS_HTTPResponse $response Response output object
     * @param DataModel $model Current DataModel
     * @return boolean Whether to continue processing other filters. Null or true will continue processing (optional)
     */
    public function postRequest(SS_HTTPRequest $request, SS_HTTPResponse $response, DataModel $model)
    {
        if (!self::isEnabled()) {
            return true;
        }

        $body = $response->getBody();
        $response->setBody(self::replaceCDN($body));

        return true;
    }

    /**
     * Checks if cdn rewrite is enabled
     * @return bool
     */
    public static function isEnabled()
    {
        $general = Config::inst()->get('CDNRewriteRequestFilter', 'cdn_rewrite');
        $notDev = !Director::isDev() || Config::inst()->get('CDNRewriteRequestFilter', 'enable_in_dev');
        $notBackend = !self::isBackend() ||  Config::inst()->get('CDNRewriteRequestFilter', 'enable_in_backend');

        return $general && $notDev && $notBackend;
    }

    /**
     * Helper method to check if we're in backend (LeftAndMain) or frontend
     * Controller::curr() doesn't return anything, so i cannot check it...
     * @return bool
     */
    public static function isBackend()

isBackend uses the super-global variable $_GET which is generally not recommended.

    {
        $url = array_key_exists('url', $_GET) ? $_GET['url'] : '';
        return !Config::inst()->get('SSViewer', 'theme_enabled') || strpos($url, 'admin') === 1;
    }

    /**
     * replaces links to assets in src and href attributes to point to a given cdn domain
     *
     * @param $body
     * @return mixed|void
     */
    public static function replaceCDN($body)
    {
        $cdn = Config::inst()->get('CDNRewriteRequestFilter', 'cdn_domain');

        if (Config::inst()->get('CDNRewriteRequestFilter', 'rewrite_assets')) {
            $body = str_replace('src="assets/', 'src="' . $cdn . '/assets/', $body);
            $body = str_replace('src="/assets/', 'src="' . $cdn . '/assets/', $body);
            $body = str_replace('src=\"/assets/', 'src=\"' . $cdn . '/assets/', $body);

            $body = str_replace('href="/assets/', 'href="' . $cdn . '/assets/', $body);
            $body = str_replace(Director::absoluteBaseURL() . 'assets/', $cdn . '/assets/', $body);
        }

        if (Config::inst()->get('CDNRewriteRequestFilter', 'rewrite_themes')) {
            $body = str_replace('src="/themes/', 'src="' . $cdn . '/themes/', $body);
            $body = str_replace('src="' . Director::absoluteBaseURL() . 'themes/', 'src="' . $cdn . '/themes/', $body);

            $body = str_replace('href="/themes/', 'href="' . $cdn . '/themes/', $body);
            $body = str_replace('href="' . Director::absoluteBaseURL() . 'themes/', 'href="' . $cdn . '/themes/', $body);
        }

        return $body;
    }
}