UrlParser::parseSegments() - Code Metrics - Inspection of "Improving url parser. Providing better url manipul..." - weew/url - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 4cc0c1...9069dd )

by Maxim

created 2016-07-26 20:32 UTC

UrlParser::parseSegments() B

↳ Parent: Project

Complexity

Conditions	6
Paths	6

Size

Total Lines	35
Code Lines	26

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	35
rs	8.439
cc	6
eloc	26
nc	6
nop	1

<?php

namespace Weew\Url;

class UrlParser implements IUrlParser {
    /**
     * @param $string
     *
     * @return array
     */
    public function parse($string) {
        $segments = $this->parseSegments($string);
        $segments = array_extend($segments, $this->parseHost(array_get($segments, 'host')));
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

        return $this->replaceEmptyStringsWithNull($segments);
    }

    /**
     * @param $string
     *
     * @return array
     */
    public function parseHost($string) {
        $segments = [
            'tld' => null,
            'domain' => null,
            'subdomain' => null,
        ];

        $parts = explode('.', $string);

        if (count($parts) == 1) {
            $segments['domain'] = $parts[0];

            return $segments;
        }

        if (count($parts)) {
            $segments['tld'] = array_pop($parts);
        }

        if (count($parts)) {
            $segments['domain'] = array_pop($parts);
        }

        if (count($parts)) {
            $segments['subdomain'] = implode('.', $parts);
        }

        return $this->replaceEmptyStringsWithNull($segments);
    }

    /**
     * @param $string
     *
     * @return array
     */
    protected function parseSegments($string) {
        preg_match_all(
            '/^' .
            '((?P<protocol>.*):\/\/)?' .
            '(' .
                '(?P<username>.*?)' .
                '(:(?P<password>.*?)' .
            ')@)?' .
            '(?P<host>[^:\/\s]+)?' .
            '(:(?P<port>[^\/]*))?' .
            '(?P<path>[^#\?]*)?' .
            '(\?(?P<query>[^#]*))?' .
            '(#(?P<fragment>.*))?' .
            '$/',
            $string,
            $segments
        );

        foreach ($segments as $key => $value) {
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
            if (is_numeric($key)) {
                unset($segments[$key]);
            } else {
                $segments[$key] = array_pop($value);
            }
        }

        $host = array_get($segments, 'host');
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

        if ($host && $host !== 'localhost' && stripos($host, '.') === false) {
            $segments['path'] = '/' . $host . array_get($segments, 'path');
            $segments['host'] = null;
        }

        return $segments;
    }

    /**
     * @param $array
     *
     * @return array
     */
    protected function replaceEmptyStringsWithNull(array $array) {
        return array_map(function($item) {
            return ($item === '') ? null : $item;
        }, $array);
    }
}


1			<?php
2
3			namespace Weew\Url;
4
5			class UrlParser implements IUrlParser {
6			/**
7			* @param $string
8			*
9			* @return array
10			*/
11			public function parse($string) {
12			$segments = $this->parseSegments($string);
13			$segments = array_extend($segments, $this->parseHost(array_get($segments, 'host')));
			0 ignored issues – show Bug introduced 2016-07-26 20:35 UTC by Report Bug Copy Issue Report It seems like `$segments` can also be of type `null`; however, `array_get()` does only seem to accept `array`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
14
15			return $this->replaceEmptyStringsWithNull($segments);
16			}
17
18			/**
19			* @param $string
20			*
21			* @return array
22			*/
23			public function parseHost($string) {
24			$segments = [
25			'tld' => null,
26			'domain' => null,
27			'subdomain' => null,
28			];
29
30			$parts = explode('.', $string);
31
32			if (count($parts) == 1) {
33			$segments['domain'] = $parts[0];
34
35			return $segments;
36			}
37
38			if (count($parts)) {
39			$segments['tld'] = array_pop($parts);
40			}
41
42			if (count($parts)) {
43			$segments['domain'] = array_pop($parts);
44			}
45
46			if (count($parts)) {
47			$segments['subdomain'] = implode('.', $parts);
48			}
49
50			return $this->replaceEmptyStringsWithNull($segments);
51			}
52
53			/**
54			* @param $string
55			*
56			* @return array
57			*/
58			protected function parseSegments($string) {
59			preg_match_all(
60			'/^' .
61			'((?P<protocol>.*):\/\/)?' .
62			'(' .
63			'(?P<username>.*?)' .
64			'(:(?P<password>.*?)' .
65			')@)?' .
66			'(?P<host>[^:\/\s]+)?' .
67			'(:(?P<port>[^\/]*))?' .
68			'(?P<path>[^#\?]*)?' .
69			'(\?(?P<query>[^#]*))?' .
70			'(#(?P<fragment>.*))?' .
71			'$/',
72			$string,
73			$segments
74			);
75
76			foreach ($segments as $key => $value) {
			0 ignored issues – show Bug introduced 2016-07-26 20:35 UTC by Report Bug Copy Issue Report The expression `$segments` of type `null\|array<integer,array<integer,string>>` is not guaranteed to be traversable. How about adding an additional type check? There are different options of fixing this problem. If you want to be on the safe side, you can add an additional type-check: $collection = json_decode($data, true); if ( ! is_array($collection)) { throw new \RuntimeException('$collection must be an array.'); } foreach ($collection as $item) { /** ... / } If you are sure that the expression is traversable, you might want to add a doc comment cast* to improve IDE auto-completion and static analysis: /** @var array $collection / $collection = json_decode($data, true); foreach ($collection as $item) { /* .. / } Mark the issue as a false-positive*: Just hover the remove button, in the top-right corner of this issue for more options. Loading history...
77			if (is_numeric($key)) {
78			unset($segments[$key]);
79			} else {
80			$segments[$key] = array_pop($value);
81			}
82			}
83
84			$host = array_get($segments, 'host');
			0 ignored issues – show Bug introduced 2016-07-26 20:35 UTC by Report Bug Copy Issue Report It seems like `$segments` can also be of type `null`; however, `array_get()` does only seem to accept `array`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
85
86			if ($host && $host !== 'localhost' && stripos($host, '.') === false) {
87			$segments['path'] = '/' . $host . array_get($segments, 'path');
88			$segments['host'] = null;
89			}
90
91			return $segments;
92			}
93
94			/**
95			* @param $array
96			*
97			* @return array
98			*/
99			protected function replaceEmptyStringsWithNull(array $array) {
100			return array_map(function($item) {
101			return ($item === '') ? null : $item;
102			}, $array);
103			}
104			}
105

weew / url

Push — master ( 4cc0c1...9069dd )

UrlParser::parseSegments() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like