Issues in Collection.php (master) - Issues in master - weew/collections - Measure and Improve Code Quality continuously with Scrutinizer

Issues (2)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Weew/Collections/Collection.php (1 issue)

Labels

Duplication 1

Severity

Informational 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Weew\Collections;

use ArrayIterator;
use Weew\Contracts\IArrayable;

class Collection implements ICollection {
    /**
     * @var array
     */
    protected $items;

    /**
     * @param array $items
     */
    public function __construct(array $items = []) {
        $this->setItems($items);
    }

    /**
     * @return array
     */
    public function getItems() {
        return $this->items;
    }

    /**
     * @param array $items
     */
    public function setItems(array $items) {
        $this->items = [];

        foreach ($items as $item) {
            $this->add($item);
        }
    }

    /**
     * @param array $items
     */
    public function merge(array $items) {
        foreach ($items as $item) {
            $this->add($item);
        }
    }

    /**
     * @param ICollection $items
     */
    public function extend(ICollection $items) {
        $this->merge($items->getItems());
    }

    /**
     * @return int
     */
    public function count() {
        return count($this->items);
    }

    /**
     * @param $item
     */
    public function add($item) {
        $this->items[] = $item;
    }

    /**
     * @param null $default
     *
     * @return mixed
     */
    public function first($default = null) {
        return array_first($this->items, $default);
    }

    /**
     * @param null $default
     *
     * @return mixed
     */
    public function last($default = null) {
        return array_last($this->items, $default);
    }

    /**
     * @return array
     */
    public function toArray() {

        $items = [];

        foreach ($this->getItems() as $key => $value) {
            if ($value instanceof IArrayable) {
                $value = $value->toArray();
            }

            $items[$key] = $value;
        }

        return $items;
    }

    /**
     * @param mixed $key
     *
     * @return mixed
     */
    public function offsetGet($key) {
        return $this->items[$key];
    }

    /**
     * @param mixed $key
     * @param mixed $value
     */
    public function offsetSet($key, $value) {
        $this->items[$key] = $value;
    }

    /**
     * @param mixed $key
     *
     * @return bool
     */
    public function offsetExists($key) {
        return array_key_exists($key, $this->items);
    }

    /**
     * @param mixed $key
     */
    public function offsetUnset($key) {
        if ($this->offsetExists($key)) {
            unset($this->items[$key]);
        }
    }

    /**
     * @return ArrayIterator
     */
    public function getIterator() {
        return new ArrayIterator($this->items);
    }
}


1		<?php
2
3		namespace Weew\Collections;
4
5		use ArrayIterator;
6		use Weew\Contracts\IArrayable;
7
8		class Collection implements ICollection {
9		/**
10		* @var array
11		*/
12		protected $items;
13
14		/**
15		* @param array $items
16		*/
17		public function __construct(array $items = []) {
18		$this->setItems($items);
19		}
20
21		/**
22		* @return array
23		*/
24		public function getItems() {
25		return $this->items;
26		}
27
28		/**
29		* @param array $items
30		*/
31		public function setItems(array $items) {
32		$this->items = [];
33
34		foreach ($items as $item) {
35		$this->add($item);
36		}
37		}
38
39		/**
40		* @param array $items
41		*/
42		public function merge(array $items) {
43		foreach ($items as $item) {
44		$this->add($item);
45		}
46		}
47
48		/**
49		* @param ICollection $items
50		*/
51		public function extend(ICollection $items) {
52		$this->merge($items->getItems());
53		}
54
55		/**
56		* @return int
57		*/
58		public function count() {
59		return count($this->items);
60		}
61
62		/**
63		* @param $item
64		*/
65		public function add($item) {
66		$this->items[] = $item;
67		}
68
69		/**
70		* @param null $default
71		*
72		* @return mixed
73		*/
74		public function first($default = null) {
75		return array_first($this->items, $default);
76		}
77
78		/**
79		* @param null $default
80		*
81		* @return mixed
82		*/
83		public function last($default = null) {
84		return array_last($this->items, $default);
85		}
86
87		/**
88		* @return array
89		*/
90	View Code Duplication	public function toArray() {
		0 ignored issues – show Duplication introduced 2016-07-21 11:06 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
91		$items = [];
92
93		foreach ($this->getItems() as $key => $value) {
94		if ($value instanceof IArrayable) {
95		$value = $value->toArray();
96		}
97
98		$items[$key] = $value;
99		}
100
101		return $items;
102		}
103
104		/**
105		* @param mixed $key
106		*
107		* @return mixed
108		*/
109		public function offsetGet($key) {
110		return $this->items[$key];
111		}
112
113		/**
114		* @param mixed $key
115		* @param mixed $value
116		*/
117		public function offsetSet($key, $value) {
118		$this->items[$key] = $value;
119		}
120
121		/**
122		* @param mixed $key
123		*
124		* @return bool
125		*/
126		public function offsetExists($key) {
127		return array_key_exists($key, $this->items);
128		}
129
130		/**
131		* @param mixed $key
132		*/
133		public function offsetUnset($key) {
134		if ($this->offsetExists($key)) {
135		unset($this->items[$key]);
136		}
137		}
138
139		/**
140		* @return ArrayIterator
141		*/
142		public function getIterator() {
143		return new ArrayIterator($this->items);
144		}
145		}
146

weew / collections

Issues (2)

Security Analysis no request data

src/Weew/Collections/Collection.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like