BanklyCard::transactions() - Code Metrics - Inspection of "[Release] Preparing release for v1.11.0" - wedevBr/bankly-laravel - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#58)

by Rafael

created 2021-06-09 12:48 UTC

BanklyCard::transactions() A

↳ Parent: BanklyCard

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	11
rs	9.9
c	0
b	0
f	0
cc	1
nc	1
nop	5

<?php

namespace WeDevBr\Bankly;

use WeDevBr\Bankly\Auth\Auth;
use WeDevBr\Bankly\Traits\Rest;

/**
 * Class Card
 * @author Rafael Teixeira <[email protected]>
 * @package WeDevBr\Bankly
 */
class BanklyCard
{
    use Rest;

    /**
     * @param string $clientSecret
     * @param string $clientId
     * @return void

     */
    public function __construct($clientSecret = null, $clientId = null)
    {
        Auth::login()
            ->setClientId($clientId)
            ->setClientId($clientSecret);
    }

    /**
     * @param string $proxy
     * @param string $page
     * @param integer $pageSize
     * @param string $startDate
     * @param string $endDate
     * @return array
     */
    public function transactions(string $proxy, string $page, int $pageSize, string $startDate, string $endDate)
    {
        $query = [
            'page' => $page,
            'pageSize' => $pageSize,
            'startDate' => $startDate,
            'endDate' => $endDate
        ];

        return $this->get("/cards/{$proxy}/transactions", $query);
    }
}


1			<?php
2
3			namespace WeDevBr\Bankly;
4
5			use WeDevBr\Bankly\Auth\Auth;
6			use WeDevBr\Bankly\Traits\Rest;
7
8			/**
9			* Class Card
10			* @author Rafael Teixeira <[email protected]>
11			* @package WeDevBr\Bankly
12			*/
13			class BanklyCard
14			{
15			use Rest;
16
17			/**
18			* @param string $clientSecret
19			* @param string $clientId
20			* @return void
			0 ignored issues – show Comprehensibility Best Practice introduced 2021-06-09 12:51 UTC by Report Bug Copy Issue Report Adding a `@return` annotation to constructors is generally not recommended as a constructor does not have a meaningful return value. Adding a `@return` annotation to a constructor is not recommended, since a constructor does not have a meaningful return value. Please refer to the PHP core documentation on constructors. Loading history...
21			*/
22			public function __construct($clientSecret = null, $clientId = null)
23			{
24			Auth::login()
25			->setClientId($clientId)
26			->setClientId($clientSecret);
27			}
28
29			/**
30			* @param string $proxy
31			* @param string $page
32			* @param integer $pageSize
33			* @param string $startDate
34			* @param string $endDate
35			* @return array
36			*/
37			public function transactions(string $proxy, string $page, int $pageSize, string $startDate, string $endDate)
38			{
39			$query = [
40			'page' => $page,
41			'pageSize' => $pageSize,
42			'startDate' => $startDate,
43			'endDate' => $endDate
44			];
45
46			return $this->get("/cards/{$proxy}/transactions", $query);
47			}
48			}
49

wedevBr / bankly-laravel

Pull Request — master (#58)

BanklyCard::transactions() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like