Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
7 | class AddressingKeyValidator |
||
8 | { |
||
9 | /** @var AddressingKey */ |
||
10 | private $addressingKey; |
||
11 | |||
12 | /** |
||
13 | * @param AddressingKey $addressingKey |
||
14 | */ |
||
15 | public function __construct(AddressingKey $addressingKey) |
||
19 | |||
20 | /** |
||
21 | * Validate the attributes of the Addressing Key class |
||
22 | * |
||
23 | * @return void |
||
24 | */ |
||
25 | public function validate(): void |
||
30 | |||
31 | /** |
||
32 | * This validates a type of pix key |
||
33 | * |
||
34 | * @return void |
||
35 | * @throws InvalidArgumentException |
||
36 | */ |
||
37 | View Code Duplication | private function validateType() |
|
55 | |||
56 | /** |
||
57 | * This validates a key value |
||
58 | * |
||
59 | * @return void |
||
60 | * @throws InvalidArgumentException |
||
61 | */ |
||
62 | private function validateValue() |
||
69 | } |
||
70 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.