Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
17 | class BankValidator |
||
18 | { |
||
19 | /** @var Bank */ |
||
20 | private $bank; |
||
21 | |||
22 | /** |
||
23 | * @param Bank $bank |
||
24 | */ |
||
25 | public function __construct(Bank $bank) |
||
29 | |||
30 | /** |
||
31 | * Validate the attributes of the bank class |
||
32 | * |
||
33 | * @return void |
||
34 | */ |
||
35 | public function validate(): void |
||
41 | |||
42 | /** |
||
43 | * This validates a bank ispb |
||
44 | * |
||
45 | * @return void |
||
46 | * @throws \InvalidArgumentException |
||
47 | */ |
||
48 | private function validateIspb() |
||
55 | |||
56 | /** |
||
57 | * This validates a bank compe |
||
58 | * |
||
59 | * @return void |
||
60 | * @throws \InvalidArgumentException |
||
61 | */ |
||
62 | private function validateCompe() |
||
69 | |||
70 | /** |
||
71 | * This validates a bank name |
||
72 | * |
||
73 | * @return void |
||
74 | * @throws \InvalidArgumentException |
||
75 | */ |
||
76 | View Code Duplication | private function validateName() |
|
83 | } |
||
84 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.