EventPage::getComments() - Code Metrics - webuni/srazy-api-client - Measure and Improve Code Quality continuously with Scrutinizer

EventPage::getComments() B
last analyzed 2016-04-25 07:13 UTC

↳ Parent: EventPage

Complexity

Conditions	2
Paths	1

Size

Total Lines	29
Code Lines	19

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	29
rs	8.8571
cc	2
eloc	19
nc	1
nop	1

<?php

/*
 * This is part of the webuni/srazy-api-client.
 *
 * (c) Martin Hasoň <[email protected]>
 * (c) Webuni s.r.o. <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Webuni\Srazy\Page;

use Doctrine\Common\Collections\ArrayCollection;
use Webuni\Srazy\Crawler;
use Webuni\Srazy\Model\Comment;
use Webuni\Srazy\Model\Event;
use Webuni\Srazy\Model\Poll;
use Webuni\Srazy\Model\Series;
use Webuni\Srazy\Model\Session;
use Webuni\Srazy\Model\User;

class EventPage extends AbstractPage
{
    public function getSeries()

    {
        $uri = $this->crawler->getUri();

        $series = $this->client->model(Series::class, $uri);
        $series->setUri($uri);
        $series->setName(trim($this->crawler->filter('h1.event-title')->text()));
        $series->setDescription(trim($this->crawler->filter('.event-header .event-desc-inner')->html()));

        return $series;
    }

    public function getEvent()
    {
        $uri = $this->crawler->getUri();
        /* @var $event Event */
        $event = $this->client->model(Event::class, $uri);

        $name = $this->crawler->filter('h2.date-title');
        if (!count($name)) {
            $name = $this->crawler->filter('h1.event-title');
        }

        $startNode = $this->crawler->filter('time.dtstart');
        $placeNode = $this->crawler->filter('.event-location-name');

        if (!$startNode->isEmpty()) {
            $event->setStart(new \DateTime($startNode->attr('datetime'), new \DateTimeZone('Europe/Prague')));
        }

        if (!$placeNode->isEmpty()) {
            $event->setLocation($placeNode->croppedText());
            $event->setMapUrl($this->crawler->filter('.pull-left h3.event-dateplace a')->link()->getUri());
            $event->setAddress($this->crawler->filter('span[itemprop="address"]')->text());
        }

        $event->setName($name->text());

        $description = '';
        /* @var $node \DOMElement */
        foreach ($this->crawler->filter('#snippet--attending ~ hr')->nextAll() as $node) {
            if ('hr' === $node->nodeName) {
                break;
            }

            $description .= $node->ownerDocument->saveHTML($node);
        }

        $event->setDescription($description);
        $event->setSessions($this->getSessions($event));
        $event->setPolls($this->getPolls($event));
        $event->setComments($this->getComments($event));

        return $event;
    }

    public function getSessions(Event $event)
    {
        $sessions = new ArrayCollection();

        $this->crawler->filter('#snippet--program dt')->each(function (Crawler $dt) use ($sessions, $event) {
            $session = new Session();
            $session->setEvent($event);

            $time = new \DateTime($dt->text(), new \DateTimeZone('Europe/Prague'));
            $date = clone $event->getStart();
            $date->setTime($time->format('H'), $time->format('i'), $time->format('s'));

            $session->setStart($date);
            if ($previousSession = $sessions->last()) {
                $previousSession->setStop($date);
            }

            $sessions->add($session);
        });

        $this->crawler->filter('#snippet--program dd')->each(function (Crawler $dd, $i) use ($sessions) {
            $session = $sessions[$i];
            if (preg_match('/program-type-([^ ]+)/', $dd->attr('class'), $matches)) {
                $session->setType($matches[1]);
            }

            $title = $dd->filter('.program-title');
            $speaker = $dd->filter('.program-speaker');
            $description = $dd->filter('.program-desc');

            if (count($title)) {
                $session->setTitle(trim($title->text()));
            }
            if (count($speaker)) {
                $session->setSpeaker(trim($speaker->text()));
            }
            if (count($description)) {
                $session->setDescription(trim($description->text()));
            }
        });

        return $sessions;
    }

    public function getPolls($event)
    {
        $polls = $this->crawler->filter('.poll')->each(function (Crawler $node) use ($event) {
            $poll = new Poll();
            $poll->setEvent($event);
            $poll->setName(trim($node->filter('.pollName')->text()));
            $data = $node->filter('.pollRow')->each(function ($node) {
                return [
                    trim($node->filter('.pollRowText')->text()),
                    trim($node->filter('.progress')->text()),
                ];
            });
            $poll->setChoices(array_combine(array_column($data, 0), array_column($data, 1)));

            return $poll;
        });

        return new ArrayCollection($polls);
    }

    public function getComments($event)
    {
        $comments = $this->crawler->filter('.comments .comment')->each(function (Crawler $node) use ($event) {
            $date = trim($node->filter('.comment-date')->text());
            $date = \DateTime::createFromFormat('d. m. Y v H:i', $date, new \DateTimeZone('Europe/Prague'));

            $authorNode = $node->filter('.comment-name');
            $authorUri = $authorNode->link()->getUri();

            $author = $this->client->model(User::class, $authorUri);
            $author->setUri($authorUri);
            $author->setName(trim($authorNode->text()));

            $text = '';
            if (preg_match('/<\\/b>:(.+?)<p class="comment-footer/is', $node->filter('.comment-bubble')->html(), $matches)) {
                $text = trim($matches[1]);
            }

            $comment = new Comment();
            $comment->setEvent($event);
            $comment->setDate($date);
<?php

function getDate($date)
{
    if ($date !== null) {
        return new DateTime($date);
    }

    return false;
}
            $comment->setAuthor($author);
            $comment->setText($text);

            return $comment;
        });

        return new ArrayCollection(array_reverse($comments));
    }
}


1		<?php
2
3		/*
4		* This is part of the webuni/srazy-api-client.
5		*
6		* (c) Martin Hasoň <[email protected]>
7		* (c) Webuni s.r.o. <[email protected]>
8		*
9		* For the full copyright and license information, please view the LICENSE
10		* file that was distributed with this source code.
11		*/
12
13		namespace Webuni\Srazy\Page;
14
15		use Doctrine\Common\Collections\ArrayCollection;
16		use Webuni\Srazy\Crawler;
17		use Webuni\Srazy\Model\Comment;
18		use Webuni\Srazy\Model\Event;
19		use Webuni\Srazy\Model\Poll;
20		use Webuni\Srazy\Model\Series;
21		use Webuni\Srazy\Model\Session;
22		use Webuni\Srazy\Model\User;
23
24		class EventPage extends AbstractPage
25		{
26	View Code Duplication	public function getSeries()
		0 ignored issues – show Duplication introduced 2016-03-22 09:29 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
27		{
28		$uri = $this->crawler->getUri();
29
30		$series = $this->client->model(Series::class, $uri);
31		$series->setUri($uri);
32		$series->setName(trim($this->crawler->filter('h1.event-title')->text()));
33		$series->setDescription(trim($this->crawler->filter('.event-header .event-desc-inner')->html()));
34
35		return $series;
36		}
37
38		public function getEvent()
39		{
40		$uri = $this->crawler->getUri();
41		/* @var $event Event */
42		$event = $this->client->model(Event::class, $uri);
43
44		$name = $this->crawler->filter('h2.date-title');
45		if (!count($name)) {
46		$name = $this->crawler->filter('h1.event-title');
47		}
48
49		$startNode = $this->crawler->filter('time.dtstart');
50		$placeNode = $this->crawler->filter('.event-location-name');
51
52		if (!$startNode->isEmpty()) {
53		$event->setStart(new \DateTime($startNode->attr('datetime'), new \DateTimeZone('Europe/Prague')));
54		}
55
56		if (!$placeNode->isEmpty()) {
57		$event->setLocation($placeNode->croppedText());
58		$event->setMapUrl($this->crawler->filter('.pull-left h3.event-dateplace a')->link()->getUri());
59		$event->setAddress($this->crawler->filter('span[itemprop="address"]')->text());
60		}
61
62		$event->setName($name->text());
63
64		$description = '';
65		/* @var $node \DOMElement */
66		foreach ($this->crawler->filter('#snippet--attending ~ hr')->nextAll() as $node) {
67		if ('hr' === $node->nodeName) {
68		break;
69		}
70
71		$description .= $node->ownerDocument->saveHTML($node);
72		}
73
74		$event->setDescription($description);
75		$event->setSessions($this->getSessions($event));
76		$event->setPolls($this->getPolls($event));
77		$event->setComments($this->getComments($event));
78
79		return $event;
80		}
81
82		public function getSessions(Event $event)
83		{
84		$sessions = new ArrayCollection();
85
86		$this->crawler->filter('#snippet--program dt')->each(function (Crawler $dt) use ($sessions, $event) {
87		$session = new Session();
88		$session->setEvent($event);
89
90		$time = new \DateTime($dt->text(), new \DateTimeZone('Europe/Prague'));
91		$date = clone $event->getStart();
92		$date->setTime($time->format('H'), $time->format('i'), $time->format('s'));
93
94		$session->setStart($date);
95		if ($previousSession = $sessions->last()) {
96		$previousSession->setStop($date);
97		}
98
99		$sessions->add($session);
100		});
101
102		$this->crawler->filter('#snippet--program dd')->each(function (Crawler $dd, $i) use ($sessions) {
103		$session = $sessions[$i];
104		if (preg_match('/program-type-([^ ]+)/', $dd->attr('class'), $matches)) {
105		$session->setType($matches[1]);
106		}
107
108		$title = $dd->filter('.program-title');
109		$speaker = $dd->filter('.program-speaker');
110		$description = $dd->filter('.program-desc');
111
112		if (count($title)) {
113		$session->setTitle(trim($title->text()));
114		}
115		if (count($speaker)) {
116		$session->setSpeaker(trim($speaker->text()));
117		}
118		if (count($description)) {
119		$session->setDescription(trim($description->text()));
120		}
121		});
122
123		return $sessions;
124		}
125
126		public function getPolls($event)
127		{
128		$polls = $this->crawler->filter('.poll')->each(function (Crawler $node) use ($event) {
129		$poll = new Poll();
130		$poll->setEvent($event);
131		$poll->setName(trim($node->filter('.pollName')->text()));
132		$data = $node->filter('.pollRow')->each(function ($node) {
133		return [
134		trim($node->filter('.pollRowText')->text()),
135		trim($node->filter('.progress')->text()),
136		];
137		});
138		$poll->setChoices(array_combine(array_column($data, 0), array_column($data, 1)));
139
140		return $poll;
141		});
142
143		return new ArrayCollection($polls);
144		}
145
146		public function getComments($event)
147		{
148		$comments = $this->crawler->filter('.comments .comment')->each(function (Crawler $node) use ($event) {
149		$date = trim($node->filter('.comment-date')->text());
150		$date = \DateTime::createFromFormat('d. m. Y v H:i', $date, new \DateTimeZone('Europe/Prague'));
151
152		$authorNode = $node->filter('.comment-name');
153		$authorUri = $authorNode->link()->getUri();
154
155		$author = $this->client->model(User::class, $authorUri);
156		$author->setUri($authorUri);
157		$author->setName(trim($authorNode->text()));
158
159		$text = '';
160		if (preg_match('/<\\/b>:(.+?)<p class="comment-footer/is', $node->filter('.comment-bubble')->html(), $matches)) {
161		$text = trim($matches[1]);
162		}
163
164		$comment = new Comment();
165		$comment->setEvent($event);
166		$comment->setDate($date);
		0 ignored issues – show Security Bug introduced 2016-03-22 09:29 UTC by Report Bug Copy Issue Report It seems like `$date` defined by `\DateTime::createFromFor...eZone('Europe/Prague'))` on line `150` can also be of type `false`; however, `Webuni\Srazy\Model\Comment::setDate()` does only seem to accept `object<DateTime>`, did you maybe forget to handle an error condition? This check looks for type mismatches where the missing type is `false`. This is usually indicative of an error condtion. Consider the follow example <?php function getDate($date) { if ($date !== null) { return new DateTime($date); } return false; } This function either returns a new `DateTime` object or false, if there was an error. This is a typical pattern in PHP programming to show that an error has occurred without raising an exception. The calling code should check for this returned `false` before passing on the value to another function or method that may not be able to handle a `false`. Loading history...
167		$comment->setAuthor($author);
168		$comment->setText($text);
169
170		return $comment;
171		});
172
173		return new ArrayCollection(array_reverse($comments));
174		}
175		}
176

webuni / srazy-api-client

EventPage::getComments() B last analyzed 2016-04-25 07:13 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

EventPage::getComments() B
last analyzed 2016-04-25 07:13 UTC