TableParser::parse() - Code Metrics - Inspection of "Add support for table caption (MultiMarkdown)" - webuni/commonmark-table-extension - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( e1e275...3d6629 )

by Martin

created 2016-07-14 21:20 UTC

TableParser::parse() C

↳ Parent: TableParser

Complexity

Conditions	10
Paths	6

Size

Total Lines	61
Code Lines	35

Duplication

Lines	0
Ratio	0 %

Importance

Changes	4
Bugs	0	Features	1

Metric	Value
c	4
b	0
f	1
dl	0
loc	61
rs	6.4757
cc	10
eloc	35
nc	6
nop	2

How to fix Long Method Complexity

<?php

/*
 * This is part of the webuni/commonmark-table-extension package.
 *
 * (c) Martin Hasoň <[email protected]>
 * (c) Webuni s.r.o. <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Webuni\CommonMark\TableExtension;

use League\CommonMark\Block\Element\Paragraph;
use League\CommonMark\Block\Parser\AbstractBlockParser;
use League\CommonMark\ContextInterface;
use League\CommonMark\Cursor;
use League\CommonMark\Util\RegexHelper;

class TableParser extends AbstractBlockParser
{
    const REGEXP_DEFINITION = '/(?: *(:?) *-+ *(:?) *)+(?=\||$)/';
    const REGEXP_CELLS = '/(?:`[^`]*`|\\\\\\\\|\\\\\||[^|`\\\\]+)+(?=\||$)/';
    const REGEXP_CAPTION = '/^\[(.+?)\](?:\[(.+)\])?\s*$/';

    public function parse(ContextInterface $context, Cursor $cursor)
    {
        $container = $context->getContainer();

        if (!$container instanceof Paragraph) {
            return false;
        }

        $lines = $container->getStrings();
        if (count($lines) < 1) {
            return false;
        }

        $match = RegexHelper::matchAll(self::REGEXP_DEFINITION, $cursor->getLine(), $cursor->getFirstNonSpacePosition());
        if (null === $match) {
            return false;
        }

        $columns = $this->parseColumns($match);
        $head = $this->parseRow(trim(array_pop($lines)), $columns, TableCell::TYPE_HEAD);
        if (null === $head) {
            return false;
        }

        $table = new Table(function (Cursor $cursor) use (&$table, $columns) {
            $row = $this->parseRow($cursor->getLine(), $columns);
            if (null === $row) {
                if (null !== $table->getCaption()) {
                    return false;
                }

                if (null !== ($caption = $this->parseCaption($cursor->getLine()))) {
                    $table->setCaption($caption);

                    return true;
                }

                return false;
            }

            $table->getBody()->appendChild($row);

            return true;
        });

        $table->getHead()->appendChild($head);

        if (count($lines) >= 1) {
            $paragraph = new Paragraph();
            foreach ($lines as $line) {
                $paragraph->addLine($line);
            }

            $context->replaceContainerBlock($paragraph);
            $context->addBlock($table);
        } else {
            $context->replaceContainerBlock($table);
        }

        return true;
    }

    private function parseColumns(array $match)
    {
        $columns = [];
        foreach ((array) $match[0] as $i => $column) {
            if (isset($match[1][$i]) && $match[1][$i] && isset($match[2][$i]) && $match[2][$i]) {
                $columns[] = TableCell::ALIGN_CENTER;
            } elseif (isset($match[1][$i]) && $match[1][$i]) {
                $columns[] = TableCell::ALIGN_LEFT;
            } elseif (isset($match[2][$i]) && $match[2][$i]) {
                $columns[] = TableCell::ALIGN_RIGHT;
            } else {
                $columns[] = null;
            }
        }

        return $columns;
    }

    private function parseRow($line, array $columns, $type = TableCell::TYPE_BODY)
    {
        $cells = RegexHelper::matchAll(self::REGEXP_CELLS, $line);
        if (null === $cells || !is_array($cells[0])) {
            return;
        }

        $row = new TableRow();
        foreach ($cells[0] as $i => $cell) {
            $row->appendChild(new TableCell(trim($cell), $type, isset($columns[$i]) ? $columns[$i] : null));
        }

        for ($j = count($columns) - 1; $j > $i; --$j) {
foreach ($a as $b) {
}

// $b is defined here only if $a has elements, for example if $a is array()
// then $b would not be defined here. To avoid that, we recommend to set a
// default value for $b.


// Better
$b = 0; // or whatever default makes sense in your context
foreach ($a as $b) {
}

// $b is now guaranteed to be defined here.
            $row->appendChild(new TableCell('', $type, null));
        }

        return $row;
    }

    private function parseCaption($line)
    {
        $caption = RegexHelper::matchAll(self::REGEXP_CAPTION, $line);

        if (null === $caption) {
            return null;
        }

        return new TableCaption($caption[1], $caption[2]);
    }
}


1			<?php
2
3			/*
4			* This is part of the webuni/commonmark-table-extension package.
5			*
6			* (c) Martin Hasoň <[email protected]>
7			* (c) Webuni s.r.o. <[email protected]>
8			*
9			* For the full copyright and license information, please view the LICENSE
10			* file that was distributed with this source code.
11			*/
12
13			namespace Webuni\CommonMark\TableExtension;
14
15			use League\CommonMark\Block\Element\Paragraph;
16			use League\CommonMark\Block\Parser\AbstractBlockParser;
17			use League\CommonMark\ContextInterface;
18			use League\CommonMark\Cursor;
19			use League\CommonMark\Util\RegexHelper;
20
21			class TableParser extends AbstractBlockParser
22			{
23			const REGEXP_DEFINITION = '/(?: (:?) -+ (:?) )+(?=\\|\|$)/';
24			const REGEXP_CELLS = '/(?:`[^`]*`\|\\\\\\\\\|\\\\\\|\|[^\|`\\\\]+)+(?=\\|\|$)/';
25			const REGEXP_CAPTION = '/^\[(.+?)\](?:\[(.+)\])?\s*$/';
26
27			public function parse(ContextInterface $context, Cursor $cursor)
28			{
29			$container = $context->getContainer();
30
31			if (!$container instanceof Paragraph) {
32			return false;
33			}
34
35			$lines = $container->getStrings();
36			if (count($lines) < 1) {
37			return false;
38			}
39
40			$match = RegexHelper::matchAll(self::REGEXP_DEFINITION, $cursor->getLine(), $cursor->getFirstNonSpacePosition());
41			if (null === $match) {
42			return false;
43			}
44
45			$columns = $this->parseColumns($match);
46			$head = $this->parseRow(trim(array_pop($lines)), $columns, TableCell::TYPE_HEAD);
47			if (null === $head) {
48			return false;
49			}
50
51			$table = new Table(function (Cursor $cursor) use (&$table, $columns) {
52			$row = $this->parseRow($cursor->getLine(), $columns);
53			if (null === $row) {
54			if (null !== $table->getCaption()) {
55			return false;
56			}
57
58			if (null !== ($caption = $this->parseCaption($cursor->getLine()))) {
59			$table->setCaption($caption);
60
61			return true;
62			}
63
64			return false;
65			}
66
67			$table->getBody()->appendChild($row);
68
69			return true;
70			});
71
72			$table->getHead()->appendChild($head);
73
74			if (count($lines) >= 1) {
75			$paragraph = new Paragraph();
76			foreach ($lines as $line) {
77			$paragraph->addLine($line);
78			}
79
80			$context->replaceContainerBlock($paragraph);
81			$context->addBlock($table);
82			} else {
83			$context->replaceContainerBlock($table);
84			}
85
86			return true;
87			}
88
89			private function parseColumns(array $match)
90			{
91			$columns = [];
92			foreach ((array) $match[0] as $i => $column) {
93			if (isset($match[1][$i]) && $match[1][$i] && isset($match[2][$i]) && $match[2][$i]) {
94			$columns[] = TableCell::ALIGN_CENTER;
95			} elseif (isset($match[1][$i]) && $match[1][$i]) {
96			$columns[] = TableCell::ALIGN_LEFT;
97			} elseif (isset($match[2][$i]) && $match[2][$i]) {
98			$columns[] = TableCell::ALIGN_RIGHT;
99			} else {
100			$columns[] = null;
101			}
102			}
103
104			return $columns;
105			}
106
107			private function parseRow($line, array $columns, $type = TableCell::TYPE_BODY)
108			{
109			$cells = RegexHelper::matchAll(self::REGEXP_CELLS, $line);
110			if (null === $cells \|\| !is_array($cells[0])) {
111			return;
112			}
113
114			$row = new TableRow();
115			foreach ($cells[0] as $i => $cell) {
116			$row->appendChild(new TableCell(trim($cell), $type, isset($columns[$i]) ? $columns[$i] : null));
117			}
118
119			for ($j = count($columns) - 1; $j > $i; --$j) {
			0 ignored issues – show Bug introduced 2016-07-14 15:00 UTC by Report Bug Copy Issue Report The variable `$i` seems to be defined by a `foreach` iteration on line `115`. Are you sure the iterator is never empty, otherwise this variable is not defined? It seems like you are relying on a variable being defined by an iteration: foreach ($a as $b) { } // $b is defined here only if $a has elements, for example if $a is array() // then $b would not be defined here. To avoid that, we recommend to set a // default value for $b. // Better $b = 0; // or whatever default makes sense in your context foreach ($a as $b) { } // $b is now guaranteed to be defined here. Loading history...
120			$row->appendChild(new TableCell('', $type, null));
121			}
122
123			return $row;
124			}
125
126			private function parseCaption($line)
127			{
128			$caption = RegexHelper::matchAll(self::REGEXP_CAPTION, $line);
129
130			if (null === $caption) {
131			return null;
132			}
133
134			return new TableCaption($caption[1], $caption[2]);
135			}
136			}
137

webuni / commonmark-table-extension

Push — master ( e1e275...3d6629 )

TableParser::parse() C

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like