TableCellRenderer::render() - Code Metrics - Inspection of "Feature/html5 head align" - webuni/commonmark-table-extension - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#11)

unknown

created 2017-06-04 08:07 UTC

TableCellRenderer::render() B

↳ Parent: TableCellRenderer

Complexity

Conditions	5
Paths	7

Size

Total Lines	21
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	9
CRAP Score	5.1502

Importance

Changes

Metric	Value
dl	0
loc	21
ccs	9
cts	11
cp	0.8182
rs	8.7624
c	0
b	0
f	0
cc	5
eloc	12
nc	7
nop	3
crap	5.1502

<?php

/*
 * This is part of the webuni/commonmark-table-extension package.
 *
 * (c) Martin Hasoň <[email protected]>
 * (c) Webuni s.r.o. <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Webuni\CommonMark\TableExtension;

use League\CommonMark\Block\Element\AbstractBlock;
use League\CommonMark\Block\Renderer\BlockRendererInterface;
use League\CommonMark\ElementRendererInterface;
use League\CommonMark\HtmlElement;

class TableCellRenderer implements BlockRendererInterface
{
    public function render(AbstractBlock $block, ElementRendererInterface $htmlRenderer, $inTightList = false)
    {
        if (!($block instanceof TableCell)) {
            throw new \InvalidArgumentException('Incompatible block type: '.get_class($block));
        }

        $attrs = [];
        foreach ($block->getData('attributes', []) as $key => $value) {
            $attrs[$key] = $htmlRenderer->escape($value, true);
        }

        if ($block->align) {
            if ($block->type == TableCell::TYPE_HEAD) {
                $attrs['style'] = "text-align: $block->align";
            } else {
                $attrs['align'] = $block->align;
            }
        }

        return new HtmlElement($block->type, $attrs, $htmlRenderer->renderInlines($block->children()));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }
}


1		<?php
2
3		/*
4		* This is part of the webuni/commonmark-table-extension package.
5		*
6		* (c) Martin Hasoň <[email protected]>
7		* (c) Webuni s.r.o. <[email protected]>
8		*
9		* For the full copyright and license information, please view the LICENSE
10		* file that was distributed with this source code.
11		*/
12
13		namespace Webuni\CommonMark\TableExtension;
14
15		use League\CommonMark\Block\Element\AbstractBlock;
16		use League\CommonMark\Block\Renderer\BlockRendererInterface;
17		use League\CommonMark\ElementRendererInterface;
18		use League\CommonMark\HtmlElement;
19
20		class TableCellRenderer implements BlockRendererInterface
21		{
22	16	public function render(AbstractBlock $block, ElementRendererInterface $htmlRenderer, $inTightList = false)
23		{
24	16	if (!($block instanceof TableCell)) {
25		throw new \InvalidArgumentException('Incompatible block type: '.get_class($block));
26		}
27
28	16	$attrs = [];
29	16	foreach ($block->getData('attributes', []) as $key => $value) {
30		$attrs[$key] = $htmlRenderer->escape($value, true);
31		}
32
33	16	if ($block->align) {
34	4	if ($block->type == TableCell::TYPE_HEAD) {
35	4	$attrs['style'] = "text-align: $block->align";
36		} else {
37	4	$attrs['align'] = $block->align;
38		}
39		}
40
41	16	return new HtmlElement($block->type, $attrs, $htmlRenderer->renderInlines($block->children()));
		0 ignored issues – show Documentation introduced 2016-01-14 22:58 UTC by Report Bug Copy Issue Report `$block->children()` is of type `array<integer,object<Lea...\CommonMark\Node\Node>>`, but the function expects a `array<integer,object<Lea...lement\AbstractInline>>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
42		}
43		}
44

webuni / commonmark-table-extension

Pull Request — master (#11)

TableCellRenderer::render() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like