TableCellRenderer::render() - Code Metrics - webuni/commonmark-table-extension - Measure and Improve Code Quality continuously with Scrutinizer

TableCellRenderer::render() A
last analyzed 2019-07-09 13:36 UTC

↳ Parent: TableCellRenderer

Complexity

Conditions	5
Paths	7

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	30

Importance

Changes

Metric	Value
dl	0
loc	17
ccs	0
cts	14
cp	0
rs	9.3888
c	0
b	0
f	0
cc	5
nc	7
nop	3
crap	30

<?php

declare(strict_types=1);

/*
 * This is part of the webuni/commonmark-table-extension package.
 *
 * (c) Martin Hasoň <[email protected]>
 * (c) Webuni s.r.o. <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Webuni\CommonMark\TableExtension;

use League\CommonMark\Block\Element\AbstractBlock;
use League\CommonMark\Block\Renderer\BlockRendererInterface;
use League\CommonMark\ElementRendererInterface;
use League\CommonMark\HtmlElement;
use League\CommonMark\Util\Xml;

class TableCellRenderer implements BlockRendererInterface
{
    public function render(AbstractBlock $block, ElementRendererInterface $htmlRenderer, bool $inTightList = false)
    {
        if (!$block instanceof TableCell) {
            throw new \InvalidArgumentException('Incompatible block type: '.get_class($block));
        }

        $attrs = [];
        foreach ($block->getData('attributes', []) as $key => $value) {
            $attrs[$key] = Xml::escape($value);
        }

        if ($block->align) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            $attrs['style'] = (isset($attrs['style']) ? $attrs['style'].' ' : '').'text-align: '.$block->align;
        }

        return new HtmlElement($block->type, $attrs, $htmlRenderer->renderInlines($block->children()));
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			/*
6			* This is part of the webuni/commonmark-table-extension package.
7			*
8			* (c) Martin Hasoň <[email protected]>
9			* (c) Webuni s.r.o. <[email protected]>
10			*
11			* For the full copyright and license information, please view the LICENSE
12			* file that was distributed with this source code.
13			*/
14
15			namespace Webuni\CommonMark\TableExtension;
16
17			use League\CommonMark\Block\Element\AbstractBlock;
18			use League\CommonMark\Block\Renderer\BlockRendererInterface;
19			use League\CommonMark\ElementRendererInterface;
20			use League\CommonMark\HtmlElement;
21			use League\CommonMark\Util\Xml;
22
23			class TableCellRenderer implements BlockRendererInterface
24			{
25			public function render(AbstractBlock $block, ElementRendererInterface $htmlRenderer, bool $inTightList = false)
26			{
27			if (!$block instanceof TableCell) {
28			throw new \InvalidArgumentException('Incompatible block type: '.get_class($block));
29			}
30
31			$attrs = [];
32			foreach ($block->getData('attributes', []) as $key => $value) {
33			$attrs[$key] = Xml::escape($value);
34			}
35
36			if ($block->align) {
			0 ignored issues – show Bug Best Practice introduced 2019-02-14 14:36 UTC by Report Bug Copy Issue Report The expression `$block->align` of type `null\|string` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
37			$attrs['style'] = (isset($attrs['style']) ? $attrs['style'].' ' : '').'text-align: '.$block->align;
38			}
39
40			return new HtmlElement($block->type, $attrs, $htmlRenderer->renderInlines($block->children()));
41			}
42			}
43

webuni / commonmark-table-extension

TableCellRenderer::render() A last analyzed 2019-07-09 13:36 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like

TableCellRenderer::render() A
last analyzed 2019-07-09 13:36 UTC