Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 13 | class FileInputStream extends InputStream |
||
| 14 | { |
||
| 15 | /** |
||
| 16 | * @var File ファイルオブジェクト |
||
| 17 | */ |
||
| 18 | protected $file; |
||
| 19 | |||
| 20 | /** |
||
| 21 | * constructor |
||
| 22 | * @param mixed $file ファイルオブジェクトまたはファイルパス |
||
| 23 | * @throws InvalidArgumentException |
||
| 24 | * @throws IOException |
||
| 25 | */ |
||
| 26 | public function __construct($file) |
||
| 43 | |||
| 44 | /** |
||
| 45 | * {@inheritdoc} |
||
| 46 | */ |
||
| 47 | public function isMarkSupported() |
||
| 51 | } |
||
| 52 |
It seems like the type of the argument is not accepted by the function/method which you are calling.
In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug.
We suggest to add an explicit type cast like in the following example: