InputStreamReaderTest - Code Metrics - Inspection of "パス、メソッド名修正" - webstream-framework/WebStream - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — feature/0.7.0 ( 38440f...02d6a4 )

by Ryuichi

created 2016-09-19 03:29 UTC

InputStreamReaderTest A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	142
Duplicated Lines	100 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes

Metric	Value
dl	142
loc	142
rs	10
c	0
b	0
f	0
wmc	10
lcom	1
cbo	3

10 Methods

Rating	Name	Duplication	Size	Complexity
A	okReadChar()	5	5	1
A	okReadLine()	7	7	1
A	okClose()	6	6	1
A	okSkip()	6	6	1
A	okOverSkipAndRead()	7	7	1
A	okFrontSkip()	7	7	1
A	okOverFrontSkip()	5	5	1
A	okReset()	7	7	1
A	okMarkAndReset()	8	8	1
A	ngInvalidLength()	6	6	1

How to fix Duplicated Code

<?php
namespace WebStream\IO\Test;

require_once dirname(__FILE__) . '/../InputStream.php';
require_once dirname(__FILE__) . '/../FileInputStream.php';
require_once dirname(__FILE__) . '/../StringInputStream.php';
require_once dirname(__FILE__) . '/../Reader/InputStreamReader.php';
require_once dirname(__FILE__) . '/../Test/Providers/InputStreamReaderProvider.php';
require_once dirname(__FILE__) . '/../Test/Modules/IOException.php';
require_once dirname(__FILE__) . '/../Test/Modules/InvalidArgumentException.php';

use WebStream\IO\Reader\InputStreamReader;
use WebStream\IO\Test\Providers\InputStreamReaderProvider;

/**
 * InputStreamReaderTest
 * @author Ryuichi TANAKA.
 * @since 2016/08/18
 * @version 0.7
 */
class InputStreamReaderTest extends \PHPUnit_Framework_TestCase

{
    use InputStreamReaderProvider;

    /**
     * 正常系
     * バイト単位で読み込みできること
     * EOFを超えるサイズの読み込み時は、ファイルの場合改行が含まれる
     * @test
     * @dataProvider readCharProvider
     */
    public function okReadChar($stream, $result, $byteLength)
    {
        $reader = new InputStreamReader($stream);
        $this->assertEquals($reader->read($byteLength), $result);
    }

    /**
     * 正常系
     * 行単位でデータが読み込めること
     * @test
     * @dataProvider readLineProvider
     */
    public function okReadLine($stream, $result1, $result2)
    {
        $reader = new InputStreamReader($stream);
        $this->assertEquals($reader->readLine(), $result1);
        $this->assertEquals($reader->readLine(), $result2);
        $this->assertEquals($reader->readLine(), null);
    }

    /**
     * 正常系
     * 入力ストリームをクローズできること
     * @test
     * @dataProvider closeProvider
     */
    public function okClose($stream)
    {
        $reader = new InputStreamReader($stream);
        $reader->close();
        $this->assertNull($reader->read());
    }

    /**
     * 正常系
     * 指定バイト数だけスキップできること
     * EOFを超えるサイズの読み込み時は、ファイルの場合改行が含まれる
     * @test
     * @dataProvider skipProvider
     */
    public function okSkip($stream, $result, $pos)
    {
        $reader = new InputStreamReader($stream);
        $this->assertEquals($reader->skip($pos), $pos);
        $this->assertEquals($reader->read(), $result);
    }

    /**
     * 正常系
     * 終端を越えたスキップをしたとき
     * 1回目のreadは空文字を返し、2回目のreadはnullを返すこと
     * @test
     * @dataProvider overSkipAndReadProvider
     */
    public function okOverSkipAndRead($stream, $skipNum)
    {
        $reader = new InputStreamReader($stream);
        $this->assertEquals($reader->skip($skipNum), $skipNum);
        $this->assertEmpty($reader->read());
        $this->assertNull($reader->read());
    }

    /**
     * 正常系
     * ポインタを後方に移動できること
     * @test
     * @dataProvider frontSkipProvider
     */
    public function okFrontSkip($stream, $skipNum1, $skipNum2, $result)
    {
        $reader = new InputStreamReader($stream);
        $reader->skip($skipNum1);
class User
{
    private $email;

    public function getEmail()
    {
        return $this->email;
    }

    public function setEmail($email)
    {
        $this->email = $email;
    }
}
        $reader->skip($skipNum2);
class User
{
    private $email;

    public function getEmail()
    {
        return $this->email;
    }

    public function setEmail($email)
    {
        $this->email = $email;
    }
}
        $this->assertEquals($reader->read(), $result);
    }

    /**
     * 正常系
     * ポインタ位置が負になった場合、移動量は常に-1になること
     * @test
     * @dataProvider overFrontSkipProvider
     */
    public function okOverFrontSkip($stream, $pos)
    {
        $reader = new InputStreamReader($stream);
        $this->assertEquals($reader->skip($pos), -1);
    }

    /**
     * 正常系
     * リセットすると初期位置にポインタが移動すること
     * @test
     * @dataProvider resetProvider
     */
    public function okReset($stream, $skipNum, $result)
    {
        $reader = new InputStreamReader($stream);
        $reader->skip($skipNum);
class User
{
    private $email;

    public function getEmail()
    {
        return $this->email;
    }

    public function setEmail($email)
    {
        $this->email = $email;
    }
}
        $reader->reset();
        $this->assertEquals($reader->read(), $result);
    }

    /**
     * 正常系
     * リセットするとマーク位置にポインタが移動すること
     * @test
     * @dataProvider markAndResetProvider
     */
    public function okMarkAndReset($stream, $skipNum, $result)
    {
        $reader = new InputStreamReader($stream);
        $reader->skip($skipNum);
class User
{
    private $email;

    public function getEmail()
    {
        return $this->email;
    }

    public function setEmail($email)
    {
        $this->email = $email;
    }
}
        $reader->mark();
        $reader->reset();
        $this->assertEquals($reader->read(), $result);
    }

    /**
     * 異常系
     * 読み込みサイズに不正値を渡した時、例外が発生すること
     * @test
     * @dataProvider invalidLengthProvider
     * @expectedException WebStream\Exception\Extend\InvalidArgumentException
     */
    public function ngInvalidLength($stream)
    {
        $reader = new InputStreamReader($stream);
        $reader->read("dummy");
        $this->assertTrue(false);
    }
}


1		<?php
2		namespace WebStream\IO\Test;
3
4		require_once dirname(__FILE__) . '/../InputStream.php';
5		require_once dirname(__FILE__) . '/../FileInputStream.php';
6		require_once dirname(__FILE__) . '/../StringInputStream.php';
7		require_once dirname(__FILE__) . '/../Reader/InputStreamReader.php';
8		require_once dirname(__FILE__) . '/../Test/Providers/InputStreamReaderProvider.php';
9		require_once dirname(__FILE__) . '/../Test/Modules/IOException.php';
10		require_once dirname(__FILE__) . '/../Test/Modules/InvalidArgumentException.php';
11
12		use WebStream\IO\Reader\InputStreamReader;
13		use WebStream\IO\Test\Providers\InputStreamReaderProvider;
14
15		/**
16		* InputStreamReaderTest
17		* @author Ryuichi TANAKA.
18		* @since 2016/08/18
19		* @version 0.7
20		*/
21	View Code Duplication	class InputStreamReaderTest extends \PHPUnit_Framework_TestCase
		0 ignored issues – show Duplication introduced 2016-09-19 03:36 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
22		{
23		use InputStreamReaderProvider;
24
25		/**
26		* 正常系
27		* バイト単位で読み込みできること
28		* EOFを超えるサイズの読み込み時は、ファイルの場合改行が含まれる
29		* @test
30		* @dataProvider readCharProvider
31		*/
32		public function okReadChar($stream, $result, $byteLength)
33		{
34		$reader = new InputStreamReader($stream);
35		$this->assertEquals($reader->read($byteLength), $result);
36		}
37
38		/**
39		* 正常系
40		* 行単位でデータが読み込めること
41		* @test
42		* @dataProvider readLineProvider
43		*/
44		public function okReadLine($stream, $result1, $result2)
45		{
46		$reader = new InputStreamReader($stream);
47		$this->assertEquals($reader->readLine(), $result1);
48		$this->assertEquals($reader->readLine(), $result2);
49		$this->assertEquals($reader->readLine(), null);
50		}
51
52		/**
53		* 正常系
54		* 入力ストリームをクローズできること
55		* @test
56		* @dataProvider closeProvider
57		*/
58		public function okClose($stream)
59		{
60		$reader = new InputStreamReader($stream);
61		$reader->close();
62		$this->assertNull($reader->read());
63		}
64
65		/**
66		* 正常系
67		* 指定バイト数だけスキップできること
68		* EOFを超えるサイズの読み込み時は、ファイルの場合改行が含まれる
69		* @test
70		* @dataProvider skipProvider
71		*/
72		public function okSkip($stream, $result, $pos)
73		{
74		$reader = new InputStreamReader($stream);
75		$this->assertEquals($reader->skip($pos), $pos);
76		$this->assertEquals($reader->read(), $result);
77		}
78
79		/**
80		* 正常系
81		* 終端を越えたスキップをしたとき
82		* 1回目のreadは空文字を返し、2回目のreadはnullを返すこと
83		* @test
84		* @dataProvider overSkipAndReadProvider
85		*/
86		public function okOverSkipAndRead($stream, $skipNum)
87		{
88		$reader = new InputStreamReader($stream);
89		$this->assertEquals($reader->skip($skipNum), $skipNum);
90		$this->assertEmpty($reader->read());
91		$this->assertNull($reader->read());
92		}
93
94		/**
95		* 正常系
96		* ポインタを後方に移動できること
97		* @test
98		* @dataProvider frontSkipProvider
99		*/
100		public function okFrontSkip($stream, $skipNum1, $skipNum2, $result)
101		{
102		$reader = new InputStreamReader($stream);
103		$reader->skip($skipNum1);
		0 ignored issues – show Unused Code introduced 2016-09-19 03:36 UTC by Report Bug Copy Issue Report The call to the method `WebStream\IO\Reader\InputStreamReader::skip()` seems un-needed as the method has no side-effects. PHP Analyzer performs a side-effects analysis of your code. A side-effect is basically anything that might be visible after the scope of the method is left. Let’s take a look at an example: class User { private $email; public function getEmail() { return $this->email; } public function setEmail($email) { $this->email = $email; } } If we look at the `getEmail()` method, we can see that it has no side-effect. Whether you call this method or not, no future calls to other methods are affected by this. As such code as the following is useless: $user = new User(); $user->getEmail(); // This line could safely be removed as it has no effect. On the hand, if we look at the `setEmail()`, this method _has_ side-effects. In the following case, we could not remove the method call: $user = new User(); $user->setEmail('email@domain'); // This line has a side-effect (it changes an // instance variable). Loading history...
104		$reader->skip($skipNum2);
		0 ignored issues – show Unused Code introduced 2016-09-19 03:36 UTC by Report Bug Copy Issue Report The call to the method `WebStream\IO\Reader\InputStreamReader::skip()` seems un-needed as the method has no side-effects. PHP Analyzer performs a side-effects analysis of your code. A side-effect is basically anything that might be visible after the scope of the method is left. Let’s take a look at an example: class User { private $email; public function getEmail() { return $this->email; } public function setEmail($email) { $this->email = $email; } } If we look at the `getEmail()` method, we can see that it has no side-effect. Whether you call this method or not, no future calls to other methods are affected by this. As such code as the following is useless: $user = new User(); $user->getEmail(); // This line could safely be removed as it has no effect. On the hand, if we look at the `setEmail()`, this method _has_ side-effects. In the following case, we could not remove the method call: $user = new User(); $user->setEmail('email@domain'); // This line has a side-effect (it changes an // instance variable). Loading history...
105		$this->assertEquals($reader->read(), $result);
106		}
107
108		/**
109		* 正常系
110		* ポインタ位置が負になった場合、移動量は常に-1になること
111		* @test
112		* @dataProvider overFrontSkipProvider
113		*/
114		public function okOverFrontSkip($stream, $pos)
115		{
116		$reader = new InputStreamReader($stream);
117		$this->assertEquals($reader->skip($pos), -1);
118		}
119
120		/**
121		* 正常系
122		* リセットすると初期位置にポインタが移動すること
123		* @test
124		* @dataProvider resetProvider
125		*/
126		public function okReset($stream, $skipNum, $result)
127		{
128		$reader = new InputStreamReader($stream);
129		$reader->skip($skipNum);
		0 ignored issues – show Unused Code introduced 2016-09-19 03:36 UTC by Report Bug Copy Issue Report The call to the method `WebStream\IO\Reader\InputStreamReader::skip()` seems un-needed as the method has no side-effects. PHP Analyzer performs a side-effects analysis of your code. A side-effect is basically anything that might be visible after the scope of the method is left. Let’s take a look at an example: class User { private $email; public function getEmail() { return $this->email; } public function setEmail($email) { $this->email = $email; } } If we look at the `getEmail()` method, we can see that it has no side-effect. Whether you call this method or not, no future calls to other methods are affected by this. As such code as the following is useless: $user = new User(); $user->getEmail(); // This line could safely be removed as it has no effect. On the hand, if we look at the `setEmail()`, this method _has_ side-effects. In the following case, we could not remove the method call: $user = new User(); $user->setEmail('email@domain'); // This line has a side-effect (it changes an // instance variable). Loading history...
130		$reader->reset();
131		$this->assertEquals($reader->read(), $result);
132		}
133
134		/**
135		* 正常系
136		* リセットするとマーク位置にポインタが移動すること
137		* @test
138		* @dataProvider markAndResetProvider
139		*/
140		public function okMarkAndReset($stream, $skipNum, $result)
141		{
142		$reader = new InputStreamReader($stream);
143		$reader->skip($skipNum);
		0 ignored issues – show Unused Code introduced 2016-09-19 03:36 UTC by Report Bug Copy Issue Report The call to the method `WebStream\IO\Reader\InputStreamReader::skip()` seems un-needed as the method has no side-effects. PHP Analyzer performs a side-effects analysis of your code. A side-effect is basically anything that might be visible after the scope of the method is left. Let’s take a look at an example: class User { private $email; public function getEmail() { return $this->email; } public function setEmail($email) { $this->email = $email; } } If we look at the `getEmail()` method, we can see that it has no side-effect. Whether you call this method or not, no future calls to other methods are affected by this. As such code as the following is useless: $user = new User(); $user->getEmail(); // This line could safely be removed as it has no effect. On the hand, if we look at the `setEmail()`, this method _has_ side-effects. In the following case, we could not remove the method call: $user = new User(); $user->setEmail('email@domain'); // This line has a side-effect (it changes an // instance variable). Loading history...
144		$reader->mark();
145		$reader->reset();
146		$this->assertEquals($reader->read(), $result);
147		}
148
149		/**
150		* 異常系
151		* 読み込みサイズに不正値を渡した時、例外が発生すること
152		* @test
153		* @dataProvider invalidLengthProvider
154		* @expectedException WebStream\Exception\Extend\InvalidArgumentException
155		*/
156		public function ngInvalidLength($stream)
157		{
158		$reader = new InputStreamReader($stream);
159		$reader->read("dummy");
160		$this->assertTrue(false);
161		}
162		}
163

webstream-framework / WebStream

Push — feature/0.7.0 ( 38440f...02d6a4 )

InputStreamReaderTest A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

10 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like