CacheProvider - Code Metrics - Inspection of "パス、メソッド名修正" - webstream-framework/WebStream - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — feature/0.7.0 ( 38440f...02d6a4 )

by Ryuichi

created 2016-09-19 03:29 UTC

CacheProvider A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	59
Duplicated Lines	100 %

Importance

Changes

Metric	Value
dl	59
loc	59
rs	10
c	0
b	0
f	0
wmc	2

9 Methods

Rating	Name	Duplication	Size	Complexity
A	hp$0 ➔ __call()	1	1	1
A	hp$1 ➔ __call()	1	1	1
A	hp$2 ➔ __call()	1	1	1
A	hp$3 ➔ __call()	1	1	1
A	cacheProvider()	9	9	1
A	getApcuObject()	9	9	1
A	getMemcachedObject()	11	11	1
A	getRedisObject()	12	12	1
A	getTemporaryFileObject()	11	11	1

How to fix Duplicated Code

<?php
namespace WebStream\Cache\Test\Providers;

use WebStream\Container\Container;
use WebStream\Cache\Driver\Apcu;
use WebStream\Cache\Driver\Memcached;
use WebStream\Cache\Driver\Redis;
use WebStream\Cache\Driver\TemporaryFile;
use WebStream\Cache\Driver\CacheDriverFactory;
use WebStream\IO\File;

/**
 * CacheProvider
 * @author Ryuichi TANAKA.
 * @since 2016/07/11
 * @version 0.7
 */
trait CacheProvider

{
    public function cacheProvider()
    {
        return [
            [$this->getApcuObject()],
            [$this->getMemcachedObject()],
            [$this->getRedisObject()],
            [$this->getTemporaryFileObject()]
        ];
    }

    private function getApcuObject()
    {
        $factory = new CacheDriverFactory();
        $driver = $factory->create("WebStream\Cache\Driver\Apcu");
        $logger = new class() { function __call($name, $args) {} };

        $driver->inject('logger', $logger);

        return $driver;
    }

    private function getMemcachedObject()
    {
        $factory = new CacheDriverFactory();
        $container = new Container(false);
        $container->servers = [["memcached", 11211]];
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $driver = $factory->create("WebStream\Cache\Driver\Memcached", $container);
        $logger = new class() { function __call($name, $args) {} };

        $driver->inject('logger', $logger);

        return $driver;
    }

    private function getRedisObject()
    {
        $factory = new CacheDriverFactory();
        $container = new Container(false);
        $container->host = "redis";
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $container->port = 6379;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $driver = $factory->create("WebStream\Cache\Driver\Redis", $container);
        $logger = new class() { function __call($name, $args) {} };

        $driver->inject('logger', $logger);

        return $driver;
    }

    private function getTemporaryFileObject()
    {
        $factory = new CacheDriverFactory();
        $container = new Container(false);
        $container->cacheDir = "/tmp";
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $driver = $factory->create("WebStream\Cache\Driver\TemporaryFile", $container);
        $logger = new class() { function __call($name, $args) {} };

        $driver->inject('logger', $logger);

        return $driver;
    }
}


1		<?php
2		namespace WebStream\Cache\Test\Providers;
3
4		use WebStream\Container\Container;
5		use WebStream\Cache\Driver\Apcu;
6		use WebStream\Cache\Driver\Memcached;
7		use WebStream\Cache\Driver\Redis;
8		use WebStream\Cache\Driver\TemporaryFile;
9		use WebStream\Cache\Driver\CacheDriverFactory;
10		use WebStream\IO\File;
11
12		/**
13		* CacheProvider
14		* @author Ryuichi TANAKA.
15		* @since 2016/07/11
16		* @version 0.7
17		*/
18	View Code Duplication	trait CacheProvider
		0 ignored issues – show Duplication introduced 2016-09-19 03:36 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
19		{
20		public function cacheProvider()
21		{
22		return [
23		[$this->getApcuObject()],
24		[$this->getMemcachedObject()],
25		[$this->getRedisObject()],
26		[$this->getTemporaryFileObject()]
27		];
28		}
29
30		private function getApcuObject()
31		{
32		$factory = new CacheDriverFactory();
33		$driver = $factory->create("WebStream\Cache\Driver\Apcu");
34		$logger = new class() { function __call($name, $args) {} };
		0 ignored issues – show Best Practice introduced 2016-09-19 03:36 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
35		$driver->inject('logger', $logger);
36
37		return $driver;
38		}
39
40		private function getMemcachedObject()
41		{
42		$factory = new CacheDriverFactory();
43		$container = new Container(false);
44		$container->servers = [["memcached", 11211]];
		0 ignored issues – show Documentation introduced 2016-09-19 03:36 UTC by Report Bug Copy Issue Report The property `servers` does not exist on `object<WebStream\Container\Container>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
45		$driver = $factory->create("WebStream\Cache\Driver\Memcached", $container);
46		$logger = new class() { function __call($name, $args) {} };
		0 ignored issues – show Best Practice introduced 2016-09-19 03:36 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
47		$driver->inject('logger', $logger);
48
49		return $driver;
50		}
51
52		private function getRedisObject()
53		{
54		$factory = new CacheDriverFactory();
55		$container = new Container(false);
56		$container->host = "redis";
		0 ignored issues – show Documentation introduced 2016-09-19 03:36 UTC by Report Bug Copy Issue Report The property `host` does not exist on `object<WebStream\Container\Container>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
57		$container->port = 6379;
		0 ignored issues – show Documentation introduced 2016-09-19 03:36 UTC by Report Bug Copy Issue Report The property `port` does not exist on `object<WebStream\Container\Container>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
58		$driver = $factory->create("WebStream\Cache\Driver\Redis", $container);
59		$logger = new class() { function __call($name, $args) {} };
		0 ignored issues – show Best Practice introduced 2016-09-19 03:36 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
60		$driver->inject('logger', $logger);
61
62		return $driver;
63		}
64
65		private function getTemporaryFileObject()
66		{
67		$factory = new CacheDriverFactory();
68		$container = new Container(false);
69		$container->cacheDir = "/tmp";
		0 ignored issues – show Documentation introduced 2016-09-19 03:36 UTC by Report Bug Copy Issue Report The property `cacheDir` does not exist on `object<WebStream\Container\Container>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
70		$driver = $factory->create("WebStream\Cache\Driver\TemporaryFile", $container);
71		$logger = new class() { function __call($name, $args) {} };
		0 ignored issues – show Best Practice introduced 2016-09-19 03:36 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
72		$driver->inject('logger', $logger);
73
74		return $driver;
75		}
76		}
77

webstream-framework / WebStream

Push — feature/0.7.0 ( 38440f...02d6a4 )

CacheProvider A

Complexity

Size/Duplication

Importance

9 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like