FileOutputStream::close() - Code Metrics - Inspection of "OutputStream系クラス追加、InputStream修正" - webstream-framework/WebStream - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — feature/0.7.0 ( d06a69...2e2153 )

by Ryuichi

created 2016-02-24 14:28 UTC

FileOutputStream::close() A

↳ Parent: FileOutputStream

Complexity

Conditions	4
Paths	3

Size

Total Lines	14
Code Lines	7

Duplication

Lines	14
Ratio	100 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	14
loc	14
rs	9.2
cc	4
eloc	7
nc	3
nop	0

<?php
namespace WebStream\IO;

use WebStream\Exception\Extend\InvalidArgumentException;
use WebStream\Exception\Extend\IOException;

/**
 * FileOutputStream
 * @author Ryuichi TANAKA.
 * @since 2016/02/24
 * @version 0.7
 */
class FileOutputStream extends OutputStream
{
    /**
     * @var File ファイルオブジェクト
     */
    protected $file;

    /**
     * constructor
     * @param mixed $file ファイルオブジェクトまたはファイルパス
     * @throws InvalidArgumentException
     * @throws IOException
     */
    public function __construct($file, bool $isAppend = false)
    {
        if ($file instanceof File) {

            $this->file = $file;
        } elseif (is_string($file)) {
            $this->file = new File($file);
        } else {
            throw new InvalidArgumentException("Invalid argument type: " . $file);
        }

        $mode = $isAppend ? 'ab' : 'wb';
        $stream = @fopen($this->file->getAbsoluteFilePath(), $mode);

        if (!is_resource($stream) || $stream === false) {

            throw new IOException("Unable open " . $this->file->getAbsoluteFilePath());
        }

        parent::__construct($stream);
    }

    /**
     * {@inheritdoc}
     */
    public function write($buf, int $off = null, int $len = null)
    {
        $data = null;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        if ($off === null && $len === null) {
            $data = $buf;
        } elseif ($off !== null && $len === null) {
            $data = substr($buf, $off);
        } elseif ($off === null && $len !== null) {
            $data = substr($buf, 0, $len);
        } else {
            $data = substr($buf, $off, $len);
        }

        if (@fwrite($this->stream, $data) === false) {
            throw new IOException("Failed to write stream.");
        }
    }

    /**
     * {@inheritdoc}
     */
    public function close()

    {
        if ($this->stream === null) {
            return;
        }

        $this->flush();

        if (get_resource_type($this->stream) !== 'Unknown' && fclose($this->stream) === false) {
            throw new IOException("Cannot close output stream.");
        }

        $this->stream = null;
    }

    /**
     * {@inheritdoc}
     */
    public function flush()
    {
        if (@fflush($this->stream) === false) {
            throw new IOException("Failed to flush.");
        }
    }
}


1		<?php
2		namespace WebStream\IO;
3
4		use WebStream\Exception\Extend\InvalidArgumentException;
5		use WebStream\Exception\Extend\IOException;
6
7		/**
8		* FileOutputStream
9		* @author Ryuichi TANAKA.
10		* @since 2016/02/24
11		* @version 0.7
12		*/
13		class FileOutputStream extends OutputStream
14		{
15		/**
16		* @var File ファイルオブジェクト
17		*/
18		protected $file;
19
20		/**
21		* constructor
22		* @param mixed $file ファイルオブジェクトまたはファイルパス
23		* @throws InvalidArgumentException
24		* @throws IOException
25		*/
26		public function __construct($file, bool $isAppend = false)
27		{
28	View Code Duplication	if ($file instanceof File) {
		0 ignored issues – show Duplication introduced 2016-02-24 14:33 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
29		$this->file = $file;
30		} elseif (is_string($file)) {
31		$this->file = new File($file);
32		} else {
33		throw new InvalidArgumentException("Invalid argument type: " . $file);
34		}
35
36		$mode = $isAppend ? 'ab' : 'wb';
37		$stream = @fopen($this->file->getAbsoluteFilePath(), $mode);
38
39	View Code Duplication	if (!is_resource($stream) \|\| $stream === false) {
		0 ignored issues – show Duplication introduced 2016-02-24 14:33 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
40		throw new IOException("Unable open " . $this->file->getAbsoluteFilePath());
41		}
42
43		parent::__construct($stream);
44		}
45
46		/**
47		* {@inheritdoc}
48		*/
49		public function write($buf, int $off = null, int $len = null)
50		{
51		$data = null;
		0 ignored issues – show Unused Code introduced 2016-02-24 14:33 UTC by Report Bug Copy Issue Report `$data` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
52		if ($off === null && $len === null) {
53		$data = $buf;
54		} elseif ($off !== null && $len === null) {
55		$data = substr($buf, $off);
56		} elseif ($off === null && $len !== null) {
57		$data = substr($buf, 0, $len);
58		} else {
59		$data = substr($buf, $off, $len);
60		}
61
62		if (@fwrite($this->stream, $data) === false) {
63		throw new IOException("Failed to write stream.");
64		}
65		}
66
67		/**
68		* {@inheritdoc}
69		*/
70	View Code Duplication	public function close()
		0 ignored issues – show Duplication introduced 2016-02-24 14:33 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
71		{
72		if ($this->stream === null) {
73		return;
74		}
75
76		$this->flush();
77
78		if (get_resource_type($this->stream) !== 'Unknown' && fclose($this->stream) === false) {
79		throw new IOException("Cannot close output stream.");
80		}
81
82		$this->stream = null;
83		}
84
85		/**
86		* {@inheritdoc}
87		*/
88		public function flush()
89		{
90		if (@fflush($this->stream) === false) {
91		throw new IOException("Failed to flush.");
92		}
93		}
94		}
95

webstream-framework / WebStream

Push — feature/0.7.0 ( d06a69...2e2153 )

FileOutputStream::close() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like