Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
12 | trait FileProvider |
||
13 | { |
||
14 | public function fileProvider() |
||
15 | { |
||
16 | return [ |
||
17 | [new File(dirname(__FILE__) . "/../Fixtures/file-test1.txt")] |
||
18 | ]; |
||
19 | } |
||
20 | |||
21 | public function directoryProvider() |
||
22 | { |
||
23 | return [ |
||
24 | [new File(dirname(__FILE__) . "/../Fixtures/file-test/")] |
||
25 | ]; |
||
26 | } |
||
27 | |||
28 | public function fileLinkProvider() |
||
29 | { |
||
30 | return [ |
||
31 | [new File(dirname(__FILE__) . "/../Fixtures/file-test1.txt"), "/tmp/file-test-link"] |
||
32 | ]; |
||
33 | } |
||
34 | |||
35 | public function tmpFileProvider() |
||
36 | { |
||
37 | return [ |
||
38 | [new File("/tmp/file-test-tmp.txt")] |
||
39 | ]; |
||
40 | } |
||
41 | |||
42 | public function tmpDirectoryProvider() |
||
43 | { |
||
44 | return [ |
||
45 | [new File("/tmp/file-test-tmp/")] |
||
46 | ]; |
||
47 | } |
||
48 | |||
49 | public function renameFailureProvider() |
||
50 | { |
||
51 | return [ |
||
52 | [new File(dirname(__FILE__) . "/../Fixtures/file-test/file-test2.txt")] |
||
53 | ]; |
||
54 | } |
||
55 | } |
||
56 |