WebStream\Annotation\Attributes\Header::onMethodInject()

Complexity

Conditions	10
Paths	6

Size

Total Lines	46
Code Lines	26

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public function onMethodInject(IAnnotatable $instance, \ReflectionMethod $method, Container $container)
    {
        $allowMethods = $this->injectAnnotation['allowMethod'];
        $logger = $container->logger;

The property logger does not exist on WebStream\Container\Container. Since you implemented __get, consider adding a @property annotation.

        // 指定無しの場合はチェックしない(すべてのメソッドを許可する)
        if ($allowMethods !== null) {
            if (!is_array($allowMethods)) {
                $allowMethods = [$allowMethods];
            }

            for ($i = 0; $i < count($allowMethods); $i++) {

It seems like you are calling the size function count() as part of the test condition. You might want to compute the size beforehand, and not on each iteration.

                if (!preg_match("/^(?:(?:P(?:OS|U)|GE)T|(?:p(?:os|u)|ge)t|DELETE|delete)$/", $allowMethods[$i])) {
                    $errorMsg = "Invalid value '" . $allowMethods[$i] . "' in 'allowMethod' attribute of @Header.";
                    throw new AnnotationException($errorMsg);
                }
                $allowMethods[$i] = strtoupper($allowMethods[$i]);
            }

            // 複数指定した場合、一つでも許可されていればOK
            if (!array_key_exists($container->requestMethod, array_flip($allowMethods))) {

The property requestMethod does not exist on WebStream\Container\Container. Since you implemented __get, consider adding a @property annotation.

                $errorMsg = "Not allowed request method '" . $container->requestMethod;
                throw new InvalidRequestException($errorMsg);
            }

            $logger->debug("Accepted method '" . implode(',', $allowMethods) . "'");

The method debug() does not exist on null.

        }

        $ext = $this->injectAnnotation['contentType'] ?: 'html';

        if (!is_string($ext)) {
            $errorMsg = "contentType' attribute of @Header must be string.";
            throw new AnnotationException($errorMsg);
        }

        $contentType = null;
        if (array_key_exists($ext, $this->contentTypeList)) {
            $contentType = $this->contentTypeList[$ext];
        }
        if ($contentType === null) {
            $errorMsg = "Invalid value '$ext' in 'contentType' attribute of @Header.";
            throw new AnnotationException($errorMsg);
        }

        $this->readAnnotation['contentType'] = $ext;
        $logger->debug("Accepted contentType '$ext'");
    }