webstream-framework /
WebStream
| Total Complexity | 40 |
| Total Lines | 227 |
| Duplicated Lines | 0 % |
| Changes | 0 | ||
Complex classes like LoggerConfigurationManager often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use LoggerConfigurationManager, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 15 | class LoggerConfigurationManager |
||
| 16 | { |
||
| 17 | /** |
||
| 18 | * @var Container ログ設定コンテナ |
||
| 19 | */ |
||
| 20 | private $logContainer; |
||
| 21 | |||
| 22 | /** |
||
| 23 | * @var Container IOコンテナ |
||
| 24 | */ |
||
| 25 | private $ioContainer; |
||
| 26 | |||
| 27 | /** |
||
| 28 | * @var array<string> ログ設定情報 |
||
| 29 | */ |
||
| 30 | private $configMap; |
||
| 31 | |||
| 32 | /** |
||
| 33 | * Constructor |
||
| 34 | * @param mixed $config ログ設定 |
||
| 35 | * @throws LoggerException |
||
| 36 | */ |
||
| 37 | public function __construct($config) |
||
| 38 | { |
||
| 39 | if (is_array($config)) { |
||
| 40 | $configMap = $config; |
||
| 41 | } else { |
||
| 42 | $configMap = parse_ini_file($config); |
||
| 43 | if ($configMap === null) { |
||
| 44 | throw new LoggerException("Log config file does not exist: " . $config); |
||
| 45 | } |
||
| 46 | } |
||
| 47 | |||
| 48 | $this->logContainer = new Container(false); |
||
| 49 | $this->ioContainer = new Container(); |
||
| 50 | |||
| 51 | $this->ioContainer->file = function () use ($configMap) { |
||
|
Bug
Best Practice
introduced
by
|
|||
| 52 | if (!array_key_exists("path", $configMap)) { |
||
| 53 | throw new LoggerException("Log path must be defined."); |
||
| 54 | } |
||
| 55 | return new File($configMap["path"]); |
||
| 56 | }; |
||
| 57 | $this->ioContainer->fileWriter = function () use ($configMap) { |
||
| 58 | return new SimpleFileWriter($configMap["path"]); |
||
| 59 | }; |
||
| 60 | |||
| 61 | $this->configMap = $configMap; |
||
| 62 | } |
||
| 63 | |||
| 64 | /** |
||
| 65 | * 設定を読み込む |
||
| 66 | * @throws LoggerException |
||
| 67 | */ |
||
| 68 | public function load() |
||
| 69 | { |
||
| 70 | $this->loadLogLevel() |
||
| 71 | ->loadLogFilePath() |
||
| 72 | ->loadRotateCycle() |
||
| 73 | ->loadRotateSize() |
||
| 74 | ->loadApplicationName() |
||
| 75 | ->loadFormat(); |
||
| 76 | } |
||
| 77 | |||
| 78 | /** |
||
| 79 | * ログ設定を返却する |
||
| 80 | * @return Container ログ設定 |
||
| 81 | */ |
||
| 82 | public function getConfig() |
||
| 83 | { |
||
| 84 | return $this->logContainer; |
||
| 85 | } |
||
| 86 | |||
| 87 | /** |
||
| 88 | * ログレベルを読み込む |
||
| 89 | * @throws LoggerException |
||
| 90 | */ |
||
| 91 | private function loadLogLevel() |
||
| 92 | { |
||
| 93 | if (!array_key_exists("level", $this->configMap)) { |
||
| 94 | throw new LoggerException("Log level must be defined."); |
||
| 95 | } |
||
| 96 | |||
| 97 | $logLevel = $this->toLogLevelValue($this->configMap["level"]); |
||
| 98 | $this->logContainer->logLevel = $logLevel; |
||
| 99 | |||
| 100 | return $this; |
||
| 101 | } |
||
| 102 | |||
| 103 | /** |
||
| 104 | * ログ保存先パスを読み込む |
||
| 105 | * @throws LoggerException |
||
| 106 | */ |
||
| 107 | private function loadLogFilePath() |
||
| 120 | } |
||
| 121 | |||
| 122 | /** |
||
| 123 | * ログローテートサイクルを読み込む |
||
| 124 | * @throws LoggerException |
||
| 125 | */ |
||
| 126 | private function loadRotateCycle() |
||
| 127 | { |
||
| 128 | if (array_key_exists("rotate_cycle", $this->configMap)) { |
||
| 129 | $this->logContainer->rotateCycle = $this->cycle2value($this->configMap["rotate_cycle"]); |
||
| 130 | } |
||
| 131 | |||
| 132 | return $this; |
||
| 133 | } |
||
| 134 | |||
| 135 | /** |
||
| 136 | * ログローテートサイズを読み込む |
||
| 137 | * @throws LoggerException |
||
| 138 | */ |
||
| 139 | private function loadRotateSize() |
||
| 140 | { |
||
| 141 | if (array_key_exists("rotate_size", $this->configMap)) { |
||
| 142 | $rotateSize = intval($this->configMap["rotate_size"]); |
||
| 143 | // ローテートサイズが不正の場合(正の整数以外の値が設定された場合) |
||
| 144 | if ($rotateSize <= 0) { |
||
| 145 | throw new LoggerException("Invalid log rotate size: " . $this->configMap["rotate_size"]); |
||
| 146 | } |
||
| 147 | $this->logContainer->rotateSize = $rotateSize; |
||
| 148 | } |
||
| 149 | |||
| 150 | return $this; |
||
| 151 | } |
||
| 152 | |||
| 153 | /** |
||
| 154 | * アプリケーション名を読み込む |
||
| 155 | */ |
||
| 156 | private function loadApplicationName() |
||
| 157 | { |
||
| 158 | if (array_key_exists("application_name", $this->configMap) && !empty($this->configMap["application_name"])) { |
||
| 159 | $this->logContainer->applicationName = $this->configMap["application_name"]; |
||
| 160 | } |
||
| 161 | |||
| 162 | return $this; |
||
| 163 | } |
||
| 164 | |||
| 165 | /** |
||
| 166 | * ロガーフォーマットを読み込む |
||
| 167 | */ |
||
| 168 | private function loadFormat() |
||
| 169 | { |
||
| 170 | if (array_key_exists("format", $this->configMap)) { |
||
| 171 | $this->logContainer->format = $this->configMap["format"]; |
||
| 172 | } else { |
||
| 173 | $this->logContainer->format = $this->defaultLoggerFormatter(); |
||
| 174 | } |
||
| 175 | |||
| 176 | return $this; |
||
| 177 | } |
||
| 178 | |||
| 179 | /** |
||
| 180 | * ログローテートサイクルを時間に変換 |
||
| 181 | * @param string ローテートサイクル |
||
| 182 | * @return int ローテート時間 |
||
| 183 | * @throws LoggerException |
||
| 184 | */ |
||
| 185 | private function cycle2value($cycle) |
||
| 208 | } |
||
| 209 | } |
||
| 210 | |||
| 211 | /** |
||
| 212 | * ログレベルを数値に変換 |
||
| 213 | * ログレベルはWebStream独自、PSR-3両方対応 |
||
| 214 | * @param string ログレベル文字列 |
||
| 215 | * @throws LoggerException |
||
| 216 | * @return int ログレベル数値 |
||
| 217 | */ |
||
| 218 | private function toLogLevelValue(string $level) |
||
| 242 | } |
||
| 243 | } |
||
| 244 | } |
||
| 245 |
Loading history...