Complex classes like LoggerConfigurationManager often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use LoggerConfigurationManager, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
15 | class LoggerConfigurationManager |
||
16 | { |
||
17 | /** |
||
18 | * @var Container ログ設定コンテナ |
||
19 | */ |
||
20 | private $logContainer; |
||
21 | |||
22 | /** |
||
23 | * @var Container IOコンテナ |
||
24 | */ |
||
25 | private $ioContainer; |
||
26 | |||
27 | /** |
||
28 | * @var array<string> ログ設定情報 |
||
29 | */ |
||
30 | private $configMap; |
||
31 | |||
32 | /** |
||
33 | * Constructor |
||
34 | * @param mixed $config ログ設定 |
||
35 | * @throws LoggerException |
||
36 | */ |
||
37 | 141 | public function __construct($config) |
|
38 | { |
||
39 | 141 | if (is_array($config)) { |
|
40 | $configMap = $config; |
||
41 | } else { |
||
42 | 141 | $configMap = parse_ini_file($config); |
|
43 | 141 | if ($configMap === null) { |
|
44 | throw new LoggerException("Log config file does not exist: " . $config); |
||
45 | } |
||
46 | } |
||
47 | |||
48 | 141 | $this->logContainer = new Container(false); |
|
49 | 141 | $this->ioContainer = new Container(); |
|
50 | |||
51 | 141 | $this->ioContainer->file = function () use ($configMap) { |
|
52 | 141 | if (!array_key_exists("path", $configMap)) { |
|
53 | throw new LoggerException("Log path must be defined."); |
||
54 | } |
||
55 | 141 | return new File($configMap["path"]); |
|
56 | }; |
||
57 | 8 | $this->ioContainer->fileWriter = function () use ($configMap) { |
|
58 | 8 | return new SimpleFileWriter($configMap["path"]); |
|
59 | }; |
||
60 | |||
61 | 141 | $this->configMap = $configMap; |
|
62 | 141 | } |
|
63 | |||
64 | /** |
||
65 | * 設定を読み込む |
||
66 | * @throws LoggerException |
||
67 | */ |
||
68 | 141 | public function load() |
|
77 | |||
78 | /** |
||
79 | * ログ設定を返却する |
||
80 | * @return Container ログ設定 |
||
81 | */ |
||
82 | 141 | public function getConfig() |
|
86 | |||
87 | /** |
||
88 | * ログレベルを読み込む |
||
89 | * @throws LoggerException |
||
90 | */ |
||
91 | 141 | private function loadLogLevel() |
|
102 | |||
103 | /** |
||
104 | * ログ保存先パスを読み込む |
||
105 | * @throws LoggerException |
||
106 | */ |
||
107 | 141 | private function loadLogFilePath() |
|
121 | |||
122 | /** |
||
123 | * ログローテートサイクルを読み込む |
||
124 | * @throws LoggerException |
||
125 | */ |
||
126 | 141 | private function loadRotateCycle() |
|
134 | |||
135 | /** |
||
136 | * ログローテートサイズを読み込む |
||
137 | * @throws LoggerException |
||
138 | */ |
||
139 | 141 | private function loadRotateSize() |
|
152 | |||
153 | /** |
||
154 | * アプリケーション名を読み込む |
||
155 | */ |
||
156 | 141 | private function loadApplicationName() |
|
164 | |||
165 | /** |
||
166 | * ロガーフォーマットを読み込む |
||
167 | */ |
||
168 | 141 | private function loadFormat() |
|
178 | |||
179 | /** |
||
180 | * ログローテートサイクルを時間に変換 |
||
181 | * @param string ローテートサイクル |
||
182 | * @return int ローテート時間 |
||
183 | * @throws LoggerException |
||
184 | */ |
||
185 | 14 | private function cycle2value($cycle) |
|
186 | { |
||
187 | 14 | $day_to_h = 24; |
|
188 | 14 | $week_to_h = $day_to_h * 7; |
|
189 | 14 | $month_to_h = $day_to_h * intval(date("t", time())); |
|
190 | 14 | $year_to_h = $day_to_h * 365; |
|
191 | |||
192 | 14 | $year = date("Y"); |
|
193 | 14 | if (($year % 4 === 0 && $year % 100 !== 0) || $year % 400 === 0) { |
|
194 | $year_to_h = $day_to_h * 366; |
||
195 | } |
||
196 | |||
197 | 14 | switch (strtolower($cycle)) { |
|
198 | 14 | case 'day': |
|
199 | 4 | return $day_to_h; |
|
200 | 10 | case 'week': |
|
201 | 4 | return $week_to_h; |
|
202 | 6 | case 'month': |
|
203 | 3 | return $month_to_h; |
|
204 | 3 | case 'year': |
|
205 | 3 | return $year_to_h; |
|
206 | default: |
||
207 | throw new LoggerException("Invalid log rotate cycle: " . $cycle); |
||
208 | } |
||
209 | } |
||
210 | |||
211 | /** |
||
212 | * ログレベルを数値に変換 |
||
213 | * ログレベルはWebStream独自、PSR-3両方対応 |
||
214 | * @param string ログレベル文字列 |
||
215 | * @throws LoggerException |
||
216 | * @return int ログレベル数値 |
||
217 | */ |
||
218 | 141 | private function toLogLevelValue(string $level) |
|
244 | } |
||
245 |
This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces.
This is most likely a typographical error or the method has been renamed.