ContainerTest::okRemove() - Code Metrics - Inspection of "Moudle下のファイルが読まれてる対策" - webstream-framework/Annotation - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Branch — master (91c650)

by Ryuichi

created 2017-10-22 12:48 UTC

ContainerTest::okRemove() A

↳ Parent: ContainerTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	7
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	7
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	5
nc	1
nop	0

<?php

namespace WebStream\Container\Test;

require_once dirname(__FILE__) . '/../Container.php';
require_once dirname(__FILE__) . '/../ValueProxy.php';
require_once dirname(__FILE__) . '/../Test/Providers/ContainerProvider.php';
require_once dirname(__FILE__) . '/../Test/Modules/InvalidArgumentException.php';

use WebStream\Container\Container;
use WebStream\Container\ValueProxy;
use WebStream\Container\Test\Providers\ContainerProvider;

/**
 * ContainerTest
 * @author Ryuichi TANAKA.
 * @since 2016/08/20
 * @version 0.7
 */
class ContainerTest extends \PHPUnit\Framework\TestCase
{
    use ContainerProvider;

    /**
     * 正常系
     * 値を格納して取り出せること
     * @test
     * @dataProvider valueLazyProvider
     */
    public function okContainer($value, $result)
    {
        $container = new Container();
        $container->test = $value;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $this->assertEquals($container->test, $result);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }

    /**
     * 正常系
     * 設定した値のカウントが取得できること
     * @test
     */
    public function okLength()
    {
        $container = new Container();
        $container->test1 = 1;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $container->test2 = 2;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $this->assertEquals($container->length(), 2);
    }

    /**
     * 正常系
     * 値を削除できること
     * 削除後の要素にアクセスすると例外が発生すること
     * @test
     * @expectedException WebStream\Exception\Extend\InvalidArgumentException
     */
    public function okRemove()
    {
        $container = new Container();
        $container->test1 = 1;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $container->remove("test1");
        $this->assertNull($container->test1);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }

    /**
     * 正常系
     * プリミティブ値を登録できること
     * 値はそのまま保存される
     * @test
     * @dataProvider valueDynamicProvider
     */
    public function okRegisterPrimitive($value, $result)
    {
        $container = new Container();
        $container->register("test", $value);
        $this->assertEquals($container->test, $result);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }

    /**
     * 正常系
     * クロージャを登録できること
     * 値はそのまま保存される
     * @test
     */
    public function okRegisterClosure()
    {
        $func = function() {
            return "test";
        };
        $container = new Container();
        $container->register("test", $func);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $this->assertInternalType("object", $container->test);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $result = $container->test;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $this->assertEquals($result(), "test");
    }

    /**
     * 正常系
     * 即時実行状態で登録されること
     * @test
     */
    public function okRegisterAsDynamic()
    {
        $func = function() {
            echo "evaluated";
            return "test";
        };
        $container = new Container();
        $container->registerAsDynamic("test", $func);
        $this->expectOutputString("evaluated");
        $this->assertEquals($container->test, "test");
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }

    /**
     * 正常系
     * 遅延実行状態で登録されること
     * @test
     */
    public function okRegisterAsLazy()
    {
        $func = function() {
            echo "evaluated";
            return "test";
        };
        $container = new Container();
        $container->registerAsLazy("test", $func);
        $this->expectOutputString(null);
        $this->assertEquals($container->test, "test");
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $this->expectOutputString("evaluated");
    }

    /**
     * 正常系
     * コンテナから取得するとき、値はキャッシュされていること
     * @test
     */
    public function okRegisterCached()
    {
        $func = function() {
            echo "evaluated";
            return "test";
        };

        $container = new Container();
        // $container->registerAsLazyUnCached("test", $func);


        ob_start();
        $container->registerAsDynamic("test", $func);
        $actual = ob_get_clean();
        $this->assertEquals($actual, "evaluated");
        $this->assertEquals($container->test, "test");
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

        ob_start();
        $container->registerAsLazy("test", $func);
        $this->assertEquals($container->test, "test");
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $actual = ob_get_clean();
        $this->assertEquals($actual, "evaluated"); // uncached
    }

    /**
     * 正常系
     * コンテナから取得するとき、値はキャッシュされていないこと
     * @test
     */
    public function okRegisterUnCached()
    {
        $func = function() {
            echo "evaluated";
            return "test";
        };

        $container = new Container();
        $container->registerAsLazyUnCached("test", $func);

        ob_start();
        $this->assertEquals($container->test, "test");
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $actual = ob_get_clean();
        $this->assertEquals($actual, "evaluated");

        ob_start();
        $this->assertEquals($container->test, "test");
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $actual = ob_get_clean();
        $this->assertEquals($actual, "evaluated"); // uncached
    }

    /**
     * 正常系
     * 未定義の値にアクセスしても例外が発生しないこと
     * @test
     */
    public function okUnStrictContainer()
    {
        $container = new Container(false);
        $this->assertNull($container->undefined);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }
}


1			<?php
			0 ignored issues – show Coding Style Compatibility introduced 2017-10-22 12:51 UTC by Report Bug Copy Issue Report For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 19 and the first side effect is on line 4. The PSR-1: Basic Coding Standard recommends that a file should either introduce new symbols, that is classes, functions, constants or similar, or have side effects. Side effects are anything that executes logic, like for example printing output, changing ini settings or writing to a file. The idea behind this recommendation is that merely auto-loading a class should not change the state of an application. It also promotes a cleaner style of programming and makes your code less prone to errors, because the logic is not spread out all over the place. To learn more about the PSR-1, please see the PHP-FIG site on the PSR-1. Loading history...
2			namespace WebStream\Container\Test;
3
4			require_once dirname(__FILE__) . '/../Container.php';
5			require_once dirname(__FILE__) . '/../ValueProxy.php';
6			require_once dirname(__FILE__) . '/../Test/Providers/ContainerProvider.php';
7			require_once dirname(__FILE__) . '/../Test/Modules/InvalidArgumentException.php';
8
9			use WebStream\Container\Container;
10			use WebStream\Container\ValueProxy;
11			use WebStream\Container\Test\Providers\ContainerProvider;
12
13			/**
14			* ContainerTest
15			* @author Ryuichi TANAKA.
16			* @since 2016/08/20
17			* @version 0.7
18			*/
19			class ContainerTest extends \PHPUnit\Framework\TestCase
20			{
21			use ContainerProvider;
22
23			/**
24			* 正常系
25			* 値を格納して取り出せること
26			* @test
27			* @dataProvider valueLazyProvider
28			*/
29			public function okContainer($value, $result)
30			{
31			$container = new Container();
32			$container->test = $value;
			0 ignored issues – show Documentation introduced 2017-10-22 12:51 UTC by Report Bug Copy Issue Report The property `test` does not exist on `object<WebStream\Container\Container>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
33			$this->assertEquals($container->test, $result);
			0 ignored issues – show Documentation introduced 2017-10-22 12:51 UTC by Report Bug Copy Issue Report The property `test` does not exist on `object<WebStream\Container\Container>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
34			}
35
36			/**
37			* 正常系

webstream-framework / Annotation

Branch — master (91c650)

ContainerTest::okRemove() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like