webshelf / framework

app/Providers/InstanceServiceProvider.php

<?php

namespace App\Providers;

use Exception;
use App\Classes\PluginManager;
use App\Classes\SettingsManager;
use Illuminate\Foundation\Application;
use App\Exceptions\EngineBootException;
use Illuminate\Support\ServiceProvider;
use App\Classes\Repositories\PluginRepository;
use App\Classes\Repositories\SettingsRepository;

/**
 * Created by PhpStorm.
 * User: Mark
 * Date: 01/02/2017
 * Time: 10:05.
 */
class InstanceServiceProvider extends ServiceProvider
{
    /**
     * The application instance.
     *
     * @var Application
     */
    protected $app;

    /**
     * Bootstrap application.
     * @return void
     */
    public function boot()
    {
        $this->makeSettingsInstance();

        $this->makePluginInstance();
    }

    private function makeSettingsInstance()
    {
        $this->app->singleton(SettingsManager::class, function () {
            try {
                return (new SettingsManager)->collect(app(SettingsRepository::class)->all());

It seems like app(App\Classes\Repositories\SettingsRepository::class)->all() can also be of type Illuminate\Database\Eloquent\Builder and App\Model\Setting; however, parameter $collection of App\Classes\SettingsManager::collect() does only seem to accept Illuminate\Support\Collection, maybe add an additional type check?

            } catch (Exception $e) {
                if ($this->app->runningInConsole()) {
                    return new SettingsManager;
                }

                throw new EngineBootException('Could not perform query on the `settings database`, do we have proper connection settings?');
            }
        });
    }

    private function makePluginInstance()
    {
        $this->app->singleton(PluginManager::class, function () {
            try {
                return (new PluginManager)->collect(app(PluginRepository::class)->all());

It seems like app(App\Classes\Repositories\PluginRepository::class)->all() can also be of type App\Model\Plugin and Illuminate\Database\Eloquent\Builder; however, parameter $collection of App\Classes\PluginManager::collect() does only seem to accept Illuminate\Support\Collection, maybe add an additional type check?

            } catch (Exception $e) {
                if ($this->app->runningInConsole()) {
                    return new PluginManager;
                }

                throw new EngineBootException('Could not perform query on the `plugins database`, do we have proper connection settings?');
            }
        });
    }
}