Issues in Audit.php (master) - Issues in master - webshelf/framework - Measure and Improve Code Quality continuously with Scrutinizer

Issues (184)

app/Model/Audit.php (2 issues)

Labels

Unused Code 2

Severity

Minor 2

<?php

namespace App\Model;

use Carbon\Carbon;
use App\Classes\Interfaces\AuditInterface;
use OwenIt\Auditing\Models\Audit as Auditing;

/**
 * Class Audit.
 *
 * @property int $id
 * @property int $user_id
 * @property string $event
 * @property int $auditable_id
 * @property string $auditable_type
 * @property array $old_values
 * @property array $new_values
 * @property string $url
 * @property string $ip_address
 * @property string $user_agent
 * @property Carbon $created_at
 * @property Carbon $updated_at
 *
 * @property Account $user
 * @property AuditInterface $auditable
 */
class Audit extends Auditing
{
    public function afterActionVerb()
    {
        switch ($this->event) {
            case 'created': return 'created the'; break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
            case 'deleted': return 'deleted the'; break;
            case 'updated': return 'updated the'; break;
        }

        return false;
    }

    public function beforeActionVerb()
    {
        switch ($this->event) {
            case 'created': return 'was generated'; break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
            case 'deleted': return 'was destroyed'; break;
            case 'updated': return 'was modified'; break;
        }

        return false;
    }

    public function model()
    {
        return explode('\\', $this->auditable_type)[2];
    }
}


1			<?php
2
3			namespace App\Model;
4
5			use Carbon\Carbon;
6			use App\Classes\Interfaces\AuditInterface;
7			use OwenIt\Auditing\Models\Audit as Auditing;
8
9			/**
10			* Class Audit.
11			*
12			* @property int $id
13			* @property int $user_id
14			* @property string $event
15			* @property int $auditable_id
16			* @property string $auditable_type
17			* @property array $old_values
18			* @property array $new_values
19			* @property string $url
20			* @property string $ip_address
21			* @property string $user_agent
22			* @property Carbon $created_at
23			* @property Carbon $updated_at
24			*
25			* @property Account $user
26			* @property AuditInterface $auditable
27			*/
28			class Audit extends Auditing
29			{
30			public function afterActionVerb()
31			{
32			switch ($this->event) {
33			case 'created': return 'created the'; break;
			0 ignored issues – show Unused Code introduced 2017-09-03 00:40 UTC by Report Bug Copy Issue Report Show Similar Issues like this `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
34			case 'deleted': return 'deleted the'; break;
35			case 'updated': return 'updated the'; break;
36			}
37
38			return false;
39			}
40
41			public function beforeActionVerb()
42			{
43			switch ($this->event) {
44			case 'created': return 'was generated'; break;
			0 ignored issues – show Unused Code introduced 2017-09-03 00:40 UTC by Report Bug Copy Issue Report Show Similar Issues like this `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
45			case 'deleted': return 'was destroyed'; break;
46			case 'updated': return 'was modified'; break;
47			}
48
49			return false;
50			}
51
52			public function model()
53			{
54			return explode('\\', $this->auditable_type)[2];
55			}
56			}
57

Scrutinizer GitHub App not installed

Issues (184)

app/Model/Audit.php (2 issues)

Labels

Severity

Introduced By

webshelf / framework

Scrutinizer GitHub App not installed

Issues (184)

app/Model/Audit.php (2 issues)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like