BackendController - Code Metrics - Inspection of "Apply fixes from StyleCI" - webshelf/framework - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#122)

by Mark

created 2018-01-23 19:37 UTC

BackendController A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	76
Duplicated Lines	47.37 %

Coupling/Cohesion

Components	1
Dependencies	5

Importance

Changes

Metric	Value
dl	36
loc	76
c	0
b	0
f	0
rs	10
wmc	8
lcom	1
cbo	5

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	index()	0	4	1
A	install()	18	18	3
A	uninstall()	18	18	3

How to fix Duplicated Code

<?php
/**
 * Created by PhpStorm.
 * User: Mark
 * Date: 23/05/2016
 * Time: 19:32.
 */

namespace App\Plugins\Products;

use App\Plugins\PluginEngine;
use App\Classes\Interfaces\Installable;
use App\Classes\Repositories\PluginRepository;

/**
 * Class AdminController.
 */
class BackendController extends PluginEngine
{
    /**
     * @var PluginRepository
     */
    private $plugins;

    /**
     * BackendController constructor.
     * @param PluginRepository $plugins
     */
    public function __construct(PluginRepository $plugins)
    {
        $this->plugins = $plugins;
    }

    /**
     * Display a list of products available and disable, enable option for super admins.
     */
    public function index()
    {
        return $this->make('index')->with('products', $this->plugins->all());
    }

    /**
     * Steps required for the application install.
     * Usually defined for logging & new sql entries.
     *
     * @param string $plugin_name
     * @return mixed

     */
    public function install(string $plugin_name)

    {
        $plugin = $this->plugins->whereName($plugin_name);

        if ($plugin->enabled == false) {
            \DB::transaction(function () use ($plugin) {
                if ($plugin->handler instanceof Installable) {
                    $plugin->handler->install();
                }

                $plugin->enabled = true;

                $plugin->save();
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            }, 5);
        }

        return response()->redirectToRoute('products.index');
    }

    /**
     * Steps required for the application uninstall.
     * Usually defined for logging & new sql entries.
     *
     * @param string $plugin_name
     * @return mixed

     */
    public function uninstall(string $plugin_name)

    {
        $plugin = $this->plugins->whereName($plugin_name);

        if ($plugin->enabled == true) {
            \DB::transaction(function () use ($plugin) {
                if ($plugin->handler instanceof Installable) {
                    $plugin->handler->uninstall();
                }

                $plugin->enabled = false;

                $plugin->save();
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            }, 5);
        }

        return response()->redirectToRoute('products.index');
    }
}


1		<?php
2		/**
3		* Created by PhpStorm.
4		* User: Mark
5		* Date: 23/05/2016
6		* Time: 19:32.
7		*/
8
9		namespace App\Plugins\Products;
10
11		use App\Plugins\PluginEngine;
12		use App\Classes\Interfaces\Installable;
13		use App\Classes\Repositories\PluginRepository;
14
15		/**
16		* Class AdminController.
17		*/
18		class BackendController extends PluginEngine
19		{
20		/**
21		* @var PluginRepository
22		*/
23		private $plugins;
24
25		/**
26		* BackendController constructor.
27		* @param PluginRepository $plugins
28		*/
29		public function __construct(PluginRepository $plugins)
30		{
31		$this->plugins = $plugins;
32		}
33
34		/**
35		* Display a list of products available and disable, enable option for super admins.
36		*/
37		public function index()
38		{
39		return $this->make('index')->with('products', $this->plugins->all());
40		}
41
42		/**
43		* Steps required for the application install.
44		* Usually defined for logging & new sql entries.
45		*
46		* @param string $plugin_name
47		* @return mixed
		0 ignored issues – show Documentation introduced 2018-01-23 19:59 UTC by Report Bug Copy Issue Report Consider making the return type a bit more specific; maybe use `\Illuminate\Http\RedirectResponse`. This check looks for the generic type `array` as a return type and suggests a more specific type. This type is inferred from the actual code. Loading history...
48		*/
49	View Code Duplication	public function install(string $plugin_name)
		0 ignored issues – show Duplication introduced 2018-01-23 19:59 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history... Coding Style Naming introduced 2018-01-23 19:59 UTC by Report Bug Copy Issue Report The parameter $plugin_name is not named in camelCase. This check marks parameter names that have not been written in camelCase. In camelCase names are written without any punctuation, the start of each new word being marked by a capital letter. Thus the name database connection string becomes `databaseConnectionString`. Loading history...
50		{
51		$plugin = $this->plugins->whereName($plugin_name);
52
53		if ($plugin->enabled == false) {
54		\DB::transaction(function () use ($plugin) {
55		if ($plugin->handler instanceof Installable) {
56		$plugin->handler->install();
57		}
58
59		$plugin->enabled = true;
60
61		$plugin->save();
		0 ignored issues – show Bug introduced 2018-01-23 19:59 UTC by Report Bug Copy Issue Report The method `save` does only exist in `App\Model\Plugin`, but not in `stdClass`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
62		}, 5);
63		}
64
65		return response()->redirectToRoute('products.index');
66		}
67
68		/**
69		* Steps required for the application uninstall.
70		* Usually defined for logging & new sql entries.
71		*
72		* @param string $plugin_name
73		* @return mixed
		0 ignored issues – show Documentation introduced 2018-01-23 19:59 UTC by Report Bug Copy Issue Report Consider making the return type a bit more specific; maybe use `\Illuminate\Http\RedirectResponse`. This check looks for the generic type `array` as a return type and suggests a more specific type. This type is inferred from the actual code. Loading history...
74		*/
75	View Code Duplication	public function uninstall(string $plugin_name)
		0 ignored issues – show Duplication introduced 2018-01-23 19:59 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history... Coding Style Naming introduced 2018-01-23 19:59 UTC by Report Bug Copy Issue Report The parameter $plugin_name is not named in camelCase. This check marks parameter names that have not been written in camelCase. In camelCase names are written without any punctuation, the start of each new word being marked by a capital letter. Thus the name database connection string becomes `databaseConnectionString`. Loading history...
76		{
77		$plugin = $this->plugins->whereName($plugin_name);
78
79		if ($plugin->enabled == true) {
80		\DB::transaction(function () use ($plugin) {
81		if ($plugin->handler instanceof Installable) {
82		$plugin->handler->uninstall();
83		}
84
85		$plugin->enabled = false;
86
87		$plugin->save();
		0 ignored issues – show Bug introduced 2018-01-23 19:59 UTC by Report Bug Copy Issue Report The method `save` does only exist in `App\Model\Plugin`, but not in `stdClass`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
88		}, 5);
89		}
90
91		return response()->redirectToRoute('products.index');
92		}
93		}
94

webshelf / framework

Scrutinizer GitHub App not installed

Pull Request — master (#122)

BackendController A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

4 Methods

How to fix Duplicated Code

Duplicated Code

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like